diff options
| author | Paul Eggert | 2019-09-22 10:43:21 -0700 |
|---|---|---|
| committer | Paul Eggert | 2019-09-22 10:45:14 -0700 |
| commit | 2f600e97e7ca43965f55f019759582d93d8bca73 (patch) | |
| tree | d885dcef77f04a60da6cec56a2750b19a8e64192 /etc | |
| parent | dddff96a585531608d5e8d27375a6363679a9fb5 (diff) | |
| download | emacs-2f600e97e7ca43965f55f019759582d93d8bca73.tar.gz emacs-2f600e97e7ca43965f55f019759582d93d8bca73.zip | |
Avoid crashes when casifying noncontiguous regions
This is a followon fix for Bug#37477.
* lisp/simple.el (region-extract-function):
Use setq here, since the var is now defined in C code.
* src/casefiddle.c (casify_pnc_region): New function.
(Fupcase_region, Fdowncase_region, Fcapitalize_region)
(Fupcase_initials_region): Use it.
(Fupcase_initials_region): Add region-noncontiguous-p flag
for consistency with the others. All uses changed.
(syms_of_casefiddle): Define Qbounds, Vregion_extract_function.
* src/insdel.c (prepare_to_modify_buffer_1):
* src/keyboard.c (command_loop_1):
Use Vregion_extraction_function.
* src/insdel.c (syms_of_insdel): No need to define
Qregion_extract_function.
* test/src/casefiddle-tests.el (casefiddle-oldfunc): New var.
(casefiddle-loopfunc, casefiddle-badfunc): New functions.
(casefiddle-invalid-region-extract-function): New test.
Diffstat (limited to 'etc')
| -rw-r--r-- | etc/NEWS | 3 |
1 files changed, 2 insertions, 1 deletions
| @@ -488,7 +488,8 @@ interface that's more like functions like 'search-forward'. | |||
| 488 | --- | 488 | --- |
| 489 | ** More commands support noncontiguous rectangular regions, namely | 489 | ** More commands support noncontiguous rectangular regions, namely |
| 490 | 'upcase-dwim', 'downcase-dwim', 'capitalize-dwim', 'capitalize-region', | 490 | 'upcase-dwim', 'downcase-dwim', 'capitalize-dwim', 'capitalize-region', |
| 491 | 'replace-string', 'replace-regexp', and 'delimit-columns-region'. | 491 | 'upcase-initials-region', 'replace-string', 'replace-regexp', and |
| 492 | 'delimit-columns-region'. | ||
| 492 | 493 | ||
| 493 | +++ | 494 | +++ |
| 494 | ** When asked to visit a large file, Emacs now offers visiting it literally. | 495 | ** When asked to visit a large file, Emacs now offers visiting it literally. |