aboutsummaryrefslogtreecommitdiffstats
path: root/etc
diff options
context:
space:
mode:
authorF. Jason Park2022-12-25 21:36:53 -0800
committerF. Jason Park2022-12-28 06:51:38 -0800
commit2ddc480f4417775d6bf8ebcfc27b8cd7fa761a7d (patch)
treec37c55716af7350cd74f3cac577dc9ccd96be8d4 /etc
parent19d00fab9aaf28dae6af5786f6e22b8558b10eea (diff)
downloademacs-2ddc480f4417775d6bf8ebcfc27b8cd7fa761a7d.tar.gz
emacs-2ddc480f4417775d6bf8ebcfc27b8cd7fa761a7d.zip
Warn of absent networks module in ERC
* doc/misc/erc.texi: Add linkable note in Modules chapter about some modules being required. Also tweak markup in auth-source section. * etc/ERC-NEWS: Mention the special role of `networks'. * lisp/erc/erc-backend.el (erc--server-post-connect-hook): Add internal hook for core modules to perform post-network-process, pre-protocol config validation even when they haven't been loaded. (erc--register-connection): Run `erc--server-post-connect-hook'. * lisp/erc/erc-networks.el (erc-networks--bouncer-targets, erc-networks-on-MOTD-end): Fix comments and doc strings. Also change former from constant to internal variable in case adjustment needed between releases. (erc-networks--warn-on-connect): New function to warn about the `networks' module being absent from `erc-modules'. This could probably run at any time up to and including when the logical IRC connection is established, but doing so at the process/protocol boundary seems ideal. * lisp/erc/erc-sasl.el (erc--register-connection): Defer to base method instead of calling `erc-login' explicitly. * lisp/erc/erc.el (erc-generate-new-buffer-name): Don't reconcile buffer names when networks module not in play. (erc-format-target-and/or-network): Don't assume networks module loaded. * test/lisp/erc/erc-scenarios-base-unstable.el: (erc-scenarios-networks-no-module): New test. * test/lisp/erc/resources/networks/no-module/basic.eld: New test data file. (Bug#60331.)
Diffstat (limited to 'etc')
-rw-r--r--etc/ERC-NEWS11
1 files changed, 10 insertions, 1 deletions
diff --git a/etc/ERC-NEWS b/etc/ERC-NEWS
index 76439f1d068..b577047ebcb 100644
--- a/etc/ERC-NEWS
+++ b/etc/ERC-NEWS
@@ -39,6 +39,14 @@ anew. The pre-5.4 "disabled" behavior has been restored and will
39remain accessible for the foreseeable future, warts and all (e.g., 39remain accessible for the foreseeable future, warts and all (e.g.,
40with its often superfluous "/DIALED-HOST" suffixing always present). 40with its often superfluous "/DIALED-HOST" suffixing always present).
41 41
42** The 'networks' module is now quasi-required.
43The 'networks' module is now all but required for everyday interactive
44use. A default member of 'erc-modules' since ERC 5.3, 'networks' has
45grown increasingly integral to core client operations over the years.
46From now on, only the most essential operations will be officially
47supported in its absence, and users will see a warning upon
48entry-point invocation when it's not present.
49
42** Tighter auth-source integration with bigger changes on the horizon. 50** Tighter auth-source integration with bigger changes on the horizon.
43The days of hit-and-miss auth-source queries are hopefully behind us. 51The days of hit-and-miss auth-source queries are hopefully behind us.
44With the overhaul of the services module temporarily shelved and the 52With the overhaul of the services module temporarily shelved and the
@@ -111,7 +119,8 @@ and 'erc-backend'.
111 119
112The function 'erc-network' always returns non-nil in server and target 120The function 'erc-network' always returns non-nil in server and target
113buffers belonging to a successfully established IRC connection, even 121buffers belonging to a successfully established IRC connection, even
114after that connection has been closed. 122after that connection has been closed. (Also see the note in the
123section above about the 'networks' module basically being mandatory.)
115 124
116In 5.4, support for network symbols as keys was added for 125In 5.4, support for network symbols as keys was added for
117'erc-autojoin-channels-alist'. This has been extended to include 126'erc-autojoin-channels-alist'. This has been extended to include