aboutsummaryrefslogtreecommitdiffstats
path: root/admin
diff options
context:
space:
mode:
authorJoão Távora2025-01-20 17:23:08 +0000
committerJoão Távora2025-01-20 17:43:35 +0000
commit73f51f3a99ed454fa57e5ebe177df00cada1f11a (patch)
tree1583459fa7951fe1d1e8225612f87c61d6f3e0a9 /admin
parent275df7420cfb6a514171cb69a03235ee09aebebf (diff)
downloademacs-73f51f3a99ed454fa57e5ebe177df00cada1f11a.tar.gz
emacs-73f51f3a99ed454fa57e5ebe177df00cada1f11a.zip
Eglot: try again to fix try-completion logic
Emacs partial completion simply doesn't make sense in LSP. Attempts to make it make some sense end up failing for one reason or another. This commit restores the original intention of the eglot--dumb-allc and eglot--dumb-tryc functions, which was to be dumb and pop up a *Completions* buffer (or a company tooltip), as soon as there is doubt over what the user wants to do. It also fixes tests, including an expensive Rust test that had been broken for a long time. * lisp/progmodes/eglot.el (eglot--dumb-allc): Consider point. (eglot--dumb-tryc): Make it suitably dumb again. * test/lisp/progmodes/eglot-tests.el (eglot--wait-for-rust-analyzer): Wait longer. (eglot-test-common-prefix-completion): Delete this test. It's not the intended behavior. (eglot--kill-completions-buffer): New helper. (eglot-test-try-completion-nomatch): Rework test. (eglot-test-try-completion-inside-symbol): Pops *Completions* buffer because mustn't partial complete. (eglot-test-try-completion-inside-symbol-2): Does complete. (eglot-test-rust-completion-exit-function): Fix long-broken test.
Diffstat (limited to 'admin')
0 files changed, 0 insertions, 0 deletions