diff options
| author | Paul Eggert | 2012-09-12 19:21:28 -0700 |
|---|---|---|
| committer | Paul Eggert | 2012-09-12 19:21:28 -0700 |
| commit | 4a4bbad21472cc0ede4691cbdbf8117b655b574f (patch) | |
| tree | 5c74092d854ca8b770578b8b7f99f5f3a9e65ca2 /admin/CPP-DEFINES | |
| parent | bd8d610845a89c2cf5d7d75ff552df572b30f5e7 (diff) | |
| download | emacs-4a4bbad21472cc0ede4691cbdbf8117b655b574f.tar.gz emacs-4a4bbad21472cc0ede4691cbdbf8117b655b574f.zip | |
Simplify SIGIO usage.
The code that dealt with SIGIO was crufty and confusing, e.g., it
played tricks like "#undef SIGIO" but these tricks were not used
consistently. Simplify mostly by not #undeffing standard symbols,
e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
or not as we please) rather than "defined SIGIO" (standard symbol
that we probably shouldn't #undef).
* configure.ac (NO_TERMIO, BROKEN_FIONREAD, BROKEN_SIGAIO)
(BROKEN_SIGPOLL, BROKEN_SIGPTY): Remove.
(USABLE_FIONREAD, USABLE_SIGIO): New symbols. All uses of
'defined SIGIO' replaced with 'defined USABLE_SIGIO', with no need
to #undef SIGIO now (which was error-prone). Likewise, all uses
of 'defined FIONREAD' replaced with 'defined USABLE_FIONREAD'.
* src/admin/CPP_DEFINES (BROKEN_SIGAIO, BROKEN_SIGIO, BROKEN_SIGPOLL)
(BROKEN_SIGPTY, NO_TERMIO): Remove.
* src/conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
Modules that need it can include it.
[USG5_4 && emacs]: Likewise, do not include the streams stuff here.
* src/dispextern.h (ignore_sigio): New decl.
* src/emacs.c (shut_down_emacs): Invoke unrequest_sigio
unconditionally, since it's now a no-op if !USABLE_SIGIO.
* src/emacs.c (shut_down_emacs):
* src/keyboard.c (kbd_buffer_store_event_hold):
Use ignore_sigio rather than invoking 'signal' directly.
* src/keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
for FIONREAD.
(FIONREAD, SIGIO): Do not #undef.
(tty_read_avail_input): Use #error rather than a syntax error.
* src/process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
for I_PIPE, used by SETUP_SLAVE_PTY.
(DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
* src/sysdep.c (croak): Remove; no longer needed. This bit of
temporary code, with Fred N. Fish's comment that it's temporary,
has been in Emacs since at least 1992!
(init_sigio, reset_sigio, request_sigio, unrequest_sigio):
Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
* src/syssignal.h (croak): Remove decl.
(SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
* src/systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
now that we're termios-only.
(FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
* src/term.c (dissociate_if_controlling_tty): Use #error rather than
a run-time error.
Fixes: debbugs:12408
Diffstat (limited to 'admin/CPP-DEFINES')
| -rw-r--r-- | admin/CPP-DEFINES | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/admin/CPP-DEFINES b/admin/CPP-DEFINES index cf6ffee2c63..834695d6c78 100644 --- a/admin/CPP-DEFINES +++ b/admin/CPP-DEFINES | |||
| @@ -91,10 +91,6 @@ BROKEN_GET_CURRENT_DIR_NAME | |||
| 91 | BROKEN_NON_BLOCKING_CONNECT | 91 | BROKEN_NON_BLOCKING_CONNECT |
| 92 | BROKEN_PTY_READ_AFTER_EAGAIN | 92 | BROKEN_PTY_READ_AFTER_EAGAIN |
| 93 | BROKEN_SA_RESTART | 93 | BROKEN_SA_RESTART |
| 94 | BROKEN_SIGAIO | ||
| 95 | BROKEN_SIGIO | ||
| 96 | BROKEN_SIGPOLL | ||
| 97 | BROKEN_SIGPTY | ||
| 98 | CLASH_DETECTION | 94 | CLASH_DETECTION |
| 99 | DATA_SEG_BITS | 95 | DATA_SEG_BITS |
| 100 | DATA_START | 96 | DATA_START |
| @@ -423,7 +419,6 @@ MAIL_USE_SYSTEM_LOCK | |||
| 423 | MAXPATHLEN | 419 | MAXPATHLEN |
| 424 | NLIST_STRUCT | 420 | NLIST_STRUCT |
| 425 | NO_EDITRES | 421 | NO_EDITRES |
| 426 | NO_TERMIO | ||
| 427 | NSIG | 422 | NSIG |
| 428 | NSIG_MINIMUM | 423 | NSIG_MINIMUM |
| 429 | NULL_DEVICE | 424 | NULL_DEVICE |