Don't highlight matches in dired query-replace commands

* lisp/dired-aux.el (dired-do-query-replace-regexp)
(dired-do-replace-regexp-as-diff)
(dired-do-find-regexp-and-replace): Turn off lazy highlighting
when reading the regexp from the user to avoid highlighting
regexp matches in the dired buffer. (bug#72147)

1 files changed, 10 insertions, 7 deletions

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index e06e36aaa75..decd9702eaf 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -3801,9 +3801,10 @@ Third arg DELIMITED (prefix arg) means replace only word-delimited matches.
 If you exit the query-replace loop (\\[keyboard-quit], RET or q), you can
 resume the query replace with the command \\[fileloop-continue]."
   (interactive
-   (let ((common
-          (query-replace-read-args
-           "Query replace regexp in marked files" t t)))
+   (let* ((query-replace-lazy-highlight)
+          (common
+           (query-replace-read-args
+            "Query replace regexp in marked files" t t)))
      (list (nth 0 common) (nth 1 common) (nth 2 common)))
    dired-mode)
   (dolist (file (dired-get-marked-files nil nil #'dired-nondirectory-p nil t))
@@ -3825,9 +3826,10 @@ Third arg DELIMITED (prefix arg) means replace only word-delimited matches.
 The replacements are displayed in the buffer *replace-diff* that
 you can later apply as a patch after reviewing the changes."
   (interactive
-   (let ((common
-          (query-replace-read-args
-           "Replace regexp as diff in marked files" t t)))
+   (let* ((query-replace-lazy-highlight)
+          (common
+           (query-replace-read-args
+            "Replace regexp as diff in marked files" t t)))
      (list (nth 0 common) (nth 1 common) (nth 2 common))))
   (dired-post-do-command)
   (multi-file-replace-regexp-as-diff
@@ -3901,7 +3903,8 @@ REGEXP should use constructs supported by your local `grep' command.
 Also see `query-replace' for user options that affect how this
 function works."
   (interactive
-   (let ((common
+   (let* ((query-replace-lazy-highlight)
+          (common
           (query-replace-read-args
            "Query replace regexp in marked files" t t)))
      (list (nth 0 common) (nth 1 common)))