diff options
| author | Tino Calancha | 2017-07-30 20:28:33 +0900 |
|---|---|---|
| committer | Tino Calancha | 2017-07-30 20:28:33 +0900 |
| commit | c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e (patch) | |
| tree | 684c170f5863a9cc63ddd54edd56050b8f11fdf5 | |
| parent | 6c106712a8d2ffd0c932541cb50cc59a6df732f4 (diff) | |
| download | emacs-c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e.tar.gz emacs-c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e.zip | |
ls-lisp: Do not require em-glob at top of the file
Require em-glob inside 'ls-lisp--dired'. This is necessary to
not break the Emacs build.
See following thread for details:
https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg01083.html
* lisp/ls-lisp.el (dired-goto-next-file)
(dired-read-dir-and-switches, eshell-extended-glob):
Add function declarations.
* lisp/eshell/em-ls.el (dired-goto-next-file): Fix function declaration.
| -rw-r--r-- | lisp/eshell/em-ls.el | 2 | ||||
| -rw-r--r-- | lisp/ls-lisp.el | 6 |
2 files changed, 6 insertions, 2 deletions
diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 948ac38b5f2..4a5adc48f2b 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el | |||
| @@ -283,7 +283,7 @@ instead." | |||
| 283 | 283 | ||
| 284 | (declare-function eshell-extended-glob "em-glob" (glob)) | 284 | (declare-function eshell-extended-glob "em-glob" (glob)) |
| 285 | (declare-function dired-read-dir-and-switches "dired" (str)) | 285 | (declare-function dired-read-dir-and-switches "dired" (str)) |
| 286 | (declare-function dired-goto-next-file "em-glob" ()) | 286 | (declare-function dired-goto-next-file "dired" ()) |
| 287 | 287 | ||
| 288 | (defun eshell-ls--dired (orig-fun dir-or-list &optional switches) | 288 | (defun eshell-ls--dired (orig-fun dir-or-list &optional switches) |
| 289 | (interactive (dired-read-dir-and-switches "")) | 289 | (interactive (dired-read-dir-and-switches "")) |
diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el index 56780daa09f..2f723ca8ac8 100644 --- a/lisp/ls-lisp.el +++ b/lisp/ls-lisp.el | |||
| @@ -61,7 +61,6 @@ | |||
| 61 | ;;; Code: | 61 | ;;; Code: |
| 62 | 62 | ||
| 63 | 63 | ||
| 64 | (require 'em-glob) | ||
| 65 | 64 | ||
| 66 | (defgroup ls-lisp nil | 65 | (defgroup ls-lisp nil |
| 67 | "Emulate the ls program completely in Emacs Lisp." | 66 | "Emulate the ls program completely in Emacs Lisp." |
| @@ -481,8 +480,13 @@ not contain `d', so that a full listing is expected." | |||
| 481 | (ding) (sit-for 2))))) ; to show user the message! | 480 | (ding) (sit-for 2))))) ; to show user the message! |
| 482 | 481 | ||
| 483 | 482 | ||
| 483 | (declare-function eshell-extended-glob "em-glob" (glob)) | ||
| 484 | (declare-function dired-read-dir-and-switches "dired" (str)) | ||
| 485 | (declare-function dired-goto-next-file "dired" ()) | ||
| 486 | |||
| 484 | (defun ls-lisp--dired (orig-fun dir-or-list &optional switches) | 487 | (defun ls-lisp--dired (orig-fun dir-or-list &optional switches) |
| 485 | (interactive (dired-read-dir-and-switches "")) | 488 | (interactive (dired-read-dir-and-switches "")) |
| 489 | (require 'em-glob) | ||
| 486 | (if (consp dir-or-list) | 490 | (if (consp dir-or-list) |
| 487 | (funcall orig-fun dir-or-list switches) | 491 | (funcall orig-fun dir-or-list switches) |
| 488 | (let ((dir-wildcard (insert-directory-wildcard-in-dir-p | 492 | (let ((dir-wildcard (insert-directory-wildcard-in-dir-p |