aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Monnier2014-10-08 23:04:59 -0400
committerStefan Monnier2014-10-08 23:04:59 -0400
commitfdcb06012a36a8ec800e33554ae94c26e43a7c05 (patch)
tree28092bfee31b86d81680aeec6e0f8049272fbf83
parentb4030330c8a8d807065292a05286962ffe3c4d57 (diff)
downloademacs-fdcb06012a36a8ec800e33554ae94c26e43a7c05.tar.gz
emacs-fdcb06012a36a8ec800e33554ae94c26e43a7c05.zip
* lisp/frame.el (make-frame): Use t rather than nil for `w'.
Fixes: debbugs:18653
-rw-r--r--lisp/ChangeLog8
-rw-r--r--lisp/frame.el33
2 files changed, 24 insertions, 17 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 87852d64a46..c8c6f61cdcf 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
12014-10-09 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * frame.el (make-frame): Use t rather than nil for `w' (bug#18653).
4
12014-10-08 Leo Liu <sdl.web@gmail.com> 52014-10-08 Leo Liu <sdl.web@gmail.com>
2 6
3 * emacs-lisp/cl-extra.el (cl-fresh-line): New function. 7 * emacs-lisp/cl-extra.el (cl-fresh-line): New function.
@@ -9,8 +13,8 @@
9 13
102014-10-08 Leo Liu <sdl.web@gmail.com> 142014-10-08 Leo Liu <sdl.web@gmail.com>
11 15
12 * progmodes/cfengine.el (cfengine3-make-syntax-cache): Always 16 * progmodes/cfengine.el (cfengine3-make-syntax-cache):
13 return a syntax. Replace call-process-shell-command with 17 Always return a syntax. Replace call-process-shell-command with
14 process-file. Ensure cfengine-mode-syntax-functions-regex is 18 process-file. Ensure cfengine-mode-syntax-functions-regex is
15 always set. Ensure cache when cfengine-cf-promises fails. 19 always set. Ensure cache when cfengine-cf-promises fails.
16 (Bug#18620) 20 (Bug#18620)
diff --git a/lisp/frame.el b/lisp/frame.el
index bd055b7d6df..34f35db34b7 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -646,20 +646,23 @@ frame the selected frame. However, the window system may select
646the new frame according to its own rules." 646the new frame according to its own rules."
647 (interactive) 647 (interactive)
648 (let* ((display (cdr (assq 'display parameters))) 648 (let* ((display (cdr (assq 'display parameters)))
649 (w (cond 649 (w (or
650 ((assq 'terminal parameters) 650 (cond
651 (let ((type (terminal-live-p (cdr (assq 'terminal parameters))))) 651 ((assq 'terminal parameters)
652 (cond 652 (let ((type (terminal-live-p
653 ((null type) (error "Terminal %s does not exist" 653 (cdr (assq 'terminal parameters)))))
654 (cdr (assq 'terminal parameters)))) 654 (cond
655 (t type)))) 655 ((null type) (error "Terminal %s does not exist"
656 ((assq 'window-system parameters) 656 (cdr (assq 'terminal parameters))))
657 (cdr (assq 'window-system parameters))) 657 (t type))))
658 (display 658 ((assq 'window-system parameters)
659 (or (window-system-for-display display) 659 (cdr (assq 'window-system parameters)))
660 (error "Don't know how to interpret display %S" 660 (display
661 display))) 661 (or (window-system-for-display display)
662 (t window-system))) 662 (error "Don't know how to interpret display %S"
663 display)))
664 (t window-system))
665 t))
663 (oldframe (selected-frame)) 666 (oldframe (selected-frame))
664 (params parameters) 667 (params parameters)
665 frame) 668 frame)
@@ -680,7 +683,7 @@ the new frame according to its own rules."
680 ;; Now make the frame. 683 ;; Now make the frame.
681 (run-hooks 'before-make-frame-hook) 684 (run-hooks 'before-make-frame-hook)
682 (setq frame 685 (setq frame
683 (funcall (gui-method frame-creation-function (or w t)) params)) 686 (funcall (gui-method frame-creation-function w) params))
684 (normal-erase-is-backspace-setup-frame frame) 687 (normal-erase-is-backspace-setup-frame frame)
685 ;; Inherit the original frame's parameters. 688 ;; Inherit the original frame's parameters.
686 (dolist (param frame-inherited-parameters) 689 (dolist (param frame-inherited-parameters)