diff options
| author | Karl Fogel | 2010-12-12 11:53:24 -0500 |
|---|---|---|
| committer | Karl Fogel | 2010-12-12 11:53:24 -0500 |
| commit | fdbb4d85ffa2ac30cb7ac0ceea6f12d0c8054d6c (patch) | |
| tree | c6ab9b5c374928b4728a22bc540ae86d4c9c76fd | |
| parent | 0e5cf2b8a5566f46cb6c8edcf3d7a6172f491e50 (diff) | |
| download | emacs-fdbb4d85ffa2ac30cb7ac0ceea6f12d0c8054d6c.tar.gz emacs-fdbb4d85ffa2ac30cb7ac0ceea6f12d0c8054d6c.zip | |
* lisp/bookmark.el (bookmark-name-from-full-record): Rename back to
this original name from `bookmark-name-from-record' reverting part of
2010-12-08T08:09:27Z!kfogel@red-bean.com / kfogel@red-bean.com-20101208080927-5j9jqnb2xvcw4ogm.
As Drew Adams pointed out, there was no reason to cause churn for
third-party callers.
| -rw-r--r-- | lisp/ChangeLog | 8 | ||||
| -rw-r--r-- | lisp/bookmark.el | 12 |
2 files changed, 14 insertions, 6 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index dd1b4a400ee..5b0fab21cc9 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,11 @@ | |||
| 1 | 2010-12-12 Karl Fogel <kfogel@red-bean.com> | ||
| 2 | |||
| 3 | * bookmark.el (bookmark-name-from-full-record): Rename back to | ||
| 4 | this original name from `bookmark-name-from-record' reverting part | ||
| 5 | of 2010-12-08T08:09:27Z!kfogel@red-bean.com / kfogel@red-bean.com-20101208080927-5j9jqnb2xvcw4ogm. | ||
| 6 | As Drew Adams pointed out, there was no reason to cause churn for | ||
| 7 | third-party callers. | ||
| 8 | |||
| 1 | 2010-12-12 Alan Mackenzie <acm@muc.de> | 9 | 2010-12-12 Alan Mackenzie <acm@muc.de> |
| 2 | 10 | ||
| 3 | * progmodes/cc-engine.el (c-forward-type): Before scanning a | 11 | * progmodes/cc-engine.el (c-forward-type): Before scanning a |
diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 268a370cdb6..9c1034c636e 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el | |||
| @@ -305,7 +305,7 @@ This point is in `bookmark-current-buffer'.") | |||
| 305 | ;; need to know anything about the format of bookmark-alist entries. | 305 | ;; need to know anything about the format of bookmark-alist entries. |
| 306 | ;; Everyone else should go through them. | 306 | ;; Everyone else should go through them. |
| 307 | 307 | ||
| 308 | (defun bookmark-name-from-record (bookmark-record) | 308 | (defun bookmark-name-from-full-record (bookmark-record) |
| 309 | "Return the name of BOOKMARK-RECORD. BOOKMARK-RECORD is, e.g., | 309 | "Return the name of BOOKMARK-RECORD. BOOKMARK-RECORD is, e.g., |
| 310 | one element from `bookmark-alist'." | 310 | one element from `bookmark-alist'." |
| 311 | (car bookmark-record)) | 311 | (car bookmark-record)) |
| @@ -314,7 +314,7 @@ one element from `bookmark-alist'." | |||
| 314 | (defun bookmark-all-names () | 314 | (defun bookmark-all-names () |
| 315 | "Return a list of all current bookmark names." | 315 | "Return a list of all current bookmark names." |
| 316 | (bookmark-maybe-load-default-file) | 316 | (bookmark-maybe-load-default-file) |
| 317 | (mapcar 'bookmark-name-from-record bookmark-alist)) | 317 | (mapcar 'bookmark-name-from-full-record bookmark-alist)) |
| 318 | 318 | ||
| 319 | 319 | ||
| 320 | (defun bookmark-get-bookmark (bookmark-name-or-record &optional noerror) | 320 | (defun bookmark-get-bookmark (bookmark-name-or-record &optional noerror) |
| @@ -1391,13 +1391,13 @@ they conflict with existing bookmark names." | |||
| 1391 | (dolist (full-record new-list) | 1391 | (dolist (full-record new-list) |
| 1392 | (bookmark-maybe-rename full-record names) | 1392 | (bookmark-maybe-rename full-record names) |
| 1393 | (setq bookmark-alist (nconc bookmark-alist (list full-record))) | 1393 | (setq bookmark-alist (nconc bookmark-alist (list full-record))) |
| 1394 | (push (bookmark-name-from-record full-record) names)))) | 1394 | (push (bookmark-name-from-full-record full-record) names)))) |
| 1395 | 1395 | ||
| 1396 | 1396 | ||
| 1397 | (defun bookmark-maybe-rename (full-record names) | 1397 | (defun bookmark-maybe-rename (full-record names) |
| 1398 | "Rename bookmark FULL-RECORD if its current name is already used. | 1398 | "Rename bookmark FULL-RECORD if its current name is already used. |
| 1399 | This is a helper for `bookmark-import-new-list'." | 1399 | This is a helper for `bookmark-import-new-list'." |
| 1400 | (let ((found-name (bookmark-name-from-record full-record))) | 1400 | (let ((found-name (bookmark-name-from-full-record full-record))) |
| 1401 | (if (member found-name names) | 1401 | (if (member found-name names) |
| 1402 | ;; We've got a conflict, so generate a new name | 1402 | ;; We've got a conflict, so generate a new name |
| 1403 | (let ((count 2) | 1403 | (let ((count 2) |
| @@ -1555,7 +1555,7 @@ deletion, or > if it is flagged for displaying." | |||
| 1555 | (add-text-properties (point-min) (point) | 1555 | (add-text-properties (point-min) (point) |
| 1556 | '(font-lock-face bookmark-menu-heading)) | 1556 | '(font-lock-face bookmark-menu-heading)) |
| 1557 | (dolist (full-record (bookmark-maybe-sort-alist)) | 1557 | (dolist (full-record (bookmark-maybe-sort-alist)) |
| 1558 | (let ((name (bookmark-name-from-record full-record)) | 1558 | (let ((name (bookmark-name-from-full-record full-record)) |
| 1559 | (annotation (bookmark-get-annotation full-record)) | 1559 | (annotation (bookmark-get-annotation full-record)) |
| 1560 | (start (point)) | 1560 | (start (point)) |
| 1561 | end) | 1561 | end) |
| @@ -1745,7 +1745,7 @@ if an annotation exists." | |||
| 1745 | (pop-to-buffer (get-buffer-create "*Bookmark Annotation*") t) | 1745 | (pop-to-buffer (get-buffer-create "*Bookmark Annotation*") t) |
| 1746 | (delete-region (point-min) (point-max)) | 1746 | (delete-region (point-min) (point-max)) |
| 1747 | (dolist (full-record bookmark-alist) | 1747 | (dolist (full-record bookmark-alist) |
| 1748 | (let* ((name (bookmark-name-from-record full-record)) | 1748 | (let* ((name (bookmark-name-from-full-record full-record)) |
| 1749 | (ann (bookmark-get-annotation full-record))) | 1749 | (ann (bookmark-get-annotation full-record))) |
| 1750 | (insert (concat name ":\n")) | 1750 | (insert (concat name ":\n")) |
| 1751 | (if (and ann (not (string-equal ann ""))) | 1751 | (if (and ann (not (string-equal ann ""))) |