Revision: emacs@sv.gnu.org/emacs--devo--0--patch-238

Merge from gnus--rel--5.10

Patches applied:

 * gnus--rel--5.10  (patch 87-90)

   - Merge from emacs--devo--0
   - Update from CVS

4 files changed, 34 insertions, 15 deletions

diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog
index 09dbe9e0027..c66def4af66 100644
--- a/lisp/gnus/ChangeLog
+++ b/lisp/gnus/ChangeLog
@@ -1,3 +1,18 @@
+2006-04-20  Reiner Steib  <Reiner.Steib@gmx.de>
+
+        * gnus-util.el (gnus-replace-in-string): Prefer
+        replace-regexp-in-string over of replace-in-string.
+
+2006-04-20  Katsumi Yamaoka  <yamaoka@jpl.org>
+
+        * gnus-group.el: Bind tool-bar-mode instead of tool-bar-map.
+
+        * gnus-sum.el: Ditto.
+
+        * gnus-util.el (gnus-select-frame-set-input-focus): Use
+        select-frame-set-input-focus if it is available in XEmacs; use
+        definition defined in Emacs 22 for old Emacsen.
+
 2006-04-17  Reiner Steib  <Reiner.Steib@gmx.de>
 
         [ Merge from Gnus trunk. ]
diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 51af7d48d9c..f3ca6248811 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -29,7 +29,7 @@
 
 (eval-when-compile
   (require 'cl)
-  (defvar tool-bar-map))
+  (defvar tool-bar-mode))
 
 (require 'gnus)
 (require 'gnus-start)
diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index 0de73bc879a..daecb1701cd 100644
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -29,7 +29,7 @@
 
 (eval-when-compile
   (require 'cl)
-  (defvar tool-bar-map))
+  (defvar tool-bar-mode))
 
 (require 'gnus)
 (require 'gnus-group)
diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el
index cb3a4e9209c..6b525fc490c 100644
--- a/lisp/gnus/gnus-util.el
+++ b/lisp/gnus/gnus-util.el
@@ -61,8 +61,11 @@
 
 (eval-and-compile
   (cond
-   ((fboundp 'replace-in-string)
-    (defalias 'gnus-replace-in-string 'replace-in-string))
+   ;; Prefer `replace-regexp-in-string' (present in Emacs, XEmacs 21.5,
+   ;; SXEmacs 22.1.4) over `replace-in-string'.  The later leads to inf-loops
+   ;; on empty matches:
+   ;;   (replace-in-string "foo" "/*$" "/")
+   ;;   (replace-in-string "xe" "\\(x\\)?" "")
    ((fboundp 'replace-regexp-in-string)
     (defun gnus-replace-in-string (string regexp newtext &optional literal)
       "Replace all matches for REGEXP with NEWTEXT in STRING.
@@ -71,6 +74,8 @@ string containing the replacements.
 
 This is a compatibility function for different Emacsen."
       (replace-regexp-in-string regexp newtext string nil literal)))
+   ((fboundp 'replace-in-string)
+    (defalias 'gnus-replace-in-string 'replace-in-string))
    (t
     (defun gnus-replace-in-string (string regexp newtext &optional literal)
       "Replace all matches for REGEXP with NEWTEXT in STRING.
@@ -1424,20 +1429,19 @@ CHOICE is a list of the choice char and help message at IDX."
 (defun gnus-select-frame-set-input-focus (frame)
   "Select FRAME, raise it, and set input focus, if possible."
   (cond ((featurep 'xemacs)
-         (raise-frame frame)
-         (select-frame frame)
-         (focus-frame frame))
-        ;; The function `select-frame-set-input-focus' won't set
-        ;; the input focus under Emacs 21.2 and X window system.
-        ;;((fboundp 'select-frame-set-input-focus)
-        ;; (defalias 'gnus-select-frame-set-input-focus
-        ;;   'select-frame-set-input-focus)
-        ;; (select-frame-set-input-focus frame))
+         (if (fboundp 'select-frame-set-input-focus)
+             (select-frame-set-input-focus frame)
+           (raise-frame frame)
+           (select-frame frame)
+           (focus-frame frame)))
+        ;; `select-frame-set-input-focus' defined in Emacs 21 will not
+        ;; set the input focus.
+        ((>= emacs-major-version 22)
+         (select-frame-set-input-focus frame))
         (t
          (raise-frame frame)
          (select-frame frame)
-         (cond ((and (eq window-system 'x)
-                     (fboundp 'x-focus-frame))
+         (cond ((memq window-system '(x mac))
                 (x-focus-frame frame))
                ((eq window-system 'w32)
                 (w32-focus-frame frame)))