aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJuanma Barranquero2009-10-16 05:03:56 +0000
committerJuanma Barranquero2009-10-16 05:03:56 +0000
commitf3ed9aca2816b6488ad2ea0733adfa22079dad57 (patch)
treee7e8d9350a73e0bac7493f2245e4e429b181503b
parent6e4780c5adc77a327af7a9ecc10b027e9bc4301d (diff)
downloademacs-f3ed9aca2816b6488ad2ea0733adfa22079dad57.tar.gz
emacs-f3ed9aca2816b6488ad2ea0733adfa22079dad57.zip
* subr.el (error, sit-for, start-process-shell-command)
(start-file-process-shell-command): Set the calling convention after the function definition.
-rw-r--r--lisp/ChangeLog6
-rw-r--r--lisp/subr.el12
2 files changed, 12 insertions, 6 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a83cfa4d122..d48b95612b3 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
12009-10-16 Juanma Barranquero <lekktu@gmail.com>
2
3 * subr.el (error, sit-for, start-process-shell-command)
4 (start-file-process-shell-command): Set the calling convention
5 after the function definition.
6
12009-10-16 Stefan Monnier <monnier@iro.umontreal.ca> 72009-10-16 Stefan Monnier <monnier@iro.umontreal.ca>
2 8
3 * subr.el (error, sit-for, start-process-shell-command) 9 * subr.el (error, sit-for, start-process-shell-command)
diff --git a/lisp/subr.el b/lisp/subr.el
index 070f472a3b6..ad5a061584d 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -230,7 +230,6 @@ This function accepts any number of arguments, but ignores them."
230 nil) 230 nil)
231 231
232;; Signal a compile-error if the first arg is missing. 232;; Signal a compile-error if the first arg is missing.
233(set-advertised-calling-convention 'error '(string &rest args))
234(defun error (&rest args) 233(defun error (&rest args)
235 "Signal an error, making error message by passing all args to `format'. 234 "Signal an error, making error message by passing all args to `format'.
236In Emacs, the convention is that error messages start with a capital 235In Emacs, the convention is that error messages start with a capital
@@ -238,6 +237,7 @@ letter but *do not* end with a period. Please follow this convention
238for the sake of consistency." 237for the sake of consistency."
239 (while t 238 (while t
240 (signal 'error (list (apply 'format args))))) 239 (signal 'error (list (apply 'format args)))))
240(set-advertised-calling-convention 'error '(string &rest args))
241 241
242;; We put this here instead of in frame.el so that it's defined even on 242;; We put this here instead of in frame.el so that it's defined even on
243;; systems where frame.el isn't loaded. 243;; systems where frame.el isn't loaded.
@@ -2011,7 +2011,6 @@ The value of DEFAULT is inserted into PROMPT."
2011 t))) 2011 t)))
2012 n)) 2012 n))
2013 2013
2014(set-advertised-calling-convention 'sit-for '(seconds &optional nodisp))
2015(defun sit-for (seconds &optional nodisp obsolete) 2014(defun sit-for (seconds &optional nodisp obsolete)
2016 "Perform redisplay, then wait for SECONDS seconds or until input is available. 2015 "Perform redisplay, then wait for SECONDS seconds or until input is available.
2017SECONDS may be a floating-point value. 2016SECONDS may be a floating-point value.
@@ -2052,6 +2051,7 @@ floating point support."
2052 (setq read (cons t read))) 2051 (setq read (cons t read)))
2053 (push read unread-command-events) 2052 (push read unread-command-events)
2054 nil)))))) 2053 nil))))))
2054(set-advertised-calling-convention 'sit-for '(seconds &optional nodisp))
2055 2055
2056;;; Atomic change groups. 2056;;; Atomic change groups.
2057 2057
@@ -2564,8 +2564,6 @@ Strip text properties from the inserted text according to
2564 2564
2565;;;; Synchronous shell commands. 2565;;;; Synchronous shell commands.
2566 2566
2567(set-advertised-calling-convention 'start-process-shell-command
2568 '(name buffer command))
2569(defun start-process-shell-command (name buffer &rest args) 2567(defun start-process-shell-command (name buffer &rest args)
2570 "Start a program in a subprocess. Return the process object for it. 2568 "Start a program in a subprocess. Return the process object for it.
2571NAME is name for process. It is modified if necessary to make it unique. 2569NAME is name for process. It is modified if necessary to make it unique.
@@ -2583,9 +2581,9 @@ discouraged."
2583 ;; but that failed to handle (...) and semicolon, etc. 2581 ;; but that failed to handle (...) and semicolon, etc.
2584 (start-process name buffer shell-file-name shell-command-switch 2582 (start-process name buffer shell-file-name shell-command-switch
2585 (mapconcat 'identity args " "))) 2583 (mapconcat 'identity args " ")))
2586 2584(set-advertised-calling-convention 'start-process-shell-command
2587(set-advertised-calling-convention 'start-file-process-shell-command
2588 '(name buffer command)) 2585 '(name buffer command))
2586
2589(defun start-file-process-shell-command (name buffer &rest args) 2587(defun start-file-process-shell-command (name buffer &rest args)
2590 "Start a program in a subprocess. Return the process object for it. 2588 "Start a program in a subprocess. Return the process object for it.
2591Similar to `start-process-shell-command', but calls `start-file-process'." 2589Similar to `start-process-shell-command', but calls `start-file-process'."
@@ -2594,6 +2592,8 @@ Similar to `start-process-shell-command', but calls `start-file-process'."
2594 (if (file-remote-p default-directory) "/bin/sh" shell-file-name) 2592 (if (file-remote-p default-directory) "/bin/sh" shell-file-name)
2595 (if (file-remote-p default-directory) "-c" shell-command-switch) 2593 (if (file-remote-p default-directory) "-c" shell-command-switch)
2596 (mapconcat 'identity args " "))) 2594 (mapconcat 'identity args " ")))
2595(set-advertised-calling-convention 'start-file-process-shell-command
2596 '(name buffer command))
2597 2597
2598(defun call-process-shell-command (command &optional infile buffer display 2598(defun call-process-shell-command (command &optional infile buffer display
2599 &rest args) 2599 &rest args)