diff options
| author | Glenn Morris | 2018-03-05 13:36:05 -0500 |
|---|---|---|
| committer | Glenn Morris | 2018-03-05 13:36:05 -0500 |
| commit | f02ce3b1e41c735c3b1a0da4e45434c7b8313bde (patch) | |
| tree | 6c548f59138978acb3a2e3192074cc62e62d6a7c | |
| parent | a2ad931bb379dcd5805ae51ac9178266985b12e4 (diff) | |
| download | emacs-f02ce3b1e41c735c3b1a0da4e45434c7b8313bde.tar.gz emacs-f02ce3b1e41c735c3b1a0da4e45434c7b8313bde.zip | |
; Add fixme comments re password caching
| -rw-r--r-- | lisp/gnus/mml-sec.el | 1 | ||||
| -rw-r--r-- | lisp/gnus/smime.el | 1 | ||||
| -rw-r--r-- | lisp/net/tramp.el | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index 3855d7b7964..dc10763da86 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el | |||
| @@ -647,6 +647,7 @@ The passphrase is read and cached." | |||
| 647 | (when passphrase | 647 | (when passphrase |
| 648 | (let ((password-cache-expiry (mml-secure-cache-expiry-interval | 648 | (let ((password-cache-expiry (mml-secure-cache-expiry-interval |
| 649 | (epg-context-protocol context)))) | 649 | (epg-context-protocol context)))) |
| 650 | ;; FIXME test passphrase works before caching it. | ||
| 650 | (password-cache-add password-cache-key-id passphrase)) | 651 | (password-cache-add password-cache-key-id passphrase)) |
| 651 | (mml-secure-add-secret-key-id password-cache-key-id) | 652 | (mml-secure-add-secret-key-id password-cache-key-id) |
| 652 | (copy-sequence passphrase))))) | 653 | (copy-sequence passphrase))))) |
diff --git a/lisp/gnus/smime.el b/lisp/gnus/smime.el index d55cea724fb..ab2a5b0f813 100644 --- a/lisp/gnus/smime.el +++ b/lisp/gnus/smime.el | |||
| @@ -238,6 +238,7 @@ password under `cache-key'." | |||
| 238 | "Passphrase for secret key (RET for no passphrase): " cache-key))) | 238 | "Passphrase for secret key (RET for no passphrase): " cache-key))) |
| 239 | (if (string= passphrase "") | 239 | (if (string= passphrase "") |
| 240 | nil | 240 | nil |
| 241 | ;; FIXME test passphrase works before caching it. | ||
| 241 | (and passphrase cache-key (password-cache-add cache-key passphrase)) | 242 | (and passphrase cache-key (password-cache-add cache-key passphrase)) |
| 242 | passphrase))) | 243 | passphrase))) |
| 243 | 244 | ||
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index 60112392537..fe9f1976944 100644 --- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el | |||
| @@ -4459,6 +4459,7 @@ Invokes `password-read' if available, `read-passwd' else." | |||
| 4459 | auth-passwd)))) | 4459 | auth-passwd)))) |
| 4460 | ;; Try the password cache. | 4460 | ;; Try the password cache. |
| 4461 | (let ((password (password-read pw-prompt key))) | 4461 | (let ((password (password-read pw-prompt key))) |
| 4462 | ;; FIXME test password works before caching it. | ||
| 4462 | (password-cache-add key password) | 4463 | (password-cache-add key password) |
| 4463 | password) | 4464 | password) |
| 4464 | ;; Else, get the password interactively. | 4465 | ;; Else, get the password interactively. |