diff options
| author | Glenn Morris | 2010-08-17 19:44:25 -0700 |
|---|---|---|
| committer | Glenn Morris | 2010-08-17 19:44:25 -0700 |
| commit | eeb4145e4c212f0323a0b39c34ae6695cae6ff1b (patch) | |
| tree | 4033ef267864ab1ab25ab9ce315d8976b321707c | |
| parent | cd24d7a9eb69b593552cca5663d079e3565f284b (diff) | |
| download | emacs-eeb4145e4c212f0323a0b39c34ae6695cae6ff1b.tar.gz emacs-eeb4145e4c212f0323a0b39c34ae6695cae6ff1b.zip | |
Fix some more Org `check-declare' issues.
* ob.el: Require org when compiling.
(org-save-outline-visibility): Remove macro declaration.
* ob-emacs-lisp.el: Require ob-comint when compiling, for macros.
Remove unnecessary/macro declarations.
* org-docview.el: Require doc-view when compiling.
(doc-view-goto-page): Autoload rather than declaring.
(doc-view-current-page): Remove macro declaration.
| -rw-r--r-- | lisp/org/ChangeLog | 10 | ||||
| -rw-r--r-- | lisp/org/ob-emacs-lisp.el | 5 | ||||
| -rw-r--r-- | lisp/org/ob.el | 7 | ||||
| -rw-r--r-- | lisp/org/org-docview.el | 4 |
4 files changed, 17 insertions, 9 deletions
diff --git a/lisp/org/ChangeLog b/lisp/org/ChangeLog index 9ebd951608e..5b650492442 100644 --- a/lisp/org/ChangeLog +++ b/lisp/org/ChangeLog | |||
| @@ -1,3 +1,13 @@ | |||
| 1 | 2010-08-18 Glenn Morris <rgm@gnu.org> | ||
| 2 | |||
| 3 | * ob.el: Require org when compiling. | ||
| 4 | (org-save-outline-visibility): Remove macro declaration. | ||
| 5 | * ob-emacs-lisp.el: Require ob-comint when compiling, for macros. | ||
| 6 | Remove unnecessary/macro declarations. | ||
| 7 | * org-docview.el: Require doc-view when compiling. | ||
| 8 | (doc-view-goto-page): Autoload rather than declaring. | ||
| 9 | (doc-view-current-page): Remove macro declaration. | ||
| 10 | |||
| 1 | 2010-08-17 Glenn Morris <rgm@gnu.org> | 11 | 2010-08-17 Glenn Morris <rgm@gnu.org> |
| 2 | 12 | ||
| 3 | * ob.el (tramp-compat-make-temp-file, org-edit-src-code) | 13 | * ob.el (tramp-compat-make-temp-file, org-edit-src-code) |
diff --git a/lisp/org/ob-emacs-lisp.el b/lisp/org/ob-emacs-lisp.el index 92c3f36e2ed..2ec729f7dcd 100644 --- a/lisp/org/ob-emacs-lisp.el +++ b/lisp/org/ob-emacs-lisp.el | |||
| @@ -28,15 +28,12 @@ | |||
| 28 | 28 | ||
| 29 | ;;; Code: | 29 | ;;; Code: |
| 30 | (require 'ob) | 30 | (require 'ob) |
| 31 | (eval-when-compile (require 'ob-comint)) | ||
| 31 | 32 | ||
| 32 | (defvar org-babel-default-header-args:emacs-lisp | 33 | (defvar org-babel-default-header-args:emacs-lisp |
| 33 | '((:hlines . "yes") (:colnames . "no")) | 34 | '((:hlines . "yes") (:colnames . "no")) |
| 34 | "Default arguments for evaluating an emacs-lisp source block.") | 35 | "Default arguments for evaluating an emacs-lisp source block.") |
| 35 | 36 | ||
| 36 | (declare-function org-babel-comint-with-output "ob-comint" (&rest body)) | ||
| 37 | (declare-function org-babel-comint-buffer-livep "ob-comint" (buffer)) | ||
| 38 | (declare-function org-babel-comint-wait-for-output "ob-comint" (buffer)) | ||
| 39 | (declare-function org-babel-comint-in-buffer "ob-comint" (buffer &rest body)) | ||
| 40 | (declare-function orgtbl-to-generic "org-table" (table params)) | 37 | (declare-function orgtbl-to-generic "org-table" (table params)) |
| 41 | 38 | ||
| 42 | (defun org-babel-expand-body:emacs-lisp (body params &optional processed-params) | 39 | (defun org-babel-expand-body:emacs-lisp (body params &optional processed-params) |
diff --git a/lisp/org/ob.el b/lisp/org/ob.el index 4aee07f26ab..4ae3e4f662c 100644 --- a/lisp/org/ob.el +++ b/lisp/org/ob.el | |||
| @@ -29,7 +29,9 @@ | |||
| 29 | ;; http://orgmode.org/worg/org-contrib/babel/ | 29 | ;; http://orgmode.org/worg/org-contrib/babel/ |
| 30 | 30 | ||
| 31 | ;;; Code: | 31 | ;;; Code: |
| 32 | (eval-when-compile (require 'cl)) | 32 | (eval-when-compile |
| 33 | (require 'cl) | ||
| 34 | (require 'org)) ; org-save-outline-visibility macro | ||
| 33 | (require 'org-macs) | 35 | (require 'org-macs) |
| 34 | 36 | ||
| 35 | (defvar org-babel-call-process-region-original) | 37 | (defvar org-babel-call-process-region-original) |
| @@ -40,10 +42,9 @@ | |||
| 40 | (declare-function tramp-file-name-user "tramp" (vec)) | 42 | (declare-function tramp-file-name-user "tramp" (vec)) |
| 41 | (declare-function tramp-file-name-host "tramp" (vec)) | 43 | (declare-function tramp-file-name-host "tramp" (vec)) |
| 42 | (declare-function org-icompleting-read "org" (&rest args)) | 44 | (declare-function org-icompleting-read "org" (&rest args)) |
| 43 | (declare-function org-edit-src-code "org-src" | 45 | (declare-function org-edit-src-code "org-src" |
| 44 | (&optional context code edit-buffer-name)) | 46 | (&optional context code edit-buffer-name)) |
| 45 | (declare-function org-open-at-point "org" (&optional in-emacs reference-buffer)) | 47 | (declare-function org-open-at-point "org" (&optional in-emacs reference-buffer)) |
| 46 | (declare-function org-save-outline-visibility "org" (use-markers &rest body)) | ||
| 47 | (declare-function org-narrow-to-subtree "org" ()) | 48 | (declare-function org-narrow-to-subtree "org" ()) |
| 48 | (declare-function org-entry-get "org" (pom property &optional inherit literal-nil)) | 49 | (declare-function org-entry-get "org" (pom property &optional inherit literal-nil)) |
| 49 | (declare-function org-make-options-regexp "org" (kwds &optional extra)) | 50 | (declare-function org-make-options-regexp "org" (kwds &optional extra)) |
diff --git a/lisp/org/org-docview.el b/lisp/org/org-docview.el index cac13e6ddfc..0ef5df0fda6 100644 --- a/lisp/org/org-docview.el +++ b/lisp/org/org-docview.el | |||
| @@ -45,9 +45,9 @@ | |||
| 45 | 45 | ||
| 46 | 46 | ||
| 47 | (require 'org) | 47 | (require 'org) |
| 48 | (eval-when-compile (require 'doc-view)) ; doc-view-current-page macro | ||
| 48 | 49 | ||
| 49 | (declare-function doc-view-goto-page "doc-view" (page)) | 50 | (autoload 'doc-view-goto-page "doc-view") |
| 50 | (declare-function doc-view-current-page "doc-view" (&optional win)) | ||
| 51 | 51 | ||
| 52 | (org-add-link-type "docview" 'org-docview-open) | 52 | (org-add-link-type "docview" 'org-docview-open) |
| 53 | (add-hook 'org-store-link-functions 'org-docview-store-link) | 53 | (add-hook 'org-store-link-functions 'org-docview-store-link) |