diff options
| author | Chong Yidong | 2011-08-20 22:07:00 -0400 |
|---|---|---|
| committer | Chong Yidong | 2011-08-20 22:07:00 -0400 |
| commit | ee31aabc4ee4086d5c78dbc93dfbab07b9ecc2a7 (patch) | |
| tree | ca8806f59a6b62a9485c4373488721c75343378d | |
| parent | a3f2468a08e81b44491322c275f94c8c7d87c6db (diff) | |
| download | emacs-ee31aabc4ee4086d5c78dbc93dfbab07b9ecc2a7.tar.gz emacs-ee31aabc4ee4086d5c78dbc93dfbab07b9ecc2a7.zip | |
Fix error in compilation-error-properties.
* lisp/progmodes/compile.el (compilation-error-properties): Fix
confusion between file struct and message struct (Bug#9319).
| -rw-r--r-- | lisp/ChangeLog | 3 | ||||
| -rw-r--r-- | lisp/progmodes/compile.el | 13 |
2 files changed, 11 insertions, 5 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 06dd2bf1198..53fbdf00087 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,5 +1,8 @@ | |||
| 1 | 2011-08-21 Chong Yidong <cyd@stupidchicken.com> | 1 | 2011-08-21 Chong Yidong <cyd@stupidchicken.com> |
| 2 | 2 | ||
| 3 | * progmodes/compile.el (compilation-error-properties): Fix | ||
| 4 | confusion between file struct and message struct (Bug#9319). | ||
| 5 | |||
| 3 | * net/browse-url.el (browse-url-firefox): Don't call | 6 | * net/browse-url.el (browse-url-firefox): Don't call |
| 4 | browse-url-firefox-sentinel unless using -remote (Bug#9328). | 7 | browse-url-firefox-sentinel unless using -remote (Bug#9328). |
| 5 | 8 | ||
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index f3b873c8b1e..33bd9ff96a7 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el | |||
| @@ -985,12 +985,15 @@ POS and RES.") | |||
| 985 | (let* ((prev | 985 | (let* ((prev |
| 986 | (or (get-text-property (1- prev-pos) 'compilation-message) | 986 | (or (get-text-property (1- prev-pos) 'compilation-message) |
| 987 | (get-text-property prev-pos 'compilation-message))) | 987 | (get-text-property prev-pos 'compilation-message))) |
| 988 | (prev-struct | 988 | (prev-file-struct |
| 989 | (car (nth 2 (car prev))))) | 989 | (and prev |
| 990 | (compilation--loc->file-struct | ||
| 991 | (compilation--message->loc prev))))) | ||
| 992 | |||
| 990 | ;; Construct FILE . DIR from that. | 993 | ;; Construct FILE . DIR from that. |
| 991 | (if prev-struct | 994 | (if prev-file-struct |
| 992 | (setq file (cons (car prev-struct) | 995 | (setq file (cons (caar prev-file-struct) |
| 993 | (cadr prev-struct)))))) | 996 | (cadr (car prev-file-struct))))))) |
| 994 | (unless file | 997 | (unless file |
| 995 | (setq file '("*unknown*"))))) | 998 | (setq file '("*unknown*"))))) |
| 996 | ;; All of these fields are optional, get them only if we have an index, and | 999 | ;; All of these fields are optional, get them only if we have an index, and |