diff options
| author | Juanma Barranquero | 2007-09-26 00:13:53 +0000 |
|---|---|---|
| committer | Juanma Barranquero | 2007-09-26 00:13:53 +0000 |
| commit | eb2b0009c18de44bcdfd291ba2becbb5945e4eb5 (patch) | |
| tree | 1020bdbe56979b7f2f7182e67abd1df9d2a4435d | |
| parent | 877c8877a22e0300ac00a8013acf9494cdfc6d67 (diff) | |
| download | emacs-eb2b0009c18de44bcdfd291ba2becbb5945e4eb5.tar.gz emacs-eb2b0009c18de44bcdfd291ba2becbb5945e4eb5.zip | |
(elint-current-buffer, elint-check-defun-form, elint-check-let-form,
elint-check-condition-case-form, elint-initialize):
Use `mapc' rather than `mapcar'.
| -rw-r--r-- | lisp/emacs-lisp/elint.el | 76 |
1 files changed, 38 insertions, 38 deletions
diff --git a/lisp/emacs-lisp/elint.el b/lisp/emacs-lisp/elint.el index f9bff300293..0501fbf171e 100644 --- a/lisp/emacs-lisp/elint.el +++ b/lisp/emacs-lisp/elint.el | |||
| @@ -218,7 +218,7 @@ This environment can be passed to `macroexpand'." | |||
| 218 | (buffer-file-name) | 218 | (buffer-file-name) |
| 219 | (buffer-name)))) | 219 | (buffer-name)))) |
| 220 | (elint-display-log) | 220 | (elint-display-log) |
| 221 | (mapcar 'elint-top-form (elint-update-env)) | 221 | (mapc 'elint-top-form (elint-update-env)) |
| 222 | 222 | ||
| 223 | ;; Tell the user we're finished. This is terribly klugy: we set | 223 | ;; Tell the user we're finished. This is terribly klugy: we set |
| 224 | ;; elint-top-form-logged so elint-log-message doesn't print the | 224 | ;; elint-top-form-logged so elint-log-message doesn't print the |
| @@ -542,11 +542,11 @@ CODE can be a lambda expression, a macro, or byte-compiled code." | |||
| 542 | (defun elint-check-defun-form (form env) | 542 | (defun elint-check-defun-form (form env) |
| 543 | "Lint a defun/defmacro/lambda FORM in ENV." | 543 | "Lint a defun/defmacro/lambda FORM in ENV." |
| 544 | (setq form (if (eq (car form) 'lambda) (cdr form) (cdr (cdr form)))) | 544 | (setq form (if (eq (car form) 'lambda) (cdr form) (cdr (cdr form)))) |
| 545 | (mapcar (function (lambda (p) | 545 | (mapc (function (lambda (p) |
| 546 | (or (memq p '(&optional &rest)) | 546 | (or (memq p '(&optional &rest)) |
| 547 | (setq env (elint-env-add-var env p))) | 547 | (setq env (elint-env-add-var env p))) |
| 548 | )) | 548 | )) |
| 549 | (car form)) | 549 | (car form)) |
| 550 | (elint-forms (cdr form) env)) | 550 | (elint-forms (cdr form) env)) |
| 551 | 551 | ||
| 552 | (defun elint-check-let-form (form env) | 552 | (defun elint-check-let-form (form env) |
| @@ -566,21 +566,21 @@ CODE can be a lambda expression, a macro, or byte-compiled code." | |||
| 566 | 566 | ||
| 567 | ;; Add variables to environment, and check the init values | 567 | ;; Add variables to environment, and check the init values |
| 568 | (let ((newenv env)) | 568 | (let ((newenv env)) |
| 569 | (mapcar (function (lambda (s) | 569 | (mapc (function (lambda (s) |
| 570 | (cond | 570 | (cond |
| 571 | ((symbolp s) | 571 | ((symbolp s) |
| 572 | (setq newenv (elint-env-add-var newenv s))) | 572 | (setq newenv (elint-env-add-var newenv s))) |
| 573 | ((and (consp s) (<= (length s) 2)) | 573 | ((and (consp s) (<= (length s) 2)) |
| 574 | (elint-form (car (cdr s)) | 574 | (elint-form (car (cdr s)) |
| 575 | (if (eq (car form) 'let) | 575 | (if (eq (car form) 'let) |
| 576 | env | 576 | env |
| 577 | newenv)) | 577 | newenv)) |
| 578 | (setq newenv | 578 | (setq newenv |
| 579 | (elint-env-add-var newenv (car s)))) | 579 | (elint-env-add-var newenv (car s)))) |
| 580 | (t (elint-error | 580 | (t (elint-error |
| 581 | "Malformed `let' declaration: %s" s)) | 581 | "Malformed `let' declaration: %s" s)) |
| 582 | ))) | 582 | ))) |
| 583 | varlist) | 583 | varlist) |
| 584 | 584 | ||
| 585 | ;; Lint the body forms | 585 | ;; Lint the body forms |
| 586 | (elint-forms (cdr (cdr form)) newenv) | 586 | (elint-forms (cdr (cdr form)) newenv) |
| @@ -665,18 +665,18 @@ CODE can be a lambda expression, a macro, or byte-compiled code." | |||
| 665 | errlist) | 665 | errlist) |
| 666 | (while errforms | 666 | (while errforms |
| 667 | (setq errlist (car (car errforms))) | 667 | (setq errlist (car (car errforms))) |
| 668 | (mapcar (function (lambda (s) | 668 | (mapc (function (lambda (s) |
| 669 | (or (get s 'error-conditions) | 669 | (or (get s 'error-conditions) |
| 670 | (get s 'error-message) | 670 | (get s 'error-message) |
| 671 | (elint-warning | 671 | (elint-warning |
| 672 | "Not an error symbol in error handler: %s" s)))) | 672 | "Not an error symbol in error handler: %s" s)))) |
| 673 | (cond | 673 | (cond |
| 674 | ((symbolp errlist) (list errlist)) | 674 | ((symbolp errlist) (list errlist)) |
| 675 | ((listp errlist) errlist) | 675 | ((listp errlist) errlist) |
| 676 | (t (elint-error "Bad error list in error handler: %s" | 676 | (t (elint-error "Bad error list in error handler: %s" |
| 677 | errlist) | 677 | errlist) |
| 678 | nil)) | 678 | nil)) |
| 679 | ) | 679 | ) |
| 680 | (elint-forms (cdr (car errforms)) newenv) | 680 | (elint-forms (cdr (car errforms)) newenv) |
| 681 | (setq errforms (cdr errforms)) | 681 | (setq errforms (cdr errforms)) |
| 682 | ))) | 682 | ))) |
| @@ -767,11 +767,11 @@ Insert HEADER followed by a blank line if non-nil." | |||
| 767 | (defun elint-initialize () | 767 | (defun elint-initialize () |
| 768 | "Initialize elint." | 768 | "Initialize elint." |
| 769 | (interactive) | 769 | (interactive) |
| 770 | (mapcar (function (lambda (x) | 770 | (mapc (function (lambda (x) |
| 771 | (or (not (symbolp (car x))) | 771 | (or (not (symbolp (car x))) |
| 772 | (eq (cdr x) 'unknown) | 772 | (eq (cdr x) 'unknown) |
| 773 | (put (car x) 'elint-args (cdr x))))) | 773 | (put (car x) 'elint-args (cdr x))))) |
| 774 | (elint-find-builtin-args)) | 774 | (elint-find-builtin-args)) |
| 775 | (mapcar (function (lambda (x) | 775 | (mapcar (function (lambda (x) |
| 776 | (put (car x) 'elint-args (cdr x)))) | 776 | (put (car x) 'elint-args (cdr x)))) |
| 777 | elint-unknown-builtin-args)) | 777 | elint-unknown-builtin-args)) |