bug when passing xwidget in event

3 files changed, 18 insertions, 6 deletions

diff --git a/.gitignore b/.gitignore
index 21702f7cd07..50470179e38 100644
--- a/.gitignore
+++ b/.gitignore
@@ -15,3 +15,7 @@ makefile
 
 /bin/
 /site-lisp/
+*.o
+*.elc
+.bzr
+*#
\ No newline at end of file
diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index 50e74add6a0..4329382081c 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -160,6 +160,7 @@ defaults to the string looking like a url around the cursor position."
                                         ;(xwidget-callback (xwidget-get xwidget 'callback));;TODO stopped working for some reason
        )
                                         ;(funcall  xwidget-callback xwidget xwidget-event-type)
+    (message "xw callback %s" xwidget)
     (funcall  'xwidget-webkit-callback xwidget xwidget-event-type)
     ))
 
@@ -299,9 +300,9 @@ Argument STR string."
   "make id-element show. for instance an anchor."
   (interactive (list (xwidget-webkit-current-session) (read-string "element id:")))
   (let* ((y1 
-         (string-to-number (xwidget-webkit-execute-script-rv xw (format "document.getElementsByName('%s')[0].getBoundingClientRect().top" element-id) 0)))
+         (string-to-number (xwidget-webkit-execute-script-rv xw (format "document.getElementsByName('%s')[0].getBoundingClientRect().top" element-id) "0")))
         (y2 
-         (string-to-number (xwidget-webkit-execute-script-rv xw (format "document.getElementById('%s').getBoundingClientRect().top" element-id) 0)))
+         (string-to-number (xwidget-webkit-execute-script-rv xw (format "document.getElementById('%s').getBoundingClientRect().top" element-id) "0")))
         (y3 (max y1 y2)))
     ;;now we need to tell emacs to scroll the element into view. 
     (xwidget-log "scroll: %d" y3)
@@ -378,6 +379,7 @@ Argument H height."
     (xwidget-webkit-execute-script xw (format "document.title=%s;" script))
     (setq title (xwidget-webkit-get-title xw))
     (if (equal emptytag title) (setq title ""))
+    (unless title (setq title default))
     title))
 
 
diff --git a/src/xwidget.c b/src/xwidget.c
index 93d7c46a41f..b43cc14a791 100644
--- a/src/xwidget.c
+++ b/src/xwidget.c
@@ -98,6 +98,7 @@
 #include <webkit/webkitwebplugin.h>
 #include <webkit/webkitglobals.h>
 #include <webkit/webkitwebnavigationaction.h>
+#include <webkit/webkitdownload.h>
 #endif
 
 #include "xwidget.h"
@@ -123,7 +124,8 @@ allocate_xwidget_view (void)
 {
   return ALLOCATE_PSEUDOVECTOR (struct xwidget_view, redisplayed, PVEC_XWIDGET_VIEW);
 }
-
+#define XSETXWIDGET(a, b) (XSETPSEUDOVECTOR (a, b, PVEC_XWIDGET))
+#define XSETXWIDGET_VIEW(a, b) (XSETPSEUDOVECTOR (a, b, PVEC_XWIDGET_VIEW))
 
 Lisp_Object Qxwidget;
 Lisp_Object Qcxwidget;
@@ -457,13 +459,15 @@ gboolean webkit_osr_key_event_callback (GtkWidget *widget, GdkEventKey *event, g
 void store_xwidget_event_string(struct xwidget* xw, char* eventname,char* eventstr){
   //refactor attempt
   struct input_event event;
+  Lisp_Object xwl;
+  XSETXWIDGET(xwl,xw);
   EVENT_INIT (event);
   event.kind = XWIDGET_EVENT;
   event.frame_or_window = Qnil; //frame; //how to get the frame here? //TODO i store it in the xwidget now
 
   event.arg = Qnil;
   event.arg = Fcons (build_string(eventstr), event.arg);  //string so dont intern
-  event.arg = Fcons ((Lisp_Object)xw, event.arg); //TODO
+  event.arg = Fcons (xwl, event.arg); //TODO
   event.arg = Fcons (intern (eventname), event.arg);//interning should be ok
   kbd_buffer_store_event (&event);
 
@@ -487,11 +491,13 @@ gboolean     webkit_osr_download_callback (WebKitWebView  *webkitwebview,
                                        WebKitDownload *arg1,
                                        gpointer        data)
 {
-  printf("download requested %s\n", webkit_download_get_uri (arg1));
   //TODO this event sending code should be refactored
   struct input_event event;
   //  struct xwidget *xw = (struct xwidget *) data;
   struct xwidget* xw = (struct xwidget*) g_object_get_data (G_OBJECT (webkitwebview), XG_XWIDGET);  
+  printf("download requested %s\n", webkit_download_get_uri (arg1));
+
+
   printf("webkit finished loading\n");
 
   store_xwidget_event_string(xw, "download-requested", webkit_download_get_uri (arg1));
@@ -829,7 +835,7 @@ x_draw_xwidget_glyph_string (struct glyph_string *s)
 
 //FUGLY macro that checks WEBKIT_IS_WEB_VIEW(xw->widget_osr) first 
 #define WEBKIT_FN_INIT()                        \
-  struct xwidget* xw;\  
+  struct xwidget* xw; \
 if(!XXWIDGETP(xwidget)) {printf("ERROR not an xwidget\n"); return Qnil;}; \
 if(Qnil == xwidget) {printf("ERROR xwidget nil\n");   return Qnil;};    \
   xw = XXWIDGET(xwidget);                                                    \