aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Monnier2006-01-10 19:31:15 +0000
committerStefan Monnier2006-01-10 19:31:15 +0000
commite7ea7cac4eb8934dfcb53457ac7af0f70ec7d136 (patch)
tree200a593aa5430697ecf761b5281fd06c29934c6d
parent9f812d2370db5cd09985a281105baa95be628e52 (diff)
downloademacs-e7ea7cac4eb8934dfcb53457ac7af0f70ec7d136.tar.gz
emacs-e7ea7cac4eb8934dfcb53457ac7af0f70ec7d136.zip
(url-retrieve-synchronously): Adjust the workaround so as not
to stop in the middle of a redirection.
-rw-r--r--lisp/url/ChangeLog3
-rw-r--r--lisp/url/url.el7
2 files changed, 8 insertions, 2 deletions
diff --git a/lisp/url/ChangeLog b/lisp/url/ChangeLog
index 08d5eb4c6bf..56d1faaa84d 100644
--- a/lisp/url/ChangeLog
+++ b/lisp/url/ChangeLog
@@ -1,5 +1,8 @@
12006-01-10 Stefan Monnier <monnier@iro.umontreal.ca> 12006-01-10 Stefan Monnier <monnier@iro.umontreal.ca>
2 2
3 * url.el (url-retrieve-synchronously): Adjust the workaround so as not
4 to stop in the middle of a redirection.
5
3 * url-vars.el (url-privacy-level): Add setter. 6 * url-vars.el (url-privacy-level): Add setter.
4 7
52006-01-05 Stefan Monnier <monnier@iro.umontreal.ca> 82006-01-05 Stefan Monnier <monnier@iro.umontreal.ca>
diff --git a/lisp/url/url.el b/lisp/url/url.el
index f9d06010171..10c449cb30b 100644
--- a/lisp/url/url.el
+++ b/lisp/url/url.el
@@ -190,11 +190,14 @@ no further processing). URL is either a string or a parsed URL."
190 "Spinning in url-retrieve-synchronously: %S (%S)" 190 "Spinning in url-retrieve-synchronously: %S (%S)"
191 retrieval-done asynch-buffer) 191 retrieval-done asynch-buffer)
192 (if (and proc (memq (process-status proc) 192 (if (and proc (memq (process-status proc)
193 '(closed exit signal failed))) 193 '(closed exit signal failed))
194 ;; Make sure another process hasn't been started, as can
195 ;; happen with http redirections.
196 (eq proc (or (get-buffer-process asynch-buffer) proc)))
194 ;; FIXME: It's not clear whether url-retrieve's callback is 197 ;; FIXME: It's not clear whether url-retrieve's callback is
195 ;; guaranteed to be called or not. It seems that url-http 198 ;; guaranteed to be called or not. It seems that url-http
196 ;; decides sometimes consciously not to call it, so it's not 199 ;; decides sometimes consciously not to call it, so it's not
197 ;; clear that it's a bug, but even if we need to decide how 200 ;; clear that it's a bug, but even then we need to decide how
198 ;; url-http can then warn us that the download has completed. 201 ;; url-http can then warn us that the download has completed.
199 ;; In the mean time, we use this here workaround. 202 ;; In the mean time, we use this here workaround.
200 (setq retrieval-done t) 203 (setq retrieval-done t)