diff options
| author | Glenn Morris | 2008-02-25 08:14:21 +0000 |
|---|---|---|
| committer | Glenn Morris | 2008-02-25 08:14:21 +0000 |
| commit | e46e905ae3b3d7a5d2708e6090dca70fe7a604f0 (patch) | |
| tree | 61c100e95c7862f1ed38173223f8efa9cfff4ac6 | |
| parent | f52d2f9c301760f4554e2e800bf9908430b87bba (diff) | |
| download | emacs-e46e905ae3b3d7a5d2708e6090dca70fe7a604f0.tar.gz emacs-e46e905ae3b3d7a5d2708e6090dca70fe7a604f0.zip | |
(vc-sccs-diff): Fix setting of oldvers and newvers.
| -rw-r--r-- | admin/FOR-RELEASE | 3 | ||||
| -rw-r--r-- | lisp/ChangeLog | 4 | ||||
| -rw-r--r-- | lisp/vc-sccs.el | 7 |
3 files changed, 6 insertions, 8 deletions
diff --git a/admin/FOR-RELEASE b/admin/FOR-RELEASE index f7d986028d6..ecad8f7432d 100644 --- a/admin/FOR-RELEASE +++ b/admin/FOR-RELEASE | |||
| @@ -55,9 +55,6 @@ http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-09/msg00055.html | |||
| 55 | 55 | ||
| 56 | * BUGS | 56 | * BUGS |
| 57 | 57 | ||
| 58 | ** vc-sccs-diff is broken (see FIXME). | ||
| 59 | http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-02/msg00121.html | ||
| 60 | |||
| 61 | ** Does deleting frames run Lisp code? If so, can we get rid of that? | 58 | ** Does deleting frames run Lisp code? If so, can we get rid of that? |
| 62 | It is a dangerous design. | 59 | It is a dangerous design. |
| 63 | http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg01330.html | 60 | http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg01330.html |
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 244995563a3..31dc2347f97 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,7 @@ | |||
| 1 | 2008-02-25 Glenn Morris <rgm@gnu.org> | ||
| 2 | |||
| 3 | * vc-sccs.el (vc-sccs-diff): Fix setting of oldvers and newvers. | ||
| 4 | |||
| 1 | 2008-02-25 Stefan Monnier <monnier@iro.umontreal.ca> | 5 | 2008-02-25 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2 | 6 | ||
| 3 | * diff-mode.el (diff-file-junk-re): New const. | 7 | * diff-mode.el (diff-file-junk-re): New const. |
diff --git a/lisp/vc-sccs.el b/lisp/vc-sccs.el index a22a95521d5..0c1cc41ed64 100644 --- a/lisp/vc-sccs.el +++ b/lisp/vc-sccs.el | |||
| @@ -7,8 +7,6 @@ | |||
| 7 | ;; Author: FSF (see vc.el for full credits) | 7 | ;; Author: FSF (see vc.el for full credits) |
| 8 | ;; Maintainer: Andre Spiegel <spiegel@gnu.org> | 8 | ;; Maintainer: Andre Spiegel <spiegel@gnu.org> |
| 9 | 9 | ||
| 10 | ;; $Id$ | ||
| 11 | |||
| 12 | ;; This file is part of GNU Emacs. | 10 | ;; This file is part of GNU Emacs. |
| 13 | 11 | ||
| 14 | ;; GNU Emacs is free software; you can redistribute it and/or modify | 12 | ;; GNU Emacs is free software; you can redistribute it and/or modify |
| @@ -314,9 +312,8 @@ locked. REV is the revision to check out." | |||
| 314 | 312 | ||
| 315 | (defun vc-sccs-diff (files &optional oldvers newvers buffer) | 313 | (defun vc-sccs-diff (files &optional oldvers newvers buffer) |
| 316 | "Get a difference report using SCCS between two filesets." | 314 | "Get a difference report using SCCS between two filesets." |
| 317 | ;; FIXME this is broken (`file' versus `files'). | 315 | (setq oldvers (vc-sccs-lookup-triple (car files) oldvers)) |
| 318 | (setq oldvers (vc-sccs-lookup-triple file oldvers)) | 316 | (setq newvers (vc-sccs-lookup-triple (car files) newvers)) |
| 319 | (setq newvers (vc-sccs-lookup-triple file newvers)) | ||
| 320 | (apply 'vc-do-command (or buffer "*vc-diff*") | 317 | (apply 'vc-do-command (or buffer "*vc-diff*") |
| 321 | 1 "vcdiff" (mapcar 'vc-name (vc-expand-dirs files)) | 318 | 1 "vcdiff" (mapcar 'vc-name (vc-expand-dirs files)) |
| 322 | (append (list "-q" | 319 | (append (list "-q" |