diff options
| author | João Távora | 2019-12-23 12:08:43 +0100 |
|---|---|---|
| committer | João Távora | 2019-12-23 12:08:43 +0100 |
| commit | e1e2ad104da740be1bc1f8189c3d4c2b472e047e (patch) | |
| tree | a9d50ca1cc1ff5b180ccc7b3b52612db00d492bb | |
| parent | c7e6b62d9e2f56bad176d391238e5d0ec7c28ade (diff) | |
| download | emacs-e1e2ad104da740be1bc1f8189c3d4c2b472e047e.tar.gz emacs-e1e2ad104da740be1bc1f8189c3d4c2b472e047e.zip | |
Comment on limitation of flex completion style's sorting function
* lisp/minibuffer.el (completion--flex-adjust-metadata): Add
comment.
| -rw-r--r-- | lisp/minibuffer.el | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 6011a493d0b..0e9b1c199a3 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el | |||
| @@ -3593,8 +3593,13 @@ that is non-nil." | |||
| 3593 | completions))) | 3593 | completions))) |
| 3594 | (cond | 3594 | (cond |
| 3595 | ((or (not (window-minibuffer-p)) | 3595 | ((or (not (window-minibuffer-p)) |
| 3596 | (> (point-max) | 3596 | ;; JT@2019-12-23: FIXME: this is still wrong. What |
| 3597 | (minibuffer-prompt-end))) | 3597 | ;; we need to test here is "some input that actually |
| 3598 | ;; leads to flex filtering", not "something after | ||
| 3599 | ;; the minibuffer prompt". The latter is always | ||
| 3600 | ;; true for file searches, meaning the next clauses | ||
| 3601 | ;; will be ignored. | ||
| 3602 | (> (point-max) (minibuffer-prompt-end))) | ||
| 3598 | (sort | 3603 | (sort |
| 3599 | pre-sorted | 3604 | pre-sorted |
| 3600 | (lambda (c1 c2) | 3605 | (lambda (c1 c2) |