aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Gutov2013-11-04 12:50:47 +0200
committerDmitry Gutov2013-11-04 12:50:47 +0200
commitdca01b092347246195d35c4bbce321f62323d8d8 (patch)
tree7dd2cf291a2bb58fe23a9c5d322d262b4d9694c6
parent91f2d272895257f23596075a0cc42e6e5f4e490f (diff)
downloademacs-dca01b092347246195d35c4bbce321f62323d8d8.tar.gz
emacs-dca01b092347246195d35c4bbce321f62323d8d8.zip
* lisp/progmodes/ruby-mode.el (ruby-smie--forward-token)
(ruby-smie--backward-token): Tokenize heredocs as semicolons. * test/automated/ruby-mode-tests.el: Remove outdated comment. * test/indent/ruby.rb: Add a statement on the line after heredoc.
-rw-r--r--lisp/ChangeLog5
-rw-r--r--lisp/progmodes/ruby-mode.el12
-rw-r--r--test/ChangeLog6
-rw-r--r--test/automated/ruby-mode-tests.el2
-rw-r--r--test/indent/ruby.rb1
5 files changed, 22 insertions, 4 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 9ff4ab8f04c..4c2c4cd5e07 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
12013-11-04 Dmitry Gutov <dgutov@yandex.ru>
2
3 * progmodes/ruby-mode.el (ruby-smie--forward-token)
4 (ruby-smie--backward-token): Tokenize heredocs as semicolons.
5
12013-11-04 Michal Nazarewicz <mina86@mina86.com> 62013-11-04 Michal Nazarewicz <mina86@mina86.com>
2 7
3 * textmodes/fill.el (fill-single-char-nobreak-p): New function 8 * textmodes/fill.el (fill-single-char-nobreak-p): New function
diff --git a/lisp/progmodes/ruby-mode.el b/lisp/progmodes/ruby-mode.el
index 75c59ebe1fd..1c9663cc22c 100644
--- a/lisp/progmodes/ruby-mode.el
+++ b/lisp/progmodes/ruby-mode.el
@@ -393,7 +393,12 @@ explicitly declared in magic comment."
393 (let ((pos (point))) 393 (let ((pos (point)))
394 (skip-chars-forward " \t") 394 (skip-chars-forward " \t")
395 (cond 395 (cond
396 ((looking-at "\\s\"") "") ;A heredoc or a string. 396 ((looking-at "\\s\"") ;A heredoc or a string.
397 (if (not (looking-at "\n"))
398 ""
399 ;; Tokenize the whole heredoc as semicolon.
400 (goto-char (scan-sexps (point) 1))
401 ";"))
397 ((and (looking-at "[\n#]") 402 ((and (looking-at "[\n#]")
398 (ruby-smie--implicit-semi-p)) ;Only add implicit ; when needed. 403 (ruby-smie--implicit-semi-p)) ;Only add implicit ; when needed.
399 (if (eolp) (forward-char 1) (forward-comment 1)) 404 (if (eolp) (forward-char 1) (forward-comment 1))
@@ -435,7 +440,10 @@ explicitly declared in magic comment."
435 (cond 440 (cond
436 ((and (> pos (line-end-position)) (ruby-smie--implicit-semi-p)) 441 ((and (> pos (line-end-position)) (ruby-smie--implicit-semi-p))
437 (skip-chars-forward " \t") ";") 442 (skip-chars-forward " \t") ";")
438 ((and (bolp) (not (bobp))) "") ;Presumably a heredoc. 443 ((and (bolp) (not (bobp))) ;Presumably a heredoc.
444 ;; Tokenize the whole heredoc as semicolon.
445 (goto-char (scan-sexps (point) -1))
446 ";")
439 ((and (> pos (point)) (not (bolp)) 447 ((and (> pos (point)) (not (bolp))
440 (ruby-smie--args-separator-p pos)) 448 (ruby-smie--args-separator-p pos))
441 ;; We have "ID SPC ID", which is a method call, but it binds less tightly 449 ;; We have "ID SPC ID", which is a method call, but it binds less tightly
diff --git a/test/ChangeLog b/test/ChangeLog
index 1439ee12bb4..3f9f4e8810a 100644
--- a/test/ChangeLog
+++ b/test/ChangeLog
@@ -1,3 +1,9 @@
12013-11-04 Dmitry Gutov <dgutov@yandex.ru>
2
3 * indent/ruby.rb: Add a statement on the line after heredoc.
4
5 * automated/ruby-mode-tests.el: Remove outdated comment.
6
12013-11-04 Glenn Morris <rgm@gnu.org> 72013-11-04 Glenn Morris <rgm@gnu.org>
2 8
3 * automated/Makefile.in (abs_srcdir): Remove. 9 * automated/Makefile.in (abs_srcdir): Remove.
diff --git a/test/automated/ruby-mode-tests.el b/test/automated/ruby-mode-tests.el
index dc86b4a2914..d5d262590b6 100644
--- a/test/automated/ruby-mode-tests.el
+++ b/test/automated/ruby-mode-tests.el
@@ -585,8 +585,6 @@ VALUES-PLIST is a list with alternating index and value elements."
585 (end-of-defun) 585 (end-of-defun)
586 (should (= 5 (line-number-at-pos))))) 586 (should (= 5 (line-number-at-pos)))))
587 587
588;; Tests below fail when using SMIE.
589
590(defvar ruby-sexp-test-example 588(defvar ruby-sexp-test-example
591 (ruby-test-string 589 (ruby-test-string
592 "class C 590 "class C
diff --git a/test/indent/ruby.rb b/test/indent/ruby.rb
index 65c33bb3ecf..4bf65ffcf27 100644
--- a/test/indent/ruby.rb
+++ b/test/indent/ruby.rb
@@ -3,6 +3,7 @@ if something_wrong? # ruby-move-to-block-skips-heredoc
3 boo hoo 3 boo hoo
4 end 4 end
5 eowarn 5 eowarn
6 foo
6end 7end
7 8
8# Percent literals. 9# Percent literals.