diff options
| author | Stefan Monnier | 2005-06-08 19:35:54 +0000 |
|---|---|---|
| committer | Stefan Monnier | 2005-06-08 19:35:54 +0000 |
| commit | d48f0f00da73bff143ce17b6fff3e3800e092e72 (patch) | |
| tree | c50cd71f8788a4325b919ff2db283aacc7397fdf | |
| parent | 995987378d97aed8094f27262f37aefcf6b7f2cc (diff) | |
| download | emacs-d48f0f00da73bff143ce17b6fff3e3800e092e72.tar.gz emacs-d48f0f00da73bff143ce17b6fff3e3800e092e72.zip | |
(debug): Don't iconify if we know we'll re-enter the debugger immediately
anyway. Undo the 2005-06-06 change, rendered unnecessary now.
| -rw-r--r-- | lisp/emacs-lisp/debug.el | 22 |
1 files changed, 9 insertions, 13 deletions
diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 30e6f3480cc..f3eaad0ce25 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el | |||
| @@ -97,10 +97,7 @@ This is to optimize `debugger-make-xrefs'.") | |||
| 97 | This variable is used by `debugger-jump', `debugger-step-through', | 97 | This variable is used by `debugger-jump', `debugger-step-through', |
| 98 | and `debugger-reenable' to temporarily disable debug-on-entry.") | 98 | and `debugger-reenable' to temporarily disable debug-on-entry.") |
| 99 | 99 | ||
| 100 | (defvar debugger-window nil | 100 | (defvar inhibit-trace) ;Not yet implemented. |
| 101 | "If non-nil, the last window used by the debugger for its buffer. | ||
| 102 | The next call to the debugger reuses the same window, if it is still live. | ||
| 103 | That case would normally occur when the window is in a separate frame.") | ||
| 104 | 101 | ||
| 105 | ;;;###autoload | 102 | ;;;###autoload |
| 106 | (setq debugger 'debug) | 103 | (setq debugger 'debug) |
| @@ -183,13 +180,7 @@ first will be printed into the backtrace buffer." | |||
| 183 | ;; Place an extra debug-on-exit for macro's. | 180 | ;; Place an extra debug-on-exit for macro's. |
| 184 | (when (eq 'lambda (car-safe (cadr (backtrace-frame 4)))) | 181 | (when (eq 'lambda (car-safe (cadr (backtrace-frame 4)))) |
| 185 | (backtrace-debug 5 t))) | 182 | (backtrace-debug 5 t))) |
| 186 | (if (and debugger-window | 183 | (pop-to-buffer debugger-buffer) |
| 187 | (window-live-p debugger-window)) | ||
| 188 | (progn | ||
| 189 | (set-window-buffer debugger-window debugger-buffer) | ||
| 190 | (select-window debugger-window)) | ||
| 191 | (pop-to-buffer debugger-buffer)) | ||
| 192 | (setq debugger-window (selected-window)) | ||
| 193 | (debugger-mode) | 184 | (debugger-mode) |
| 194 | (debugger-setup-buffer debugger-args) | 185 | (debugger-setup-buffer debugger-args) |
| 195 | (when noninteractive | 186 | (when noninteractive |
| @@ -226,12 +217,17 @@ first will be printed into the backtrace buffer." | |||
| 226 | (erase-buffer) | 217 | (erase-buffer) |
| 227 | (fundamental-mode) | 218 | (fundamental-mode) |
| 228 | (with-selected-window (get-buffer-window debugger-buffer 0) | 219 | (with-selected-window (get-buffer-window debugger-buffer 0) |
| 229 | (when (window-dedicated-p (selected-window)) | 220 | (when (and (window-dedicated-p (selected-window)) |
| 221 | (not debugger-step-after-exit)) | ||
| 230 | ;; If the window is not dedicated, burying the buffer | 222 | ;; If the window is not dedicated, burying the buffer |
| 231 | ;; will mean that the frame created for it is left | 223 | ;; will mean that the frame created for it is left |
| 232 | ;; around showing smoe random buffer, and next time we | 224 | ;; around showing some random buffer, and next time we |
| 233 | ;; pop to the debugger buffer we'll create yet | 225 | ;; pop to the debugger buffer we'll create yet |
| 234 | ;; another frame. | 226 | ;; another frame. |
| 227 | ;; If debugger-step-after-exit is non-nil, the frame | ||
| 228 | ;; would need to be de-iconified anyway immediately | ||
| 229 | ;; after when we re-enter the debugger, so iconifying it | ||
| 230 | ;; here would cause flashing. | ||
| 235 | (bury-buffer)))) | 231 | (bury-buffer)))) |
| 236 | (kill-buffer debugger-buffer)) | 232 | (kill-buffer debugger-buffer)) |
| 237 | (set-match-data debugger-outer-match-data))) | 233 | (set-match-data debugger-outer-match-data))) |