aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGlenn Morris2014-11-03 23:07:04 -0800
committerGlenn Morris2014-11-03 23:07:04 -0800
commitd236329b5285004b6b25317614c6a42d7d4e516f (patch)
treef672e374cb1b1af30105f49d0cd8804ef6600161
parentbd673cc594764572cd49bd0f10a0432006368489 (diff)
downloademacs-d236329b5285004b6b25317614c6a42d7d4e516f.tar.gz
emacs-d236329b5285004b6b25317614c6a42d7d4e516f.zip
* lisp/mail/emacsbug.el (report-emacs-bug): No longer include recent-keys
Fixes: debbugs:18900
-rw-r--r--lisp/ChangeLog5
-rw-r--r--lisp/mail/emacsbug.el22
2 files changed, 8 insertions, 19 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 41e1039347c..d0d61da52f4 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
12014-11-04 Glenn Morris <rgm@gnu.org>
2
3 * mail/emacsbug.el (report-emacs-bug): No longer include
4 recent-keys in the report. (Bug#18900)
5
12014-11-03 Michael Albinus <michael.albinus@gmx.de> 62014-11-03 Michael Albinus <michael.albinus@gmx.de>
2 7
3 * net/tramp-sh.el (tramp-do-copy-or-rename-file-via-buffer): Use a 8 * net/tramp-sh.el (tramp-do-copy-or-rename-file-via-buffer): Use a
diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index b994949e94d..d0c575a9c79 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -143,11 +143,12 @@ This requires either the OS X \"open\" command, or the freedesktop
143 (error "Subject, To or body not found"))))) 143 (error "Subject, To or body not found")))))
144 144
145;;;###autoload 145;;;###autoload
146(defun report-emacs-bug (topic &optional recent-keys) 146(defun report-emacs-bug (topic &optional unused)
147 "Report a bug in GNU Emacs. 147 "Report a bug in GNU Emacs.
148Prompts for bug subject. Leaves you in a mail buffer." 148Prompts for bug subject. Leaves you in a mail buffer."
149 ;; This strange form ensures that (recent-keys) is the value before 149 ;; This strange form ensures that (recent-keys) is the value before
150 ;; the bug subject string is read. 150 ;; the bug subject string is read.
151 (declare (advertised-calling-convention (topic) "24.5"))
151 (interactive (reverse (list (recent-keys) (read-string "Bug Subject: ")))) 152 (interactive (reverse (list (recent-keys) (read-string "Bug Subject: "))))
152 ;; The syntax `version;' is preferred to `[version]' because the 153 ;; The syntax `version;' is preferred to `[version]' because the
153 ;; latter could be mistakenly stripped by mailing software. 154 ;; latter could be mistakenly stripped by mailing software.
@@ -276,23 +277,6 @@ usually do not have translators for other languages.\n\n")))
276 (and (boundp mode) (buffer-local-value mode from-buffer) 277 (and (boundp mode) (buffer-local-value mode from-buffer)
277 (insert (format " %s: %s\n" mode 278 (insert (format " %s: %s\n" mode
278 (buffer-local-value mode from-buffer))))) 279 (buffer-local-value mode from-buffer)))))
279 (insert "\n")
280 (insert "Recent input:\n")
281 (let ((before-keys (point)))
282 (insert (mapconcat (lambda (key)
283 (if (or (integerp key)
284 (symbolp key)
285 (listp key))
286 (single-key-description key)
287 (prin1-to-string key nil)))
288 (or recent-keys (recent-keys))
289 " "))
290 (save-restriction
291 (narrow-to-region before-keys (point))
292 (goto-char before-keys)
293 (while (progn (move-to-column 50) (not (eobp)))
294 (search-forward " " nil t)
295 (insert "\n"))))
296 (let ((message-buf (get-buffer "*Messages*"))) 280 (let ((message-buf (get-buffer "*Messages*")))
297 (if message-buf 281 (if message-buf
298 (let (beg-pos 282 (let (beg-pos
@@ -301,7 +285,7 @@ usually do not have translators for other languages.\n\n")))
301 (goto-char end-pos) 285 (goto-char end-pos)
302 (forward-line -10) 286 (forward-line -10)
303 (setq beg-pos (point))) 287 (setq beg-pos (point)))
304 (insert "\n\nRecent messages:\n") 288 (insert "\nRecent messages:\n")
305 (insert-buffer-substring message-buf beg-pos end-pos)))) 289 (insert-buffer-substring message-buf beg-pos end-pos))))
306 ;; After Recent messages, to avoid the messages produced by 290 ;; After Recent messages, to avoid the messages produced by
307 ;; list-load-path-shadows. 291 ;; list-load-path-shadows.