aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGlenn Morris2010-05-25 20:42:07 -0700
committerGlenn Morris2010-05-25 20:42:07 -0700
commitccd89fb3d6475cae1df64a64f87977c21e98389b (patch)
tree13c59eaf566fdb239414f3398bbb20aa78db1730
parent4710f4fcc51f8465e9b6f4099e66dcea04f59997 (diff)
downloademacs-ccd89fb3d6475cae1df64a64f87977c21e98389b.tar.gz
emacs-ccd89fb3d6475cae1df64a64f87977c21e98389b.zip
Remove some NS_IMPL_GNUSTEP build dead code.
* configure.in (NS_IMPL_GNUSTEP_INC, NS_IMPL_GNUSTEP_TEMACS_LDFLAGS) (GNUSTEP_MAKEFILES): Remove. (LD_SWITCH_SYSTEM_TEMACS): Move NS_IMPL_GNUSTEP_TEMACS_LDFLAGS stuff to here. * src/Makefile.in (NS_IMPL_GNUSTEP_INC, NS_IMPL_GNUSTEP_TEMACS_LDFLAGS): Remove. (TEMACS_LDFLAGS): Do not use NS_IMPL_GNUSTEP_TEMACS_LDFLAGS. * msdos/sed1v2.inp (NS_IMPL_GNUSTEP_INC, NS_IMPL_GNUSTEP_TEMACS_LDFLAGS): No longer present. Comments: See http://lists.gnu.org/archive/html/emacs-devel/2010-05/msg00846.html. Nothing from gui.make was used at all in src/Makefile.in. The only thing used from base.make was $CONFIG_SYSTEM_LIBS, but because we only set shared _after_ sourcing base.make, it was always empty. We can move the remaining flags, set in configure, to the standard variable LD_SWITCH_SYSTEM_TEMACS.
-rw-r--r--ChangeLog7
-rw-r--r--configure.in22
-rw-r--r--msdos/ChangeLog5
-rw-r--r--msdos/sed1v2.inp2
-rw-r--r--src/ChangeLog6
-rw-r--r--src/Makefile.in8
6 files changed, 25 insertions, 25 deletions
diff --git a/ChangeLog b/ChangeLog
index 0d014c28931..a0b6370c3ad 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
12010-05-26 Glenn Morris <rgm@gnu.org>
2
3 * configure.in (NS_IMPL_GNUSTEP_INC, NS_IMPL_GNUSTEP_TEMACS_LDFLAGS)
4 (GNUSTEP_MAKEFILES): Remove.
5 (LD_SWITCH_SYSTEM_TEMACS): Move NS_IMPL_GNUSTEP_TEMACS_LDFLAGS
6 stuff to here.
7
12010-05-25 Glenn Morris <rgm@gnu.org> 82010-05-25 Glenn Morris <rgm@gnu.org>
2 9
3 * configure.in (LD_SWITCH_SYSTEM): Move some gnu-linux stuff... 10 * configure.in (LD_SWITCH_SYSTEM): Move some gnu-linux stuff...
diff --git a/configure.in b/configure.in
index 13b550e005c..677080603da 100644
--- a/configure.in
+++ b/configure.in
@@ -1468,8 +1468,6 @@ fi
1468HAVE_NS=no 1468HAVE_NS=no
1469NS_IMPL_COCOA=no 1469NS_IMPL_COCOA=no
1470NS_IMPL_GNUSTEP=no 1470NS_IMPL_GNUSTEP=no
1471NS_IMPL_GNUSTEP_INC=
1472NS_IMPL_GNUSTEP_TEMACS_LDFLAGS=
1473tmp_CPPFLAGS="$CPPFLAGS" 1471tmp_CPPFLAGS="$CPPFLAGS"
1474tmp_CFLAGS="$CFLAGS" 1472tmp_CFLAGS="$CFLAGS"
1475CPPFLAGS="$CPPFLAGS -x objective-c" 1473CPPFLAGS="$CPPFLAGS -x objective-c"
@@ -1491,20 +1489,9 @@ if test "${with_ns}" != no; then
1491 ns_appbindir=${ns_appdir} 1489 ns_appbindir=${ns_appdir}
1492 ns_appresdir=${ns_appdir}Resources 1490 ns_appresdir=${ns_appdir}Resources
1493 ns_appsrc=${srcdir}/nextstep/GNUstep/Emacs.base 1491 ns_appsrc=${srcdir}/nextstep/GNUstep/Emacs.base
1494 dnl FIXME sourcing this 3 times in subshells seems inefficient. 1492 dnl FIXME sourcing this several times in subshells seems inefficient.
1495 GNUSTEP_MAKEFILES="$(. $GNUSTEP_CONFIG_FILE; echo $GNUSTEP_MAKEFILES)"
1496 GNUSTEP_SYSTEM_HEADERS="$(. $GNUSTEP_CONFIG_FILE; echo $GNUSTEP_SYSTEM_HEADERS)" 1493 GNUSTEP_SYSTEM_HEADERS="$(. $GNUSTEP_CONFIG_FILE; echo $GNUSTEP_SYSTEM_HEADERS)"
1497 GNUSTEP_SYSTEM_LIBRARIES="$(. $GNUSTEP_CONFIG_FILE; echo $GNUSTEP_SYSTEM_LIBRARIES)" 1494 GNUSTEP_SYSTEM_LIBRARIES="$(. $GNUSTEP_CONFIG_FILE; echo $GNUSTEP_SYSTEM_LIBRARIES)"
1498 ## Pull in stuff from GNUstep-make.
1499 ## FIXME? Cleaner to use AC_SUBST_FILE for this?
1500 NS_IMPL_GNUSTEP_INC="FOUNDATION_LIB=gnu
1501GUI_LIB=gnu
1502include $GNUSTEP_MAKEFILES/Additional/base.make
1503include $GNUSTEP_MAKEFILES/Additional/gui.make
1504shared=no
1505"
1506 dnl Presumably ${CONFIG_SYSTEM_LIBS} is defined by above includes.
1507 NS_IMPL_GNUSTEP_TEMACS_LDFLAGS="-L${GNUSTEP_SYSTEM_LIBRARIES} -lgnustep-gui -lgnustep-base -lobjc \${CONFIG_SYSTEM_LIBS} -lpthread"
1508 CPPFLAGS="$CPPFLAGS -I${GNUSTEP_SYSTEM_HEADERS}" 1495 CPPFLAGS="$CPPFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
1509 CFLAGS="$CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}" 1496 CFLAGS="$CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
1510 REAL_CFLAGS="$REAL_CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}" 1497 REAL_CFLAGS="$REAL_CFLAGS -I${GNUSTEP_SYSTEM_HEADERS}"
@@ -1525,8 +1512,6 @@ shared=no
1525 NS_HAVE_NSINTEGER=no 1512 NS_HAVE_NSINTEGER=no
1526 fi 1513 fi
1527fi 1514fi
1528AC_SUBST(NS_IMPL_GNUSTEP_INC)
1529AC_SUBST(NS_IMPL_GNUSTEP_TEMACS_LDFLAGS)
1530AC_SUBST(TEMACS_LDFLAGS2) 1515AC_SUBST(TEMACS_LDFLAGS2)
1531 1516
1532ns_frag=/dev/null 1517ns_frag=/dev/null
@@ -3311,6 +3296,11 @@ case "$opsys" in
3311 3296
3312 *) LD_SWITCH_SYSTEM_TEMACS= ;; 3297 *) LD_SWITCH_SYSTEM_TEMACS= ;;
3313esac 3298esac
3299
3300if test "$NS_IMPL_GNUSTEP=yes"; then
3301 LD_SWITCH_SYSTEM_TEMACS="${LD_SWITCH_SYSTEM_TEMACS} -L${GNUSTEP_SYSTEM_LIBRARIES} -L${GNUSTEP_LOCAL_LIBRARIES} -lgnustep-gui -lgnustep-base -lobjc -lpthread"
3302fi
3303
3314AC_SUBST(LD_SWITCH_SYSTEM_TEMACS) 3304AC_SUBST(LD_SWITCH_SYSTEM_TEMACS)
3315 3305
3316 3306
diff --git a/msdos/ChangeLog b/msdos/ChangeLog
index 8c94734a44f..db8a37896b8 100644
--- a/msdos/ChangeLog
+++ b/msdos/ChangeLog
@@ -1,3 +1,8 @@
12010-05-26 Glenn Morris <rgm@gnu.org>
2
3 * sed1v2.inp (NS_IMPL_GNUSTEP_INC, NS_IMPL_GNUSTEP_TEMACS_LDFLAGS):
4 No longer present.
5
12010-05-25 Glenn Morris <rgm@gnu.org> 62010-05-25 Glenn Morris <rgm@gnu.org>
2 7
3 * sed1v2.inp (LD_SWITCH_SYSTEM_EXTRA): No longer present. 8 * sed1v2.inp (LD_SWITCH_SYSTEM_EXTRA): No longer present.
diff --git a/msdos/sed1v2.inp b/msdos/sed1v2.inp
index 5317e8246f3..eec6be62195 100644
--- a/msdos/sed1v2.inp
+++ b/msdos/sed1v2.inp
@@ -129,8 +129,6 @@ s/\.h\.in/.h-in/
129/^M_FILE *=/s!@[^@\n]*@!m/intel386.h! 129/^M_FILE *=/s!@[^@\n]*@!m/intel386.h!
130/^S_FILE *=/s!@[^@\n]*@!s/msdos.h! 130/^S_FILE *=/s!@[^@\n]*@!s/msdos.h!
131/^@SET_MAKE@$/s/@SET_MAKE@// 131/^@SET_MAKE@$/s/@SET_MAKE@//
132/^@NS_IMPL_GNUSTEP_INC@/s/@NS_IMPL_GNUSTEP_INC@//
133/^NS_IMPL_GNUSTEP_TEMACS_LDFLAGS *=/s/@NS_IMPL_GNUSTEP_TEMACS_LDFLAGS@//
134/^.\${libsrc}make-docfile.*>/s!make-docfile!make-docfile -o ../etc/DOC! 132/^.\${libsrc}make-docfile.*>/s!make-docfile!make-docfile -o ../etc/DOC!
135/^.\${libsrc}make-doc/s!>.*$!! 133/^.\${libsrc}make-doc/s!>.*$!!
136/^[ ]*$/d 134/^[ ]*$/d
diff --git a/src/ChangeLog b/src/ChangeLog
index d451e873adb..ba513b1bcf2 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
12010-05-26 Glenn Morris <rgm@gnu.org>
2
3 * Makefile.in (NS_IMPL_GNUSTEP_INC, NS_IMPL_GNUSTEP_TEMACS_LDFLAGS):
4 Remove.
5 (TEMACS_LDFLAGS): Do not use NS_IMPL_GNUSTEP_TEMACS_LDFLAGS.
6
12010-05-26 Kenichi Handa <handa@m17n.org> 72010-05-26 Kenichi Handa <handa@m17n.org>
2 8
3 * composite.c (composition_compute_stop_pos): Fix condition for 9 * composite.c (composition_compute_stop_pos): Fix condition for
diff --git a/src/Makefile.in b/src/Makefile.in
index 0a2d1d0a8ab..bbe573e69be 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -111,14 +111,8 @@ LD_SWITCH_SYSTEM=@LD_SWITCH_SYSTEM@
111## which are only good with temacs. 111## which are only good with temacs.
112LD_SWITCH_SYSTEM_TEMACS=@LD_SWITCH_SYSTEM_TEMACS@ 112LD_SWITCH_SYSTEM_TEMACS=@LD_SWITCH_SYSTEM_TEMACS@
113 113
114## If NS_IMPL_GNUSTEP, some definitions and includes are expanded here.
115@NS_IMPL_GNUSTEP_INC@
116
117## This uses ${CONFIG_SYSTEM_LIBS} from NS_IMPL_GNUSTEP_INC.
118NS_IMPL_GNUSTEP_TEMACS_LDFLAGS=@NS_IMPL_GNUSTEP_TEMACS_LDFLAGS@
119
120## Flags to pass to ld only for temacs. 114## Flags to pass to ld only for temacs.
121TEMACS_LDFLAGS = $(LD_SWITCH_SYSTEM) $(LD_SWITCH_SYSTEM_TEMACS) $(NS_IMPL_GNUSTEP_TEMACS_LDFLAGS) 115TEMACS_LDFLAGS = $(LD_SWITCH_SYSTEM) $(LD_SWITCH_SYSTEM_TEMACS)
122 116
123## $LDFLAGS, or empty if NS_IMPL_GNUSTEP (for some reason). 117## $LDFLAGS, or empty if NS_IMPL_GNUSTEP (for some reason).
124TEMACS_LDFLAGS2 = @TEMACS_LDFLAGS2@ 118TEMACS_LDFLAGS2 = @TEMACS_LDFLAGS2@