aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJimmy Aguilar Mena2019-05-05 16:14:34 +0200
committerJimmy Aguilar Mena2019-05-05 16:59:25 +0200
commitcca81f22d972f4bfc953534104e9e72da421f51e (patch)
treebd03de18056f37ce1da42b46a792739909202856
parenta336300ccf024824fbf50298623e04f369952670 (diff)
downloademacs-cca81f22d972f4bfc953534104e9e72da421f51e.tar.gz
emacs-cca81f22d972f4bfc953534104e9e72da421f51e.zip
Fixed fill-column-indicator face removing background.
*lisp/faces.el: Removed background in default fill-column-indicator face. *src/xdisp.c: fill-column-indicator face merged with saved face.
-rw-r--r--doc/emacs/display.texi3
-rw-r--r--lisp/faces.el4
-rw-r--r--src/xdisp.c10
3 files changed, 10 insertions, 7 deletions
diff --git a/doc/emacs/display.texi b/doc/emacs/display.texi
index 34215699b42..c27b9e7081b 100644
--- a/doc/emacs/display.texi
+++ b/doc/emacs/display.texi
@@ -1186,7 +1186,8 @@ initialization tries to set it to U+2502 or @sampl{|}.
1186@item fill-column-indicator 1186@item fill-column-indicator
1187@vindex fill-column-indicator 1187@vindex fill-column-indicator
1188Specifies the face used to display the indicator. It inherits its 1188Specifies the face used to display the indicator. It inherits its
1189default values from shadow and the default face. 1189default values from shadow but without background color. To change
1190the indicator color you need to set only the foreground color of this face.
1190@end table 1191@end table
1191 1192
1192@vindex indicate-buffer-boundaries 1193@vindex indicate-buffer-boundaries
diff --git a/lisp/faces.el b/lisp/faces.el
index b9332790642..207b627f251 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2502,7 +2502,9 @@ unwanted effects."
2502 2502
2503;; Definition stolen from display-line-numbers. 2503;; Definition stolen from display-line-numbers.
2504(defface fill-column-indicator 2504(defface fill-column-indicator
2505 '((t :inherit (shadow default))) 2505 '((t :inherit shadow :weight normal :slant normal
2506 :underline nil :overline nil :strike-through nil
2507 :box nil :invert-video nil :stipple nil))
2506 "Face for displaying fill column indicator. 2508 "Face for displaying fill column indicator.
2507This face is used when `display-fill-column-indicator-mode' is 2509This face is used when `display-fill-column-indicator-mode' is
2508non-nil." 2510non-nil."
diff --git a/src/xdisp.c b/src/xdisp.c
index 17827481447..a8604d58af7 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -20201,7 +20201,7 @@ append_space_for_newline (struct it *it, bool default_face_p)
20201 XFIXNAT (Vdisplay_fill_column_indicator_character); 20201 XFIXNAT (Vdisplay_fill_column_indicator_character);
20202 it->face_id = 20202 it->face_id =
20203 merge_faces (it->w, Qfill_column_indicator, 20203 merge_faces (it->w, Qfill_column_indicator,
20204 0, DEFAULT_FACE_ID); 20204 0, saved_face_id);
20205 face = FACE_FROM_ID(it->f, it->face_id); 20205 face = FACE_FROM_ID(it->f, it->face_id);
20206 goto produce_glyphs; 20206 goto produce_glyphs;
20207 } 20207 }
@@ -20494,7 +20494,7 @@ extend_face_to_end_of_line (struct it *it)
20494 XFIXNAT (Vdisplay_fill_column_indicator_character); 20494 XFIXNAT (Vdisplay_fill_column_indicator_character);
20495 it->face_id = 20495 it->face_id =
20496 merge_faces (it->w, Qfill_column_indicator, 20496 merge_faces (it->w, Qfill_column_indicator,
20497 0, DEFAULT_FACE_ID); 20497 0, saved_face_id);
20498 PRODUCE_GLYPHS (it); 20498 PRODUCE_GLYPHS (it);
20499 } 20499 }
20500 20500
@@ -20656,13 +20656,13 @@ extend_face_to_end_of_line (struct it *it)
20656 { 20656 {
20657 if (it->current_x == fill_column_indicator_column) 20657 if (it->current_x == fill_column_indicator_column)
20658 { 20658 {
20659 const int saved_face = it->face_id; 20659 const int saved_face_id = it->face_id;
20660 it->face_id = 20660 it->face_id =
20661 merge_faces (it->w, Qfill_column_indicator, 0, DEFAULT_FACE_ID); 20661 merge_faces (it->w, Qfill_column_indicator, 0, saved_face_id);
20662 it->c = it->char_to_display = 20662 it->c = it->char_to_display =
20663 XFIXNAT (Vdisplay_fill_column_indicator_character); 20663 XFIXNAT (Vdisplay_fill_column_indicator_character);
20664 PRODUCE_GLYPHS (it); 20664 PRODUCE_GLYPHS (it);
20665 it->face_id = saved_face; 20665 it->face_id = saved_face_id;
20666 it->c = it->char_to_display = ' '; 20666 it->c = it->char_to_display = ' ';
20667 } 20667 }
20668 else 20668 else