diff options
| author | Juri Linkov | 2012-11-23 09:28:37 +0200 |
|---|---|---|
| committer | Juri Linkov | 2012-11-23 09:28:37 +0200 |
| commit | cc4c01bd96b929e5b19bcb77eebd40e12930ef06 (patch) | |
| tree | 2c8317b24e74b738b23612b4a86751611ba4ce7b | |
| parent | dc310ed0ab37f1176971061362bffc982926bd25 (diff) | |
| download | emacs-cc4c01bd96b929e5b19bcb77eebd40e12930ef06.tar.gz emacs-cc4c01bd96b929e5b19bcb77eebd40e12930ef06.zip | |
* lisp/wdired.el: Revert 2012-10-17 change partly and replace it with
Patch by Christopher Schmidt <christopher@ch.ristopher.com>.
(wdired-finish-edit): Add marks for new file names to
`wdired-old-marks'. Restore marks using `dired-mark-remembered'
after `revert-buffer'.
(wdired-do-renames): Remove calls to `dired-remove-file',
`dired-add-file', `dired-add-entry'.
Fixes: debbugs:11795
| -rw-r--r-- | lisp/ChangeLog | 10 | ||||
| -rw-r--r-- | lisp/wdired.el | 30 |
2 files changed, 25 insertions, 15 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index e0f67188227..6222c9d0237 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,13 @@ | |||
| 1 | 2012-11-23 Juri Linkov <juri@jurta.org> | ||
| 2 | |||
| 3 | * wdired.el: Revert 2012-10-17 change partly and replace it with | ||
| 4 | Patch by Christopher Schmidt <christopher@ch.ristopher.com>. | ||
| 5 | (wdired-finish-edit): Add marks for new file names to | ||
| 6 | `wdired-old-marks'. Restore marks using `dired-mark-remembered' | ||
| 7 | after `revert-buffer'. | ||
| 8 | (wdired-do-renames): Remove calls to `dired-remove-file', | ||
| 9 | `dired-add-file', `dired-add-entry'. (Bug#11795) | ||
| 10 | |||
| 1 | 2012-11-21 Alan Mackenzie <acm@muc.de> | 11 | 2012-11-21 Alan Mackenzie <acm@muc.de> |
| 2 | 12 | ||
| 3 | * progmodes/cc-defs.el (c-version): Bump to 5.32.4. | 13 | * progmodes/cc-defs.el (c-version): Bump to 5.32.4. |
diff --git a/lisp/wdired.el b/lisp/wdired.el index 9851b2046d9..5183b5639c3 100644 --- a/lisp/wdired.el +++ b/lisp/wdired.el | |||
| @@ -399,6 +399,15 @@ non-nil means return old filename." | |||
| 399 | (setq changes t) | 399 | (setq changes t) |
| 400 | (if (not file-new) ;empty filename! | 400 | (if (not file-new) ;empty filename! |
| 401 | (push file-old files-deleted) | 401 | (push file-old files-deleted) |
| 402 | (when wdired-keep-marker-rename | ||
| 403 | (let ((mark (cond ((integerp wdired-keep-marker-rename) | ||
| 404 | wdired-keep-marker-rename) | ||
| 405 | (wdired-keep-marker-rename | ||
| 406 | (cdr (assoc file-old wdired-old-marks))) | ||
| 407 | (t nil)))) | ||
| 408 | (when mark | ||
| 409 | (push (cons (substitute-in-file-name file-new) mark) | ||
| 410 | wdired-old-marks)))) | ||
| 402 | (push (cons file-old (substitute-in-file-name file-new)) | 411 | (push (cons file-old (substitute-in-file-name file-new)) |
| 403 | files-renamed)))) | 412 | files-renamed)))) |
| 404 | (forward-line -1))) | 413 | (forward-line -1))) |
| @@ -416,7 +425,9 @@ non-nil means return old filename." | |||
| 416 | (= (length files-renamed) 1)) | 425 | (= (length files-renamed) 1)) |
| 417 | (setq dired-directory (cdr (car files-renamed)))) | 426 | (setq dired-directory (cdr (car files-renamed)))) |
| 418 | ;; Re-sort the buffer. | 427 | ;; Re-sort the buffer. |
| 419 | (revert-buffer)) | 428 | (revert-buffer) |
| 429 | (let ((inhibit-read-only t)) | ||
| 430 | (dired-mark-remembered wdired-old-marks))) | ||
| 420 | (let ((inhibit-read-only t)) | 431 | (let ((inhibit-read-only t)) |
| 421 | (remove-text-properties (point-min) (point-max) | 432 | (remove-text-properties (point-min) (point-max) |
| 422 | '(old-name nil end-name nil old-link nil | 433 | '(old-name nil end-name nil old-link nil |
| @@ -430,8 +441,6 @@ non-nil means return old filename." | |||
| 430 | (set-buffer-modified-p nil) | 441 | (set-buffer-modified-p nil) |
| 431 | (setq buffer-undo-list nil)) | 442 | (setq buffer-undo-list nil)) |
| 432 | 443 | ||
| 433 | (declare-function dired-add-entry "dired-aux" (filename &optional marker-char relative)) | ||
| 434 | |||
| 435 | (defun wdired-do-renames (renames) | 444 | (defun wdired-do-renames (renames) |
| 436 | "Perform RENAMES in parallel." | 445 | "Perform RENAMES in parallel." |
| 437 | (let ((residue ()) | 446 | (let ((residue ()) |
| @@ -473,8 +482,7 @@ non-nil means return old filename." | |||
| 473 | (push (cons tmp file-new) residue)))) | 482 | (push (cons tmp file-new) residue)))) |
| 474 | (t | 483 | (t |
| 475 | (setq progress t) | 484 | (setq progress t) |
| 476 | (let* ((file-ori (car rename)) | 485 | (let ((file-ori (car rename))) |
| 477 | (old-mark (cdr (assoc file-ori wdired-old-marks)))) | ||
| 478 | (if wdired-use-interactive-rename | 486 | (if wdired-use-interactive-rename |
| 479 | (wdired-search-and-rename file-ori file-new) | 487 | (wdired-search-and-rename file-ori file-new) |
| 480 | ;; If dired-rename-file autoloads dired-aux while | 488 | ;; If dired-rename-file autoloads dired-aux while |
| @@ -485,20 +493,12 @@ non-nil means return old filename." | |||
| 485 | (condition-case err | 493 | (condition-case err |
| 486 | (let ((dired-backup-overwrite nil)) | 494 | (let ((dired-backup-overwrite nil)) |
| 487 | (dired-rename-file file-ori file-new | 495 | (dired-rename-file file-ori file-new |
| 488 | overwrite) | 496 | overwrite)) |
| 489 | (dired-remove-file file-ori) | ||
| 490 | (dired-add-file | ||
| 491 | file-new | ||
| 492 | (cond ((integerp wdired-keep-marker-rename) | ||
| 493 | wdired-keep-marker-rename) | ||
| 494 | (wdired-keep-marker-rename old-mark) | ||
| 495 | (t nil)))) | ||
| 496 | (error | 497 | (error |
| 497 | (setq errors (1+ errors)) | 498 | (setq errors (1+ errors)) |
| 498 | (dired-log (concat "Rename `" file-ori "' to `" | 499 | (dired-log (concat "Rename `" file-ori "' to `" |
| 499 | file-new "' failed:\n%s\n") | 500 | file-new "' failed:\n%s\n") |
| 500 | err) | 501 | err))))))))) |
| 501 | (dired-add-entry file-ori old-mark))))))))) | ||
| 502 | errors)) | 502 | errors)) |
| 503 | 503 | ||
| 504 | 504 | ||