diff options
| author | Stefan Monnier | 2008-03-12 18:44:07 +0000 |
|---|---|---|
| committer | Stefan Monnier | 2008-03-12 18:44:07 +0000 |
| commit | c9de775515a989ec2cf34818c73e4bc0f6cf42a8 (patch) | |
| tree | 472e73dc3bee0966b9129bb5dfd8b13187a67fdf | |
| parent | 9c5fe825f7eda8816add3fd1a9bc6e34a3434db2 (diff) | |
| download | emacs-c9de775515a989ec2cf34818c73e4bc0f6cf42a8.tar.gz emacs-c9de775515a989ec2cf34818c73e4bc0f6cf42a8.zip | |
Use with-current-buffer.
(nnmh-request-list-1): Use mm-string-to-multibyte rather than
mm-string-as-multibyte on the output of mm-encode-coding-string.
| -rw-r--r-- | lisp/gnus/ChangeLog | 4 | ||||
| -rw-r--r-- | lisp/gnus/nnmh.el | 16 |
2 files changed, 10 insertions, 10 deletions
diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog index f5d19f56bf9..f1122be967b 100644 --- a/lisp/gnus/ChangeLog +++ b/lisp/gnus/ChangeLog | |||
| @@ -1,5 +1,9 @@ | |||
| 1 | 2008-03-12 Stefan Monnier <monnier@iro.umontreal.ca> | 1 | 2008-03-12 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2 | 2 | ||
| 3 | * nnmh.el: Use with-current-buffer. | ||
| 4 | (nnmh-request-list-1): Use mm-string-to-multibyte rather than | ||
| 5 | mm-string-as-multibyte on the output of mm-encode-coding-string. | ||
| 6 | |||
| 3 | * nnimap.el (nnimap-retrieve-headers-progress): Use a unibyte temp buffer. | 7 | * nnimap.el (nnimap-retrieve-headers-progress): Use a unibyte temp buffer. |
| 4 | (nnimap-request-move-article): Use with-current-buffer. | 8 | (nnimap-request-move-article): Use with-current-buffer. |
| 5 | 9 | ||
diff --git a/lisp/gnus/nnmh.el b/lisp/gnus/nnmh.el index 11ad0dd706b..a2e9532db13 100644 --- a/lisp/gnus/nnmh.el +++ b/lisp/gnus/nnmh.el | |||
| @@ -77,8 +77,7 @@ as unread by Gnus.") | |||
| 77 | (nnoo-define-basics nnmh) | 77 | (nnoo-define-basics nnmh) |
| 78 | 78 | ||
| 79 | (deffoo nnmh-retrieve-headers (articles &optional newsgroup server fetch-old) | 79 | (deffoo nnmh-retrieve-headers (articles &optional newsgroup server fetch-old) |
| 80 | (save-excursion | 80 | (with-current-buffer nntp-server-buffer |
| 81 | (set-buffer nntp-server-buffer) | ||
| 82 | (erase-buffer) | 81 | (erase-buffer) |
| 83 | (let* ((file nil) | 82 | (let* ((file nil) |
| 84 | (number (length articles)) | 83 | (number (length articles)) |
| @@ -225,8 +224,7 @@ as unread by Gnus.") | |||
| 225 | (let ((files (mapcar 'string-to-number | 224 | (let ((files (mapcar 'string-to-number |
| 226 | (directory-files dir nil "^[0-9]+$" t)))) | 225 | (directory-files dir nil "^[0-9]+$" t)))) |
| 227 | (when files | 226 | (when files |
| 228 | (save-excursion | 227 | (with-current-buffer nntp-server-buffer |
| 229 | (set-buffer nntp-server-buffer) | ||
| 230 | (goto-char (point-max)) | 228 | (goto-char (point-max)) |
| 231 | (insert | 229 | (insert |
| 232 | (format | 230 | (format |
| @@ -237,7 +235,7 @@ as unread by Gnus.") | |||
| 237 | (file-truename (file-name-as-directory | 235 | (file-truename (file-name-as-directory |
| 238 | (expand-file-name nnmh-toplev)))) | 236 | (expand-file-name nnmh-toplev)))) |
| 239 | dir) | 237 | dir) |
| 240 | (mm-string-as-multibyte | 238 | (mm-string-to-multibyte ;Why? Isn't it multibyte already? |
| 241 | (mm-encode-coding-string | 239 | (mm-encode-coding-string |
| 242 | (nnheader-replace-chars-in-string | 240 | (nnheader-replace-chars-in-string |
| 243 | (substring dir (match-end 0)) | 241 | (substring dir (match-end 0)) |
| @@ -295,8 +293,7 @@ as unread by Gnus.") | |||
| 295 | (and | 293 | (and |
| 296 | (nnmh-deletable-article-p group article) | 294 | (nnmh-deletable-article-p group article) |
| 297 | (nnmh-request-article article group server) | 295 | (nnmh-request-article article group server) |
| 298 | (save-excursion | 296 | (with-current-buffer buf |
| 299 | (set-buffer buf) | ||
| 300 | (erase-buffer) | 297 | (erase-buffer) |
| 301 | (insert-buffer-substring nntp-server-buffer) | 298 | (insert-buffer-substring nntp-server-buffer) |
| 302 | (setq result (eval accept-form)) | 299 | (setq result (eval accept-form)) |
| @@ -336,8 +333,7 @@ as unread by Gnus.") | |||
| 336 | 333 | ||
| 337 | (deffoo nnmh-request-replace-article (article group buffer) | 334 | (deffoo nnmh-request-replace-article (article group buffer) |
| 338 | (nnmh-possibly-change-directory group) | 335 | (nnmh-possibly-change-directory group) |
| 339 | (save-excursion | 336 | (with-current-buffer buffer |
| 340 | (set-buffer buffer) | ||
| 341 | (nnmh-possibly-create-directory group) | 337 | (nnmh-possibly-create-directory group) |
| 342 | (ignore-errors | 338 | (ignore-errors |
| 343 | (nnmail-write-region | 339 | (nnmail-write-region |
| @@ -577,5 +573,5 @@ as unread by Gnus.") | |||
| 577 | 573 | ||
| 578 | (provide 'nnmh) | 574 | (provide 'nnmh) |
| 579 | 575 | ||
| 580 | ;;; arch-tag: 36c12a98-3bad-44b3-9953-628078ef0e04 | 576 | ;; arch-tag: 36c12a98-3bad-44b3-9953-628078ef0e04 |
| 581 | ;;; nnmh.el ends here | 577 | ;;; nnmh.el ends here |