* semantic/idle.el (semantic-idle-symbol-highlight)

(semantic-idle-symbol-highlight-face): Define face with defface
and obsolete the replaced one defined with defvar.  (Bug#15745)
* pulse.el (pulse-momentary-highlight-overlay)
(pulse-momentary-highlight-region): Fix typo in doc

3 files changed, 17 insertions, 3 deletions

diff --git a/lisp/cedet/ChangeLog b/lisp/cedet/ChangeLog
index 22ad40eb644..ec019d56ae2 100644
--- a/lisp/cedet/ChangeLog
+++ b/lisp/cedet/ChangeLog
@@ -1,3 +1,11 @@
+2013-10-28  Barry O'Reilly  <gundaetiapo@gmail.com>
+
+        * semantic/idle.el (semantic-idle-symbol-highlight)
+        (semantic-idle-symbol-highlight-face): Define face with defface
+        and obsolete the replaced one defined with defvar.  (Bug#15745)
+        * pulse.el (pulse-momentary-highlight-overlay)
+        (pulse-momentary-highlight-region): Fix typo in doc
+
 2013-10-30  Glenn Morris  <rgm@gnu.org>
 
         * semantic/grammar.el (semantic-grammar-mode-keywords-2)
diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 268beed8b1a..4a3b5011617 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -180,7 +180,7 @@ Be sure to call `pulse-reset-face' after calling pulse."
 
 (defun pulse-momentary-highlight-overlay (o &optional face)
   "Pulse the overlay O, unhighlighting before next command.
-Optional argument FACE specifies the fact to do the highlighting."
+Optional argument FACE specifies the face to do the highlighting."
   (overlay-put o 'original-face (overlay-get o 'face))
   (add-to-list 'pulse-momentary-overlay o)
   (if (eq pulse-flag 'never)
@@ -237,7 +237,7 @@ Optional argument FACE specifies the face to do the highlighting."
 
 (defun pulse-momentary-highlight-region (start end &optional face)
   "Highlight between START and END, unhighlighting before next command.
-Optional argument FACE specifies the fact to do the highlighting."
+Optional argument FACE specifies the face to do the highlighting."
   (let ((o (make-overlay start end)))
     ;; Mark it for deletion
     (overlay-put o 'pulse-delete t)
diff --git a/lisp/cedet/semantic/idle.el b/lisp/cedet/semantic/idle.el
index d024e5d8237..c15b6bf8bb4 100644
--- a/lisp/cedet/semantic/idle.el
+++ b/lisp/cedet/semantic/idle.el
@@ -830,8 +830,14 @@ turned on in every Semantic-supported buffer."
 ;; of all uses of the symbol that is under the cursor.
 ;;
 ;; This is to mimic the Eclipse tool of a similar nature.
-(defvar semantic-idle-symbol-highlight-face 'region
+(defface semantic-idle-symbol-highlight
+  '((t :inherit region))
+  "Face used for highlighting local symbols."
+  :group 'semantic-faces)
+(defvar semantic-idle-symbol-highlight-face 'semantic-idle-symbol-highlight
   "Face used for highlighting local symbols.")
+(make-obsolete-variable 'semantic-idle-symbol-highlight-face
+    "customize the face `semantic-idle-symbol-highlight' instead" "24.4" 'set)
 
 (defun semantic-idle-symbol-maybe-highlight (tag)
   "Perhaps add highlighting to the symbol represented by TAG.