diff options
| author | Fabián Ezequiel Gallina | 2012-07-17 15:02:53 -0300 |
|---|---|---|
| committer | Fabián Ezequiel Gallina | 2012-07-17 15:02:53 -0300 |
| commit | bcdc27d7d4a5914ddbbec86441064bbe8f231a52 (patch) | |
| tree | b45c4cef573bc17898aba83f823dd218e17189ac | |
| parent | 191da00ee25cec5d13f257720ef401fc31203384 (diff) | |
| download | emacs-bcdc27d7d4a5914ddbbec86441064bbe8f231a52.tar.gz emacs-bcdc27d7d4a5914ddbbec86441064bbe8f231a52.zip | |
Final renames and doc fixes for movement commands.
* progmodes/python.el (python-nav-beginning-of-statement): Rename
from python-nav-statement-start.
(python-nav-end-of-statement): Rename from
python-nav-statement-end.
(python-nav-beginning-of-block): Rename from
python-nav-block-start.
(python-nav-end-of-block): Rename from python-nav-block-end.
Fixes: debbugs:11899
| -rw-r--r-- | lisp/ChangeLog | 10 | ||||
| -rw-r--r-- | lisp/progmodes/python.el | 71 |
2 files changed, 47 insertions, 34 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 8fbe6d35940..49cba828b69 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,4 +1,14 @@ | |||
| 1 | 2012-07-17 Fabián Ezequiel Gallina <fgallina@cuca> | 1 | 2012-07-17 Fabián Ezequiel Gallina <fgallina@cuca> |
| 2 | Final renames and doc fixes for movement commands (bug#11899). | ||
| 3 | * progmodes/python.el (python-nav-beginning-of-statement): Rename | ||
| 4 | from python-nav-statement-start. | ||
| 5 | (python-nav-end-of-statement): Rename from | ||
| 6 | python-nav-statement-end. | ||
| 7 | (python-nav-beginning-of-block): Rename from | ||
| 8 | python-nav-block-start. | ||
| 9 | (python-nav-end-of-block): Rename from python-nav-block-end. | ||
| 10 | |||
| 11 | 2012-07-17 Fabián Ezequiel Gallina <fgallina@cuca> | ||
| 2 | 12 | ||
| 3 | * progmodes/python.el (python-shell-send-string-no-output): Allow | 13 | * progmodes/python.el (python-shell-send-string-no-output): Allow |
| 4 | accept-process-output to quit, keeping shell process ready for | 14 | accept-process-output to quit, keeping shell process ready for |
diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index f6a1fbf3ab7..e9b5770dc87 100644 --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el | |||
| @@ -50,9 +50,12 @@ | |||
| 50 | ;; `python-nav-forward-block', `python-nav-backward-block' | 50 | ;; `python-nav-forward-block', `python-nav-backward-block' |
| 51 | ;; respectively which navigate between beginning of blocks of code. | 51 | ;; respectively which navigate between beginning of blocks of code. |
| 52 | ;; Extra functions `python-nav-forward-statement', | 52 | ;; Extra functions `python-nav-forward-statement', |
| 53 | ;; `python-nav-backward-statement', `python-nav-statement-start', | 53 | ;; `python-nav-backward-statement', |
| 54 | ;; `python-nav-statement-end', `python-nav-block-start' and | 54 | ;; `python-nav-beginning-of-statement', `python-nav-end-of-statement', |
| 55 | ;; `python-nav-block-end' are included but no bound to any key. | 55 | ;; `python-nav-beginning-of-block' and `python-nav-end-of-block' are |
| 56 | ;; included but no bound to any key. At last but not least the | ||
| 57 | ;; specialized `python-nav-forward-sexp-function' allows easy | ||
| 58 | ;; navigation between code blocks. | ||
| 56 | 59 | ||
| 57 | ;; Shell interaction: is provided and allows you to execute easily any | 60 | ;; Shell interaction: is provided and allows you to execute easily any |
| 58 | ;; block of code of your current buffer in an inferior Python process. | 61 | ;; block of code of your current buffer in an inferior Python process. |
| @@ -664,7 +667,7 @@ START is the buffer position where the sexp starts." | |||
| 664 | ((setq start (save-excursion | 667 | ((setq start (save-excursion |
| 665 | (back-to-indentation) | 668 | (back-to-indentation) |
| 666 | (python-util-forward-comment -1) | 669 | (python-util-forward-comment -1) |
| 667 | (python-nav-statement-start) | 670 | (python-nav-beginning-of-statement) |
| 668 | (point-marker))) | 671 | (point-marker))) |
| 669 | 'after-line) | 672 | 'after-line) |
| 670 | ;; Do not indent | 673 | ;; Do not indent |
| @@ -1097,7 +1100,7 @@ Returns nil if point is not in a def or class." | |||
| 1097 | (python-info-ppss-context-type)) | 1100 | (python-info-ppss-context-type)) |
| 1098 | (forward-line 1))))))) | 1101 | (forward-line 1))))))) |
| 1099 | 1102 | ||
| 1100 | (defun python-nav-statement-start () | 1103 | (defun python-nav-beginning-of-statement () |
| 1101 | "Move to start of current statement." | 1104 | "Move to start of current statement." |
| 1102 | (interactive "^") | 1105 | (interactive "^") |
| 1103 | (while (and (or (back-to-indentation) t) | 1106 | (while (and (or (back-to-indentation) t) |
| @@ -1110,7 +1113,7 @@ Returns nil if point is not in a def or class." | |||
| 1110 | (python-info-ppss-context 'paren)) | 1113 | (python-info-ppss-context 'paren)) |
| 1111 | (forward-line -1))))) | 1114 | (forward-line -1))))) |
| 1112 | 1115 | ||
| 1113 | (defun python-nav-statement-end () | 1116 | (defun python-nav-end-of-statement () |
| 1114 | "Move to end of current statement." | 1117 | "Move to end of current statement." |
| 1115 | (interactive "^") | 1118 | (interactive "^") |
| 1116 | (while (and (goto-char (line-end-position)) | 1119 | (while (and (goto-char (line-end-position)) |
| @@ -1135,29 +1138,29 @@ backward to previous statement." | |||
| 1135 | (interactive "^p") | 1138 | (interactive "^p") |
| 1136 | (or arg (setq arg 1)) | 1139 | (or arg (setq arg 1)) |
| 1137 | (while (> arg 0) | 1140 | (while (> arg 0) |
| 1138 | (python-nav-statement-end) | 1141 | (python-nav-end-of-statement) |
| 1139 | (python-util-forward-comment) | 1142 | (python-util-forward-comment) |
| 1140 | (python-nav-statement-start) | 1143 | (python-nav-beginning-of-statement) |
| 1141 | (setq arg (1- arg))) | 1144 | (setq arg (1- arg))) |
| 1142 | (while (< arg 0) | 1145 | (while (< arg 0) |
| 1143 | (python-nav-statement-start) | 1146 | (python-nav-beginning-of-statement) |
| 1144 | (python-util-forward-comment -1) | 1147 | (python-util-forward-comment -1) |
| 1145 | (python-nav-statement-start) | 1148 | (python-nav-beginning-of-statement) |
| 1146 | (setq arg (1+ arg)))) | 1149 | (setq arg (1+ arg)))) |
| 1147 | 1150 | ||
| 1148 | (defun python-nav-block-start () | 1151 | (defun python-nav-beginning-of-block () |
| 1149 | "Move to start of current block." | 1152 | "Move to start of current block." |
| 1150 | (interactive "^") | 1153 | (interactive "^") |
| 1151 | (let ((starting-pos (point)) | 1154 | (let ((starting-pos (point)) |
| 1152 | (block-regexp (python-rx | 1155 | (block-regexp (python-rx |
| 1153 | line-start (* whitespace) block-start))) | 1156 | line-start (* whitespace) block-start))) |
| 1154 | (if (progn | 1157 | (if (progn |
| 1155 | (python-nav-statement-start) | 1158 | (python-nav-beginning-of-statement) |
| 1156 | (looking-at (python-rx block-start))) | 1159 | (looking-at (python-rx block-start))) |
| 1157 | (point-marker) | 1160 | (point-marker) |
| 1158 | ;; Go to first line beginning a statement | 1161 | ;; Go to first line beginning a statement |
| 1159 | (while (and (not (bobp)) | 1162 | (while (and (not (bobp)) |
| 1160 | (or (and (python-nav-statement-start) nil) | 1163 | (or (and (python-nav-beginning-of-statement) nil) |
| 1161 | (python-info-current-line-comment-p) | 1164 | (python-info-current-line-comment-p) |
| 1162 | (python-info-current-line-empty-p))) | 1165 | (python-info-current-line-empty-p))) |
| 1163 | (forward-line -1)) | 1166 | (forward-line -1)) |
| @@ -1171,16 +1174,16 @@ backward to previous statement." | |||
| 1171 | (point-marker) | 1174 | (point-marker) |
| 1172 | (and (goto-char starting-pos) nil)))))) | 1175 | (and (goto-char starting-pos) nil)))))) |
| 1173 | 1176 | ||
| 1174 | (defun python-nav-block-end () | 1177 | (defun python-nav-end-of-block () |
| 1175 | "Move to end of current block." | 1178 | "Move to end of current block." |
| 1176 | (interactive "^") | 1179 | (interactive "^") |
| 1177 | (when (python-nav-block-start) | 1180 | (when (python-nav-beginning-of-block) |
| 1178 | (let ((block-indentation (current-indentation))) | 1181 | (let ((block-indentation (current-indentation))) |
| 1179 | (python-nav-statement-end) | 1182 | (python-nav-end-of-statement) |
| 1180 | (while (and (forward-line 1) | 1183 | (while (and (forward-line 1) |
| 1181 | (not (eobp)) | 1184 | (not (eobp)) |
| 1182 | (or (and (> (current-indentation) block-indentation) | 1185 | (or (and (> (current-indentation) block-indentation) |
| 1183 | (or (python-nav-statement-end) t)) | 1186 | (or (python-nav-end-of-statement) t)) |
| 1184 | (python-info-current-line-comment-p) | 1187 | (python-info-current-line-comment-p) |
| 1185 | (python-info-current-line-empty-p)))) | 1188 | (python-info-current-line-empty-p)))) |
| 1186 | (python-util-forward-comment -1) | 1189 | (python-util-forward-comment -1) |
| @@ -1203,7 +1206,7 @@ backward to previous block." | |||
| 1203 | (python-rx line-start (* whitespace) block-start)) | 1206 | (python-rx line-start (* whitespace) block-start)) |
| 1204 | (starting-pos (point))) | 1207 | (starting-pos (point))) |
| 1205 | (while (> arg 0) | 1208 | (while (> arg 0) |
| 1206 | (python-nav-statement-end) | 1209 | (python-nav-end-of-statement) |
| 1207 | (while (and | 1210 | (while (and |
| 1208 | (re-search-forward block-start-regexp nil t) | 1211 | (re-search-forward block-start-regexp nil t) |
| 1209 | (or (python-info-ppss-context 'string) | 1212 | (or (python-info-ppss-context 'string) |
| @@ -1211,14 +1214,14 @@ backward to previous block." | |||
| 1211 | (python-info-ppss-context 'paren)))) | 1214 | (python-info-ppss-context 'paren)))) |
| 1212 | (setq arg (1- arg))) | 1215 | (setq arg (1- arg))) |
| 1213 | (while (< arg 0) | 1216 | (while (< arg 0) |
| 1214 | (python-nav-statement-start) | 1217 | (python-nav-beginning-of-statement) |
| 1215 | (while (and | 1218 | (while (and |
| 1216 | (re-search-backward block-start-regexp nil t) | 1219 | (re-search-backward block-start-regexp nil t) |
| 1217 | (or (python-info-ppss-context 'string) | 1220 | (or (python-info-ppss-context 'string) |
| 1218 | (python-info-ppss-context 'comment) | 1221 | (python-info-ppss-context 'comment) |
| 1219 | (python-info-ppss-context 'paren)))) | 1222 | (python-info-ppss-context 'paren)))) |
| 1220 | (setq arg (1+ arg))) | 1223 | (setq arg (1+ arg))) |
| 1221 | (python-nav-statement-start) | 1224 | (python-nav-beginning-of-statement) |
| 1222 | (if (not (looking-at (python-rx block-start))) | 1225 | (if (not (looking-at (python-rx block-start))) |
| 1223 | (and (goto-char starting-pos) nil) | 1226 | (and (goto-char starting-pos) nil) |
| 1224 | (and (not (= (point) starting-pos)) (point-marker))))) | 1227 | (and (not (= (point) starting-pos)) (point-marker))))) |
| @@ -1231,9 +1234,9 @@ move backward N times." | |||
| 1231 | (or arg (setq arg 1)) | 1234 | (or arg (setq arg 1)) |
| 1232 | (while (> arg 0) | 1235 | (while (> arg 0) |
| 1233 | (let ((block-starting-pos | 1236 | (let ((block-starting-pos |
| 1234 | (save-excursion (python-nav-block-start))) | 1237 | (save-excursion (python-nav-beginning-of-block))) |
| 1235 | (block-ending-pos | 1238 | (block-ending-pos |
| 1236 | (save-excursion (python-nav-block-end))) | 1239 | (save-excursion (python-nav-end-of-block))) |
| 1237 | (next-block-starting-pos | 1240 | (next-block-starting-pos |
| 1238 | (save-excursion (python-nav-forward-block)))) | 1241 | (save-excursion (python-nav-forward-block)))) |
| 1239 | (cond ((not block-starting-pos) | 1242 | (cond ((not block-starting-pos) |
| @@ -1241,39 +1244,39 @@ move backward N times." | |||
| 1241 | ((= (point) block-starting-pos) | 1244 | ((= (point) block-starting-pos) |
| 1242 | (if (or (not next-block-starting-pos) | 1245 | (if (or (not next-block-starting-pos) |
| 1243 | (< block-ending-pos next-block-starting-pos)) | 1246 | (< block-ending-pos next-block-starting-pos)) |
| 1244 | (python-nav-block-end) | 1247 | (python-nav-end-of-block) |
| 1245 | (python-nav-forward-block))) | 1248 | (python-nav-forward-block))) |
| 1246 | ((= block-ending-pos (point)) | 1249 | ((= block-ending-pos (point)) |
| 1247 | (let ((parent-block-end-pos | 1250 | (let ((parent-block-end-pos |
| 1248 | (save-excursion | 1251 | (save-excursion |
| 1249 | (python-util-forward-comment) | 1252 | (python-util-forward-comment) |
| 1250 | (python-nav-block-start) | 1253 | (python-nav-beginning-of-block) |
| 1251 | (python-nav-block-end)))) | 1254 | (python-nav-end-of-block)))) |
| 1252 | (if (and parent-block-end-pos | 1255 | (if (and parent-block-end-pos |
| 1253 | (or (not next-block-starting-pos) | 1256 | (or (not next-block-starting-pos) |
| 1254 | (> next-block-starting-pos parent-block-end-pos))) | 1257 | (> next-block-starting-pos parent-block-end-pos))) |
| 1255 | (goto-char parent-block-end-pos) | 1258 | (goto-char parent-block-end-pos) |
| 1256 | (python-nav-forward-block)))) | 1259 | (python-nav-forward-block)))) |
| 1257 | (t (python-nav-block-end)))) | 1260 | (t (python-nav-end-of-block)))) |
| 1258 | (setq arg (1- arg))) | 1261 | (setq arg (1- arg))) |
| 1259 | (while (< arg 0) | 1262 | (while (< arg 0) |
| 1260 | (let* ((block-starting-pos | 1263 | (let* ((block-starting-pos |
| 1261 | (save-excursion (python-nav-block-start))) | 1264 | (save-excursion (python-nav-beginning-of-block))) |
| 1262 | (block-ending-pos | 1265 | (block-ending-pos |
| 1263 | (save-excursion (python-nav-block-end))) | 1266 | (save-excursion (python-nav-end-of-block))) |
| 1264 | (prev-block-ending-pos | 1267 | (prev-block-ending-pos |
| 1265 | (save-excursion (when (python-nav-backward-block) | 1268 | (save-excursion (when (python-nav-backward-block) |
| 1266 | (python-nav-block-end)))) | 1269 | (python-nav-end-of-block)))) |
| 1267 | (prev-block-parent-ending-pos | 1270 | (prev-block-parent-ending-pos |
| 1268 | (save-excursion | 1271 | (save-excursion |
| 1269 | (when prev-block-ending-pos | 1272 | (when prev-block-ending-pos |
| 1270 | (goto-char prev-block-ending-pos) | 1273 | (goto-char prev-block-ending-pos) |
| 1271 | (python-util-forward-comment) | 1274 | (python-util-forward-comment) |
| 1272 | (python-nav-block-start) | 1275 | (python-nav-beginning-of-block) |
| 1273 | (python-nav-block-end))))) | 1276 | (python-nav-end-of-block))))) |
| 1274 | (cond ((not block-ending-pos) | 1277 | (cond ((not block-ending-pos) |
| 1275 | (and (python-nav-backward-block) | 1278 | (and (python-nav-backward-block) |
| 1276 | (python-nav-block-end))) | 1279 | (python-nav-end-of-block))) |
| 1277 | ((= (point) block-ending-pos) | 1280 | ((= (point) block-ending-pos) |
| 1278 | (let ((candidates)) | 1281 | (let ((candidates)) |
| 1279 | (dolist (name | 1282 | (dolist (name |
| @@ -1286,7 +1289,7 @@ move backward N times." | |||
| 1286 | (add-to-list 'candidates (symbol-value name)))) | 1289 | (add-to-list 'candidates (symbol-value name)))) |
| 1287 | (goto-char (apply 'max candidates)))) | 1290 | (goto-char (apply 'max candidates)))) |
| 1288 | ((> (point) block-ending-pos) | 1291 | ((> (point) block-ending-pos) |
| 1289 | (python-nav-block-end)) | 1292 | (python-nav-end-of-block)) |
| 1290 | ((= (point) block-starting-pos) | 1293 | ((= (point) block-starting-pos) |
| 1291 | (if (not (> (point) (or prev-block-ending-pos (point)))) | 1294 | (if (not (> (point) (or prev-block-ending-pos (point)))) |
| 1292 | (python-nav-backward-block) | 1295 | (python-nav-backward-block) |
| @@ -1299,7 +1302,7 @@ move backward N times." | |||
| 1299 | (when (and parent-block-ending-pos | 1302 | (when (and parent-block-ending-pos |
| 1300 | (> parent-block-ending-pos prev-block-ending-pos)) | 1303 | (> parent-block-ending-pos prev-block-ending-pos)) |
| 1301 | (goto-char parent-block-ending-pos))))) | 1304 | (goto-char parent-block-ending-pos))))) |
| 1302 | (t (python-nav-block-start)))) | 1305 | (t (python-nav-beginning-of-block)))) |
| 1303 | (setq arg (1+ arg)))) | 1306 | (setq arg (1+ arg)))) |
| 1304 | 1307 | ||
| 1305 | 1308 | ||