aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Eggert2014-04-30 10:54:27 -0700
committerPaul Eggert2014-04-30 10:54:27 -0700
commitbc6cb3efd06266e5f51862449700e2e559277095 (patch)
treec07e4cb9935eb1f75861c6212ff4fc87d4da4348
parent72962dd88224fe01ea392482017bbf179a621a8e (diff)
downloademacs-bc6cb3efd06266e5f51862449700e2e559277095.tar.gz
emacs-bc6cb3efd06266e5f51862449700e2e559277095.zip
* term.c (tty_menu_activate): Don't assume row and col are initialized.
GCC 4.9.0 warned about this, and I couldn't easily prove to my own satisfaction that they would always be initialized.
-rw-r--r--src/ChangeLog6
-rw-r--r--src/term.c5
2 files changed, 10 insertions, 1 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index c98b8546788..ab87645b48b 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
12014-04-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 * term.c (tty_menu_activate): Don't assume row and col are initialized.
4 GCC 4.9.0 warned about this, and I couldn't easily prove to my own
5 satisfaction that they would always be initialized.
6
12014-04-29 Eli Zaretskii <eliz@gnu.org> 72014-04-29 Eli Zaretskii <eliz@gnu.org>
2 8
3 * term.c (tty_menu_display): Move the cursor to the active menu 9 * term.c (tty_menu_display): Move the cursor to the active menu
diff --git a/src/term.c b/src/term.c
index 354354fa745..3bbb21f1589 100644
--- a/src/term.c
+++ b/src/term.c
@@ -3378,6 +3378,8 @@ tty_menu_activate (tty_menu *menu, int *pane, int *selidx,
3378 col = cursorX (tty); 3378 col = cursorX (tty);
3379 row = cursorY (tty); 3379 row = cursorY (tty);
3380 } 3380 }
3381 else
3382 row = -1;
3381 3383
3382 /* Display the help-echo message for the currently-selected menu 3384 /* Display the help-echo message for the currently-selected menu
3383 item. */ 3385 item. */
@@ -3389,7 +3391,8 @@ tty_menu_activate (tty_menu *menu, int *pane, int *selidx,
3389 /* Move the cursor to the beginning of the current menu 3391 /* Move the cursor to the beginning of the current menu
3390 item, so that screen readers and other accessibility aids 3392 item, so that screen readers and other accessibility aids
3391 know where the active region is. */ 3393 know where the active region is. */
3392 cursor_to (sf, row, col); 3394 if (0 <= row)
3395 cursor_to (sf, row, col);
3393 tty_hide_cursor (tty); 3396 tty_hide_cursor (tty);
3394 fflush (tty->output); 3397 fflush (tty->output);
3395 prev_menu_help_message = menu_help_message; 3398 prev_menu_help_message = menu_help_message;