aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Roberts2004-04-17 23:14:17 +0000
committerNick Roberts2004-04-17 23:14:17 +0000
commitb65a2dbf33b2ab0f9baba8526c356dc7dab63244 (patch)
treebe59c89985f4dae477c056c814fdc2550ad1314a
parent677eb6a5cf89f8a2adbbd5bfec4e8fe67565ccca (diff)
downloademacs-b65a2dbf33b2ab0f9baba8526c356dc7dab63244.tar.gz
emacs-b65a2dbf33b2ab0f9baba8526c356dc7dab63244.zip
(gdb-goto-info): Require 'info.
(gdb-info-breakpoints-custom): Revert previous change. (gdb-view-assembler): Update assembler if necessary. (gdb-frame-handler): Parse correctly for gdb-current-frame. (gdb-display-source-buffer): Update properly when both source and assembler are visible.
-rw-r--r--lisp/progmodes/gdb-ui.el19
1 files changed, 10 insertions, 9 deletions
diff --git a/lisp/progmodes/gdb-ui.el b/lisp/progmodes/gdb-ui.el
index 8446266b2f3..b33f8f3f239 100644
--- a/lisp/progmodes/gdb-ui.el
+++ b/lisp/progmodes/gdb-ui.el
@@ -222,6 +222,7 @@ speedbar."
222(defun gdb-goto-info () 222(defun gdb-goto-info ()
223 (interactive) 223 (interactive)
224 (select-frame (make-frame)) 224 (select-frame (make-frame))
225 (require 'info)
225 (Info-goto-node "(emacs)GDB Graphical Interface")) 226 (Info-goto-node "(emacs)GDB Graphical Interface"))
226 227
227(defconst gdb-var-create-regexp 228(defconst gdb-var-create-regexp
@@ -688,9 +689,9 @@ This filter may simply queue output for a later time."
688 (string-to-int (match-string 2 args)))) 689 (string-to-int (match-string 2 args))))
689 (setq gdb-current-address (match-string 3 args)) 690 (setq gdb-current-address (match-string 3 args))
690 (setq gdb-view-source t) 691 (setq gdb-view-source t)
691;; cover for auto-display output which comes *before* 692 ;; cover for auto-display output which comes *before*
692;; stopped annotation 693 ;; stopped annotation
693 (if (eq (gdb-get-output-sink) 'inferior) (gdb-set-output-sink 'user))) 694 (if (eq (gdb-get-output-sink) 'inferior) (gdb-set-output-sink 'user)))
694 695
695(defun gdb-send-item (item) 696(defun gdb-send-item (item)
696 (if gdb-enable-debug-log (push (cons 'send item) gdb-debug-log)) 697 (if gdb-enable-debug-log (push (cons 'send item) gdb-debug-log))
@@ -1112,7 +1113,8 @@ static char *magick[] = {
1112 (save-excursion 1113 (save-excursion
1113 (goto-line (string-to-number line)) 1114 (goto-line (string-to-number line))
1114 (gdb-put-breakpoint-icon (eq flag ?y))))))))) 1115 (gdb-put-breakpoint-icon (eq flag ?y)))))))))
1115 (end-of-line)))))) 1116 (end-of-line)))))
1117 (if (gdb-get-buffer 'gdb-assembler-buffer) (gdb-assembler-custom)))
1116 1118
1117(defun gdb-mouse-toggle-breakpoint (event) 1119(defun gdb-mouse-toggle-breakpoint (event)
1118 "Toggle breakpoint with mouse click in left margin." 1120 "Toggle breakpoint with mouse click in left margin."
@@ -1532,11 +1534,9 @@ the source buffer."
1532 1534
1533(defun gdb-display-source-buffer (buffer) 1535(defun gdb-display-source-buffer (buffer)
1534 (if (eq gdb-selected-view 'source) 1536 (if (eq gdb-selected-view 'source)
1535 (progn
1536 (gdb-display-buffer buffer) 1537 (gdb-display-buffer buffer)
1537 (get-buffer-window buffer)) 1538 (gdb-display-buffer (gdb-get-buffer 'gdb-assembler-buffer)))
1538 (gdb-display-buffer (gdb-get-buffer 'gdb-assembler-buffer)) 1539 (get-buffer-window buffer))
1539 nil))
1540 1540
1541 1541
1542;;; Shared keymap initialization: 1542;;; Shared keymap initialization:
@@ -1612,6 +1612,7 @@ the source buffer."
1612(defun gdb-view-assembler() 1612(defun gdb-view-assembler()
1613 (interactive) 1613 (interactive)
1614 (gdb-display-buffer (gdb-get-create-buffer 'gdb-assembler-buffer)) 1614 (gdb-display-buffer (gdb-get-create-buffer 'gdb-assembler-buffer))
1615 (gdb-invalidate-assembler)
1615 (setq gdb-selected-view 'assembler)) 1616 (setq gdb-selected-view 'assembler))
1616 1617
1617;(defun gdb-view-both() 1618;(defun gdb-view-both()
@@ -1964,7 +1965,7 @@ BUFFER nil or omitted means use the current buffer."
1964 (with-current-buffer (gdb-get-create-buffer 'gdb-partial-output-buffer) 1965 (with-current-buffer (gdb-get-create-buffer 'gdb-partial-output-buffer)
1965 (goto-char (point-min)) 1966 (goto-char (point-min))
1966 (forward-line) 1967 (forward-line)
1967 (if (looking-at ".*=\\s-+0x\\(\\S-*\\)\\s-+in\\s-+\\(\\S-*\\)") 1968 (if (looking-at ".*=\\s-+0x\\(\\S-*\\)\\s-+in\\s-+\\(\\S-*?\\);? ")
1968 (progn 1969 (progn
1969 (setq gdb-current-frame (match-string 2)) 1970 (setq gdb-current-frame (match-string 2))
1970 (let ((address (match-string 1))) 1971 (let ((address (match-string 1)))