diff options
| author | Dmitry Antipov | 2013-09-03 17:29:38 +0400 |
|---|---|---|
| committer | Dmitry Antipov | 2013-09-03 17:29:38 +0400 |
| commit | b1cf96dec798e85874002803d16f9848b73d4f70 (patch) | |
| tree | 464b9807a07849d240b6e6cf630a0dff227fee3b | |
| parent | ec5e75040267c92ebd01fed9d185ff7fdd7d31a3 (diff) | |
| download | emacs-b1cf96dec798e85874002803d16f9848b73d4f70.tar.gz emacs-b1cf96dec798e85874002803d16f9848b73d4f70.zip | |
* buffer.c (Fmake_overlay, Fmove_overlay):
* intervals.c (set_point_from_marker):
* print.c (PRINTPREPARE): Prefer signal_error
to plain error and report unsuitable marker too.
| -rw-r--r-- | src/ChangeLog | 7 | ||||
| -rw-r--r-- | src/buffer.c | 24 | ||||
| -rw-r--r-- | src/intervals.c | 2 | ||||
| -rw-r--r-- | src/print.c | 9 |
4 files changed, 24 insertions, 18 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 18c867f7b6d..b2a200e3147 100644 --- a/src/ChangeLog +++ b/src/ChangeLog | |||
| @@ -1,5 +1,12 @@ | |||
| 1 | 2013-09-03 Dmitry Antipov <dmantipov@yandex.ru> | 1 | 2013-09-03 Dmitry Antipov <dmantipov@yandex.ru> |
| 2 | 2 | ||
| 3 | * buffer.c (Fmake_overlay, Fmove_overlay): | ||
| 4 | * intervals.c (set_point_from_marker): | ||
| 5 | * print.c (PRINTPREPARE): Prefer signal_error | ||
| 6 | to plain error and report unsuitable marker too. | ||
| 7 | |||
| 8 | 2013-09-03 Dmitry Antipov <dmantipov@yandex.ru> | ||
| 9 | |||
| 3 | * xterm.h (struct scroll_bar): Prefer int to Lisp_Object | 10 | * xterm.h (struct scroll_bar): Prefer int to Lisp_Object |
| 4 | for 'dragging' member. | 11 | for 'dragging' member. |
| 5 | (struct x_output): Remove set-but-unused leftovers | 12 | (struct x_output): Remove set-but-unused leftovers |
diff --git a/src/buffer.c b/src/buffer.c index 1495bd65de7..c811890aefe 100644 --- a/src/buffer.c +++ b/src/buffer.c | |||
| @@ -3834,7 +3834,8 @@ for the front of the overlay advance when text is inserted there | |||
| 3834 | The fifth arg REAR-ADVANCE, if non-nil, makes the marker | 3834 | The fifth arg REAR-ADVANCE, if non-nil, makes the marker |
| 3835 | for the rear of the overlay advance when text is inserted there | 3835 | for the rear of the overlay advance when text is inserted there |
| 3836 | \(which means the text *is* included in the overlay). */) | 3836 | \(which means the text *is* included in the overlay). */) |
| 3837 | (Lisp_Object beg, Lisp_Object end, Lisp_Object buffer, Lisp_Object front_advance, Lisp_Object rear_advance) | 3837 | (Lisp_Object beg, Lisp_Object end, Lisp_Object buffer, |
| 3838 | Lisp_Object front_advance, Lisp_Object rear_advance) | ||
| 3838 | { | 3839 | { |
| 3839 | Lisp_Object overlay; | 3840 | Lisp_Object overlay; |
| 3840 | struct buffer *b; | 3841 | struct buffer *b; |
| @@ -3843,12 +3844,11 @@ for the rear of the overlay advance when text is inserted there | |||
| 3843 | XSETBUFFER (buffer, current_buffer); | 3844 | XSETBUFFER (buffer, current_buffer); |
| 3844 | else | 3845 | else |
| 3845 | CHECK_BUFFER (buffer); | 3846 | CHECK_BUFFER (buffer); |
| 3846 | if (MARKERP (beg) | 3847 | |
| 3847 | && ! EQ (Fmarker_buffer (beg), buffer)) | 3848 | if (MARKERP (beg) && !EQ (Fmarker_buffer (beg), buffer)) |
| 3848 | error ("Marker points into wrong buffer"); | 3849 | signal_error ("Marker points into wrong buffer", beg); |
| 3849 | if (MARKERP (end) | 3850 | if (MARKERP (end) && !EQ (Fmarker_buffer (end), buffer)) |
| 3850 | && ! EQ (Fmarker_buffer (end), buffer)) | 3851 | signal_error ("Marker points into wrong buffer", end); |
| 3851 | error ("Marker points into wrong buffer"); | ||
| 3852 | 3852 | ||
| 3853 | CHECK_NUMBER_COERCE_MARKER (beg); | 3853 | CHECK_NUMBER_COERCE_MARKER (beg); |
| 3854 | CHECK_NUMBER_COERCE_MARKER (end); | 3854 | CHECK_NUMBER_COERCE_MARKER (end); |
| @@ -3974,12 +3974,10 @@ buffer. */) | |||
| 3974 | if (NILP (Fbuffer_live_p (buffer))) | 3974 | if (NILP (Fbuffer_live_p (buffer))) |
| 3975 | error ("Attempt to move overlay to a dead buffer"); | 3975 | error ("Attempt to move overlay to a dead buffer"); |
| 3976 | 3976 | ||
| 3977 | if (MARKERP (beg) | 3977 | if (MARKERP (beg) && !EQ (Fmarker_buffer (beg), buffer)) |
| 3978 | && ! EQ (Fmarker_buffer (beg), buffer)) | 3978 | signal_error ("Marker points into wrong buffer", beg); |
| 3979 | error ("Marker points into wrong buffer"); | 3979 | if (MARKERP (end) && !EQ (Fmarker_buffer (end), buffer)) |
| 3980 | if (MARKERP (end) | 3980 | signal_error ("Marker points into wrong buffer", end); |
| 3981 | && ! EQ (Fmarker_buffer (end), buffer)) | ||
| 3982 | error ("Marker points into wrong buffer"); | ||
| 3983 | 3981 | ||
| 3984 | CHECK_NUMBER_COERCE_MARKER (beg); | 3982 | CHECK_NUMBER_COERCE_MARKER (beg); |
| 3985 | CHECK_NUMBER_COERCE_MARKER (end); | 3983 | CHECK_NUMBER_COERCE_MARKER (end); |
diff --git a/src/intervals.c b/src/intervals.c index 671b2a3d527..ded536ca3c8 100644 --- a/src/intervals.c +++ b/src/intervals.c | |||
| @@ -1827,7 +1827,7 @@ void | |||
| 1827 | set_point_from_marker (Lisp_Object marker) | 1827 | set_point_from_marker (Lisp_Object marker) |
| 1828 | { | 1828 | { |
| 1829 | if (XMARKER (marker)->buffer != current_buffer) | 1829 | if (XMARKER (marker)->buffer != current_buffer) |
| 1830 | error ("Marker points into wrong buffer"); | 1830 | signal_error ("Marker points into wrong buffer", marker); |
| 1831 | set_point_both | 1831 | set_point_both |
| 1832 | (clip_to_bounds (BEGV, marker_position (marker), ZV), | 1832 | (clip_to_bounds (BEGV, marker_position (marker), ZV), |
| 1833 | clip_to_bounds (BEGV_BYTE, marker_byte_position (marker), ZV_BYTE)); | 1833 | clip_to_bounds (BEGV_BYTE, marker_byte_position (marker), ZV_BYTE)); |
diff --git a/src/print.c b/src/print.c index 80f1bb6beb4..4ad34534da3 100644 --- a/src/print.c +++ b/src/print.c | |||
| @@ -124,7 +124,8 @@ bool print_output_debug_flag EXTERNALLY_VISIBLE = 1; | |||
| 124 | set_buffer_internal (XMARKER (printcharfun)->buffer); \ | 124 | set_buffer_internal (XMARKER (printcharfun)->buffer); \ |
| 125 | marker_pos = marker_position (printcharfun); \ | 125 | marker_pos = marker_position (printcharfun); \ |
| 126 | if (marker_pos < BEGV || marker_pos > ZV) \ | 126 | if (marker_pos < BEGV || marker_pos > ZV) \ |
| 127 | error ("Marker is outside the accessible part of the buffer"); \ | 127 | signal_error ("Marker is outside the accessible " \ |
| 128 | "part of the buffer", printcharfun); \ | ||
| 128 | old_point = PT; \ | 129 | old_point = PT; \ |
| 129 | old_point_byte = PT_BYTE; \ | 130 | old_point_byte = PT_BYTE; \ |
| 130 | SET_PT_BOTH (marker_pos, \ | 131 | SET_PT_BOTH (marker_pos, \ |
| @@ -136,10 +137,10 @@ bool print_output_debug_flag EXTERNALLY_VISIBLE = 1; | |||
| 136 | if (NILP (printcharfun)) \ | 137 | if (NILP (printcharfun)) \ |
| 137 | { \ | 138 | { \ |
| 138 | Lisp_Object string; \ | 139 | Lisp_Object string; \ |
| 139 | if (NILP (BVAR (current_buffer, enable_multibyte_characters)) \ | 140 | if (NILP (BVAR (current_buffer, enable_multibyte_characters)) \ |
| 140 | && ! print_escape_multibyte) \ | 141 | && ! print_escape_multibyte) \ |
| 141 | specbind (Qprint_escape_multibyte, Qt); \ | 142 | specbind (Qprint_escape_multibyte, Qt); \ |
| 142 | if (! NILP (BVAR (current_buffer, enable_multibyte_characters)) \ | 143 | if (! NILP (BVAR (current_buffer, enable_multibyte_characters)) \ |
| 143 | && ! print_escape_nonascii) \ | 144 | && ! print_escape_nonascii) \ |
| 144 | specbind (Qprint_escape_nonascii, Qt); \ | 145 | specbind (Qprint_escape_nonascii, Qt); \ |
| 145 | if (print_buffer != 0) \ | 146 | if (print_buffer != 0) \ |
| @@ -166,7 +167,7 @@ bool print_output_debug_flag EXTERNALLY_VISIBLE = 1; | |||
| 166 | if (NILP (printcharfun)) \ | 167 | if (NILP (printcharfun)) \ |
| 167 | { \ | 168 | { \ |
| 168 | if (print_buffer_pos != print_buffer_pos_byte \ | 169 | if (print_buffer_pos != print_buffer_pos_byte \ |
| 169 | && NILP (BVAR (current_buffer, enable_multibyte_characters))) \ | 170 | && NILP (BVAR (current_buffer, enable_multibyte_characters)))\ |
| 170 | { \ | 171 | { \ |
| 171 | unsigned char *temp = alloca (print_buffer_pos + 1); \ | 172 | unsigned char *temp = alloca (print_buffer_pos + 1); \ |
| 172 | copy_text ((unsigned char *) print_buffer, temp, \ | 173 | copy_text ((unsigned char *) print_buffer, temp, \ |