aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Antipov2012-06-25 14:16:11 +0400
committerDmitry Antipov2012-06-25 14:16:11 +0400
commitafa2ffd81eeb31b2594c96556768ca17c3bb3cfc (patch)
treee2eb949fa67223e9283aa29447786b28c9e7ac27
parent4495ff3898b49713c89f797d7e9c4153a40a3cde (diff)
downloademacs-afa2ffd81eeb31b2594c96556768ca17c3bb3cfc.tar.gz
emacs-afa2ffd81eeb31b2594c96556768ca17c3bb3cfc.zip
* xfns.c (xic_create_fontsetname): Remove redundant calls
to memset.
-rw-r--r--src/ChangeLog5
-rw-r--r--src/xfns.c20
2 files changed, 12 insertions, 13 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index 95c938d7a68..1430c479c97 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
12012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * xfns.c (xic_create_fontsetname): Remove redundant calls
4 to memset.
5
12012-06-25 Paul Eggert <eggert@cs.ucla.edu> 62012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2 7
3 * gtkutil.c (get_utf8_string): Remove redundant assignment. 8 * gtkutil.c (get_utf8_string): Remove redundant assignment.
diff --git a/src/xfns.c b/src/xfns.c
index b5d0102486c..575d9434c76 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -1881,10 +1881,9 @@ xic_create_fontsetname (const char *base_fontname, int motif)
1881 1881
1882 /* Make a fontset name from the base font name. */ 1882 /* Make a fontset name from the base font name. */
1883 if (xic_default_fontset == base_fontname) 1883 if (xic_default_fontset == base_fontname)
1884 { /* There is no base font name, use the default. */ 1884 {
1885 ptrdiff_t len = strlen (base_fontname) + 2; 1885 /* There is no base font name, use the default. */
1886 fontsetname = xmalloc (len); 1886 fontsetname = xmalloc (strlen (base_fontname) + 2);
1887 memset (fontsetname, 0, len);
1888 strcpy (fontsetname, base_fontname); 1887 strcpy (fontsetname, base_fontname);
1889 } 1888 }
1890 else 1889 else
@@ -1900,13 +1899,12 @@ xic_create_fontsetname (const char *base_fontname, int motif)
1900 for (i = 0; *p; p++) 1899 for (i = 0; *p; p++)
1901 if (*p == '-') i++; 1900 if (*p == '-') i++;
1902 if (i != 14) 1901 if (i != 14)
1903 { /* As the font name doesn't conform to XLFD, we can't 1902 {
1903 /* As the font name doesn't conform to XLFD, we can't
1904 modify it to generalize it to allcs and allfamilies. 1904 modify it to generalize it to allcs and allfamilies.
1905 Use the specified font plus the default. */ 1905 Use the specified font plus the default. */
1906 ptrdiff_t len = 1906 fontsetname = xmalloc (strlen (base_fontname)
1907 strlen (base_fontname) + strlen (xic_default_fontset) + 3; 1907 + strlen (xic_default_fontset) + 3);
1908 fontsetname = xmalloc (len);
1909 memset (fontsetname, 0, len);
1910 strcpy (fontsetname, base_fontname); 1908 strcpy (fontsetname, base_fontname);
1911 strcat (fontsetname, sep); 1909 strcat (fontsetname, sep);
1912 strcat (fontsetname, xic_default_fontset); 1910 strcat (fontsetname, xic_default_fontset);
@@ -1956,7 +1954,6 @@ xic_create_fontsetname (const char *base_fontname, int motif)
1956 /* Build the font spec that matches all charsets. */ 1954 /* Build the font spec that matches all charsets. */
1957 len = p - base_fontname + strlen (allcs) + 1; 1955 len = p - base_fontname + strlen (allcs) + 1;
1958 font_allcs = (char *) alloca (len); 1956 font_allcs = (char *) alloca (len);
1959 memset (font_allcs, 0, len);
1960 memcpy (font_allcs, base_fontname, p - base_fontname); 1957 memcpy (font_allcs, base_fontname, p - base_fontname);
1961 strcat (font_allcs, allcs); 1958 strcat (font_allcs, allcs);
1962 1959
@@ -1964,7 +1961,6 @@ xic_create_fontsetname (const char *base_fontname, int motif)
1964 add-styles. */ 1961 add-styles. */
1965 len = p - p1 + strlen (allcs) + strlen (allfamilies) + 1; 1962 len = p - p1 + strlen (allcs) + strlen (allfamilies) + 1;
1966 font_allfamilies = (char *) alloca (len); 1963 font_allfamilies = (char *) alloca (len);
1967 memset (font_allfamilies, 0, len);
1968 strcpy (font_allfamilies, allfamilies); 1964 strcpy (font_allfamilies, allfamilies);
1969 memcpy (font_allfamilies + strlen (allfamilies), p1, p - p1); 1965 memcpy (font_allfamilies + strlen (allfamilies), p1, p - p1);
1970 strcat (font_allfamilies, allcs); 1966 strcat (font_allfamilies, allcs);
@@ -1972,7 +1968,6 @@ xic_create_fontsetname (const char *base_fontname, int motif)
1972 /* Build the font spec that matches all. */ 1968 /* Build the font spec that matches all. */
1973 len = p - p2 + strlen (allcs) + strlen (all) + strlen (allfamilies) + 1; 1969 len = p - p2 + strlen (allcs) + strlen (all) + strlen (allfamilies) + 1;
1974 font_all = (char *) alloca (len); 1970 font_all = (char *) alloca (len);
1975 memset (font_all, 0, len);
1976 strcpy (font_all, allfamilies); 1971 strcpy (font_all, allfamilies);
1977 strcat (font_all, all); 1972 strcat (font_all, all);
1978 memcpy (font_all + strlen (all) + strlen (allfamilies), p2, p - p2); 1973 memcpy (font_all + strlen (all) + strlen (allfamilies), p2, p - p2);
@@ -1982,7 +1977,6 @@ xic_create_fontsetname (const char *base_fontname, int motif)
1982 len = strlen (base_fontname) + strlen (font_allcs) 1977 len = strlen (base_fontname) + strlen (font_allcs)
1983 + strlen (font_allfamilies) + strlen (font_all) + 5; 1978 + strlen (font_allfamilies) + strlen (font_all) + 5;
1984 fontsetname = xmalloc (len); 1979 fontsetname = xmalloc (len);
1985 memset (fontsetname, 0, len);
1986 strcpy (fontsetname, base_fontname); 1980 strcpy (fontsetname, base_fontname);
1987 strcat (fontsetname, sep); 1981 strcat (fontsetname, sep);
1988 strcat (fontsetname, font_allcs); 1982 strcat (fontsetname, font_allcs);