aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChong Yidong2010-10-18 13:28:20 -0400
committerChong Yidong2010-10-18 13:28:20 -0400
commita8c41b4c0d3b0a3e87f17bbcdd8ac12dae296b3a (patch)
tree0e70199c085f112c0deb3d369db6bd737f7d04d2
parent5419963b85522629c972baba98c7e2cfef4bb014 (diff)
downloademacs-a8c41b4c0d3b0a3e87f17bbcdd8ac12dae296b3a.tar.gz
emacs-a8c41b4c0d3b0a3e87f17bbcdd8ac12dae296b3a.zip
Don't allow functions that display messages in unsafep.
* emacs-lisp/unsafep.el: Don't mark functions that display messages as safe. Suggested by Johan Bockgård.
-rw-r--r--lisp/ChangeLog5
-rw-r--r--lisp/emacs-lisp/unsafep.el8
2 files changed, 8 insertions, 5 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 7c560c33b9d..eb26c3923bf 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
12010-10-18 Chong Yidong <cyd@stupidchicken.com>
2
3 * emacs-lisp/unsafep.el: Don't mark functions that display
4 messages as safe. Suggested by Johan Bockgård.
5
12010-10-17 Stefan Monnier <monnier@iro.umontreal.ca> 62010-10-17 Stefan Monnier <monnier@iro.umontreal.ca>
2 7
3 * minibuffer.el (completion--replace): Move point where it belongs 8 * minibuffer.el (completion--replace): Move point where it belongs
diff --git a/lisp/emacs-lisp/unsafep.el b/lisp/emacs-lisp/unsafep.el
index 851a1f7652b..a62f8de4010 100644
--- a/lisp/emacs-lisp/unsafep.el
+++ b/lisp/emacs-lisp/unsafep.el
@@ -101,15 +101,13 @@ in the parse.")
101(dolist (x '(;;Special forms 101(dolist (x '(;;Special forms
102 and catch if or prog1 prog2 progn while unwind-protect 102 and catch if or prog1 prog2 progn while unwind-protect
103 ;;Safe subrs that have some side-effects 103 ;;Safe subrs that have some side-effects
104 ding error message minibuffer-message random read-minibuffer 104 ding error random signal sleep-for string-match throw
105 signal sleep-for string-match throw y-or-n-p yes-or-no-p
106 ;;Defsubst functions from subr.el 105 ;;Defsubst functions from subr.el
107 caar cadr cdar cddr 106 caar cadr cdar cddr
108 ;;Macros from subr.el 107 ;;Macros from subr.el
109 save-match-data unless when with-temp-message 108 save-match-data unless when
110 ;;Functions from subr.el that have side effects 109 ;;Functions from subr.el that have side effects
111 read-passwd split-string replace-regexp-in-string 110 split-string replace-regexp-in-string play-sound-file))
112 play-sound-file))
113 (put x 'safe-function t)) 111 (put x 'safe-function t))
114 112
115;;;###autoload 113;;;###autoload