(thumbs-call-convert): Use call-process directly

with thumbs-conversion-program instead of through shell-file-name
for better error reporting when program is missing.

1 files changed, 6 insertions, 9 deletions

diff --git a/lisp/thumbs.el b/lisp/thumbs.el
index 9d8b289cbe9..395145fd53b 100644
--- a/lisp/thumbs.el
+++ b/lisp/thumbs.el
@@ -248,15 +248,12 @@ ARG any arguments to the ACTION command,
 OUTPUT-FORMAT is the file format to output (default is jpeg),
 ACTION-PREFIX is the symbol to place before the ACTION command
               (defaults to '-' but can sometimes be '+')."
-  (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\""
-                         thumbs-conversion-program
-                         (or action-prefix "-")
-                         action
-                         (or arg "")
-                         filein
-                         (or output-format "jpeg")
-                         fileout)))
-    (call-process shell-file-name nil nil nil shell-command-switch command)))
+  (call-process thumbs-conversion-program nil nil nil
+                (or action-prefix "-")
+                action
+                (or arg "")
+                filein
+                (format "%s:%s" (or output-format "jpeg") fileout)))
 
 (defun thumbs-new-image-size (s increment)
   "New image (a cons of width x height)."