(hi-yellow, hi-pink, hi-green, hi-blue): Force the foreground color to

  black if the default background is dark.

2 files changed, 14 insertions, 5 deletions

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index dd0dd24005e..59e9c53431c 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2000-08-17  Miles Bader  <miles@gnu.org>
+
+        * hi-lock.el (hi-yellow, hi-pink, hi-green, hi-blue): Force the
+        foreground color to black if the background is dark.
+
 2000-08-16  Stefan Monnier  <monnier@cs.yale.edu>
 
         * loadhist.el (unload-feature): Typo.
@@ -79,7 +84,7 @@
 
 2000-08-16  Sam Steingold  <sds@gnu.org>
 
-        * buff-menu.el (list-buffers-noselect): Use `dolist' instead of
+        * buff-menu.el (list-buffers-noselect): Use `dolist' instead Of
         `while'; use `with-current-buffer' instead of `save-excursion'.
         Removed unnecessary kludges now that "*Buffer List*" is excluded.
 
diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index f2a77b620c7..c56c68c7746 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -119,22 +119,26 @@ calls."
   :group 'hi-lock-interactive-text-highlighting)
 
 (defface hi-yellow
-  '((t (:background "yellow")))
+  '((((background dark)) (:background "yellow" :foreground "black"))
+    (t (:background "yellow")))
   "Default face for hi-lock mode."
   :group 'hi-lock-faces)
 
 (defface hi-pink
-  '((t (:background "pink")))
+  '(((background dark) (:background "pink" :foreground "black"))
+    (t (:background "pink")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
 (defface hi-green
-  '((t (:background "green")))
+  '(((background dark) (:background "green" :foreground "black"))
+    (t (:background "green")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)
 
 (defface hi-blue
-  '((t (:background "light blue")))
+  '(((background dark) (:background "light blue" :foreground "black"))
+    (t (:background "light blue")))
   "Face for hi-lock mode."
   :group 'hi-lock-faces)