diff options
| author | Stefan Monnier | 2014-04-21 17:43:17 -0400 |
|---|---|---|
| committer | Stefan Monnier | 2014-04-21 17:43:17 -0400 |
| commit | 9c10436944ee2d27a19bf0220828db5dc4aeca1f (patch) | |
| tree | 50746af3320ff1f7451e827b84c900cc4081dde5 | |
| parent | 622eef687cedb8fbaf8ca529239f46968c2487f7 (diff) | |
| download | emacs-9c10436944ee2d27a19bf0220828db5dc4aeca1f.tar.gz emacs-9c10436944ee2d27a19bf0220828db5dc4aeca1f.zip | |
* lisp/dframe.el (dframe-get-focus): Remove `hook' argument.
* lisp/speedbar.el (speedbar-get-focus): Run the "hook" afterwards instead.
Fixes: debbugs:17311
| -rw-r--r-- | lisp/ChangeLog | 3 | ||||
| -rw-r--r-- | lisp/dframe.el | 9 | ||||
| -rw-r--r-- | lisp/speedbar.el | 6 |
3 files changed, 9 insertions, 9 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index d25bf4b7597..169e6bce49d 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,5 +1,8 @@ | |||
| 1 | 2014-04-21 Stefan Monnier <monnier@iro.umontreal.ca> | 1 | 2014-04-21 Stefan Monnier <monnier@iro.umontreal.ca> |
| 2 | 2 | ||
| 3 | * dframe.el (dframe-get-focus): Remove `hook' argument (bug#17311). | ||
| 4 | * speedbar.el (speedbar-get-focus): Run the "hook" afterwards instead. | ||
| 5 | |||
| 3 | * emacs-lisp/cl-macs.el (cl--loop-let): Avoid `nil' as var name. | 6 | * emacs-lisp/cl-macs.el (cl--loop-let): Avoid `nil' as var name. |
| 4 | 7 | ||
| 5 | 2014-04-21 Michael Albinus <michael.albinus@gmx.de> | 8 | 2014-04-21 Michael Albinus <michael.albinus@gmx.de> |
diff --git a/lisp/dframe.el b/lisp/dframe.el index 872b922d783..90edacbf416 100644 --- a/lisp/dframe.el +++ b/lisp/dframe.el | |||
| @@ -606,13 +606,12 @@ Argument E is the event deleting the frame." | |||
| 606 | 606 | ||
| 607 | ;;; Utilities | 607 | ;;; Utilities |
| 608 | ;; | 608 | ;; |
| 609 | (defun dframe-get-focus (frame-var activator &optional hook) | 609 | (defun dframe-get-focus (frame-var activator) |
| 610 | "Change frame focus to or from a dedicated frame. | 610 | "Change frame focus to or from a dedicated frame. |
| 611 | If the selected frame is not in the symbol FRAME-VAR, then FRAME-VAR | 611 | If the selected frame is not in the symbol FRAME-VAR, then FRAME-VAR |
| 612 | frame is selected. If the FRAME-VAR is active, then select the | 612 | frame is selected. If the FRAME-VAR is active, then select the |
| 613 | attached frame. If FRAME-VAR is nil, ACTIVATOR is called to | 613 | attached frame. If FRAME-VAR is nil, ACTIVATOR is called to |
| 614 | created it. HOOK is an optional hook to run when | 614 | created it." |
| 615 | selecting FRAME-VAR." | ||
| 616 | (interactive) | 615 | (interactive) |
| 617 | (if (eq (selected-frame) (symbol-value frame-var)) | 616 | (if (eq (selected-frame) (symbol-value frame-var)) |
| 618 | (if (frame-live-p dframe-attached-frame) | 617 | (if (frame-live-p dframe-attached-frame) |
| @@ -623,9 +622,7 @@ selecting FRAME-VAR." | |||
| 623 | ;; go there | 622 | ;; go there |
| 624 | (select-frame (symbol-value frame-var)) | 623 | (select-frame (symbol-value frame-var)) |
| 625 | ) | 624 | ) |
| 626 | (other-frame 0) | 625 | (other-frame 0)) |
| 627 | ;; If updates are off, then refresh the frame (they want it now...) | ||
| 628 | (run-hooks hook)) | ||
| 629 | 626 | ||
| 630 | 627 | ||
| 631 | (defun dframe-close-frame () | 628 | (defun dframe-close-frame () |
diff --git a/lisp/speedbar.el b/lisp/speedbar.el index c425d777306..084767893e4 100644 --- a/lisp/speedbar.el +++ b/lisp/speedbar.el | |||
| @@ -1076,9 +1076,9 @@ If the selected frame is not speedbar, then speedbar frame is | |||
| 1076 | selected. If the speedbar frame is active, then select the attached frame." | 1076 | selected. If the speedbar frame is active, then select the attached frame." |
| 1077 | (interactive) | 1077 | (interactive) |
| 1078 | (speedbar-reset-scanners) | 1078 | (speedbar-reset-scanners) |
| 1079 | (dframe-get-focus 'speedbar-frame 'speedbar-frame-mode | 1079 | (dframe-get-focus 'speedbar-frame 'speedbar-frame-mode) |
| 1080 | (lambda () (let ((speedbar-update-flag t)) | 1080 | (let ((speedbar-update-flag t)) |
| 1081 | (speedbar-timer-fn))))) | 1081 | (speedbar-timer-fn))) |
| 1082 | 1082 | ||
| 1083 | (defsubst speedbar-frame-width () | 1083 | (defsubst speedbar-frame-width () |
| 1084 | "Return the width of the speedbar frame in characters. | 1084 | "Return the width of the speedbar frame in characters. |