aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Monnier2010-11-08 15:53:42 -0500
committerStefan Monnier2010-11-08 15:53:42 -0500
commit9bdba5f56b982e395f072ae3dbaf7d063f92366e (patch)
treedb47364e825e20c7e589e651aca9bb6a46ab7f1e
parent73525e726cd917645950e185cbabafda00bc0635 (diff)
downloademacs-9bdba5f56b982e395f072ae3dbaf7d063f92366e.tar.gz
emacs-9bdba5f56b982e395f072ae3dbaf7d063f92366e.zip
* lisp/minibuffer.el (minibuffer-completion-help): Specify the end of the
completion field. Fixes: debbugs:7211
-rw-r--r--lisp/ChangeLog3
-rw-r--r--lisp/minibuffer.el13
2 files changed, 11 insertions, 5 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 0a38a9a6c9f..f170bda4fab 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,8 @@
12010-11-08 Stefan Monnier <monnier@iro.umontreal.ca> 12010-11-08 Stefan Monnier <monnier@iro.umontreal.ca>
2 2
3 * minibuffer.el (minibuffer-completion-help): Specify the end of the
4 completion field (bug#7211).
5
3 * progmodes/python.el (python-font-lock-syntactic-keywords): (bug#7322) 6 * progmodes/python.el (python-font-lock-syntactic-keywords): (bug#7322)
4 Fix handling of backslash escapes. 7 Fix handling of backslash escapes.
5 (python-quote-syntax): Adjust accordingly. 8 (python-quote-syntax): Adjust accordingly.
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index bc5a1d2e807..006e873ac57 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -41,7 +41,7 @@
41;; provide the start info but not the end info in 41;; provide the start info but not the end info in
42;; completion-base-position. 42;; completion-base-position.
43;; - quoting is problematic. E.g. the double-dollar quoting used in 43;; - quoting is problematic. E.g. the double-dollar quoting used in
44;; substitie-in-file-name (and hence read-file-name-internal) bumps 44;; substitute-in-file-name (and hence read-file-name-internal) bumps
45;; into various bugs: 45;; into various bugs:
46;; - choose-completion doesn't know how to quote the text it inserts. 46;; - choose-completion doesn't know how to quote the text it inserts.
47;; E.g. it fails to double the dollars in file-name completion, or 47;; E.g. it fails to double the dollars in file-name completion, or
@@ -1075,6 +1075,7 @@ variables.")
1075 (interactive) 1075 (interactive)
1076 (message "Making completion list...") 1076 (message "Making completion list...")
1077 (lexical-let* ((start (field-beginning)) 1077 (lexical-let* ((start (field-beginning))
1078 (end (field-end))
1078 (string (field-string)) 1079 (string (field-string))
1079 (completions (completion-all-completions 1080 (completions (completion-all-completions
1080 string 1081 string
@@ -1106,10 +1107,12 @@ variables.")
1106 completions))) 1107 completions)))
1107 (with-current-buffer standard-output 1108 (with-current-buffer standard-output
1108 (set (make-local-variable 'completion-base-position) 1109 (set (make-local-variable 'completion-base-position)
1109 ;; FIXME: We should provide the END part as well, but 1110 (list (+ start base-size)
1110 ;; currently completion-all-completions does not give 1111 ;; FIXME: We should pay attention to completion
1111 ;; us the necessary information. 1112 ;; boundaries here, but currently
1112 (list (+ start base-size) nil))) 1113 ;; completion-all-completions does not give us the
1114 ;; necessary information.
1115 end)))
1113 (display-completion-list completions))) 1116 (display-completion-list completions)))
1114 1117
1115 ;; If there are no completions, or if the current input is already the 1118 ;; If there are no completions, or if the current input is already the