diff options
| author | Mark Oteiza | 2017-09-13 10:19:59 -0400 |
|---|---|---|
| committer | Mark Oteiza | 2017-09-13 10:19:59 -0400 |
| commit | 9a8bbb9d5d3a55d4a31658e188f305669bd26e79 (patch) | |
| tree | 86e8eccc65c556d00d1ff1f26d915b45b76af996 | |
| parent | d532caaeee1d604e72e75072310c4447b694a070 (diff) | |
| download | emacs-9a8bbb9d5d3a55d4a31658e188f305669bd26e79.tar.gz emacs-9a8bbb9d5d3a55d4a31658e188f305669bd26e79.zip | |
; Fix previous commit
Removing extraneous code, thanks to Michael Heerdegen.
* lisp/emacs-lisp/subr-x.el (internal--listify): Remove latter
condition which always evaluates to t.
(internal--build-binding-value-form): Remove dead code.
| -rw-r--r-- | lisp/emacs-lisp/subr-x.el | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/lisp/emacs-lisp/subr-x.el b/lisp/emacs-lisp/subr-x.el index 3ea01065c8b..ba0ab6cb4c7 100644 --- a/lisp/emacs-lisp/subr-x.el +++ b/lisp/emacs-lisp/subr-x.el | |||
| @@ -87,9 +87,7 @@ threading." | |||
| 87 | If ELT is of the form ((EXPR)), listify (EXPR) with a dummy symbol." | 87 | If ELT is of the form ((EXPR)), listify (EXPR) with a dummy symbol." |
| 88 | (cond | 88 | (cond |
| 89 | ((symbolp elt) (list elt elt)) | 89 | ((symbolp elt) (list elt elt)) |
| 90 | ((and (null (cdr elt)) | 90 | ((null (cdr elt)) |
| 91 | (let ((form (car elt))) | ||
| 92 | (or (listp form) (atom form)))) | ||
| 93 | (list (make-symbol "s") (car elt))) | 91 | (list (make-symbol "s") (car elt))) |
| 94 | (t elt))) | 92 | (t elt))) |
| 95 | 93 | ||
| @@ -104,9 +102,7 @@ If ELT is of the form ((EXPR)), listify (EXPR) with a dummy symbol." | |||
| 104 | (defsubst internal--build-binding-value-form (binding prev-var) | 102 | (defsubst internal--build-binding-value-form (binding prev-var) |
| 105 | "Build the conditional value form for BINDING using PREV-VAR." | 103 | "Build the conditional value form for BINDING using PREV-VAR." |
| 106 | (let ((var (car binding))) | 104 | (let ((var (car binding))) |
| 107 | (if (and (null (cdr binding)) (atom (car binding)) (not (symbolp (car binding)))) | 105 | `(,var (and ,prev-var ,(cadr binding))))) |
| 108 | `(,var (and ,prev-var ,var)) | ||
| 109 | `(,var (and ,prev-var ,(cadr binding)))))) | ||
| 110 | 106 | ||
| 111 | (defun internal--build-binding (binding prev-var) | 107 | (defun internal--build-binding (binding prev-var) |
| 112 | "Check and build a single BINDING with PREV-VAR." | 108 | "Check and build a single BINDING with PREV-VAR." |