aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Monnier2013-11-17 18:11:27 -0500
committerStefan Monnier2013-11-17 18:11:27 -0500
commit986545b57f27403e9f8729bb6252957bc8baf2ea (patch)
tree9f16118056d5b16b2f674dfcbd2ba6de230c81b1
parent9bc67baa5ad14110529ccfc4dfcb5b41be26be53 (diff)
downloademacs-986545b57f27403e9f8729bb6252957bc8baf2ea.tar.gz
emacs-986545b57f27403e9f8729bb6252957bc8baf2ea.zip
* lisp/emacs-lisp/nadvice.el (remove-function): Align with
add-function's behavior.
-rw-r--r--lisp/ChangeLog3
-rw-r--r--lisp/emacs-lisp/nadvice.el2
2 files changed, 4 insertions, 1 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index f408df795a0..a749f70b4fc 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,8 @@
12013-11-17 Stefan Monnier <monnier@iro.umontreal.ca> 12013-11-17 Stefan Monnier <monnier@iro.umontreal.ca>
2 2
3 * emacs-lisp/nadvice.el (remove-function): Align with
4 add-function's behavior.
5
3 * progmodes/gdb-mi.el: Avoid backtracking in regexp matcher. 6 * progmodes/gdb-mi.el: Avoid backtracking in regexp matcher.
4 (gdb--string-regexp): New constant. 7 (gdb--string-regexp): New constant.
5 (gdb-tooltip-print, gdb-var-evaluate-expression-handler) 8 (gdb-tooltip-print, gdb-var-evaluate-expression-handler)
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 576e72088e9..0352164caf5 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -284,7 +284,7 @@ of the piece of advice."
284 (cond ((eq 'local (car-safe place)) 284 (cond ((eq 'local (car-safe place))
285 (setq place `(advice--buffer-local ,@(cdr place)))) 285 (setq place `(advice--buffer-local ,@(cdr place))))
286 ((symbolp place) 286 ((symbolp place)
287 (error "Use (default-value '%S) or (local '%S)" place place))) 287 (setq place `(default-value ',place))))
288 (gv-letplace (getter setter) place 288 (gv-letplace (getter setter) place
289 (macroexp-let2 nil new `(advice--remove-function ,getter ,function) 289 (macroexp-let2 nil new `(advice--remove-function ,getter ,function)
290 `(unless (eq ,new ,getter) ,(funcall setter new))))) 290 `(unless (eq ,new ,getter) ,(funcall setter new)))))