aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTroy Hinckley2019-01-16 14:47:07 -0800
committerNoam Postavsky2019-04-04 19:39:42 -0400
commit905f6195191a518b7bb2dbdf6eacae41d31fc54e (patch)
tree0f6adb66a97c668469704d7662a3d2c00ffdc45b
parent690c678fb6c1fb5b2f828f9bb90782bd0b01c399 (diff)
downloademacs-905f6195191a518b7bb2dbdf6eacae41d31fc54e.tar.gz
emacs-905f6195191a518b7bb2dbdf6eacae41d31fc54e.zip
Don't check comp-buffer-name-function in derived mode (Bug#34956)
* lisp/progmodes/compile.el (define-compilation-mode): Remove 'compilation-buffer-name-function' from the list of overridden variables to ensure that it is not mistaken for a variable that can be major mode specific. 'compilation-buffer-name-function' is used before the major mode is loaded, therefore overriding it here is ineffectual. Also, the function 'compilation-start' takes an optional argument name-function, so there is already a mechanism to override it.
-rw-r--r--lisp/progmodes/compile.el3
1 files changed, 1 insertions, 2 deletions
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6d5775209c0..1a0d9bdbb70 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2056,8 +2056,7 @@ by replacing the first word, e.g., `compilation-scroll-output' from
2056 (if (boundp 'byte-compile-bound-variables) 2056 (if (boundp 'byte-compile-bound-variables)
2057 (memq (cdr v) byte-compile-bound-variables))) 2057 (memq (cdr v) byte-compile-bound-variables)))
2058 `(set (make-local-variable ',(car v)) ,(cdr v)))) 2058 `(set (make-local-variable ',(car v)) ,(cdr v))))
2059 '(compilation-buffer-name-function 2059 '(compilation-directory-matcher
2060 compilation-directory-matcher
2061 compilation-error 2060 compilation-error
2062 compilation-error-regexp-alist 2061 compilation-error-regexp-alist
2063 compilation-error-regexp-alist-alist 2062 compilation-error-regexp-alist-alist