aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Eggert2013-06-30 08:24:14 -0700
committerPaul Eggert2013-06-30 08:24:14 -0700
commit8f5f35ccca84dd9d518bae3bb7ff4134d603b96f (patch)
treea1a003ef6fb5c2875275b76cb04d8688bca92b42
parente6c6c8c7748471aec72f2e98ade5416e19a20e61 (diff)
downloademacs-8f5f35ccca84dd9d518bae3bb7ff4134d603b96f.tar.gz
emacs-8f5f35ccca84dd9d518bae3bb7ff4134d603b96f.zip
Do not use GTK 3 if it exists but cannot be compiled.
* configure.ac: Leave GTK_OBJ and term_header alone if GTK 3 exists but cannot be compiled. * src/xmenu.c (x_menu_wait_for_event) [!USE_GTK]: * src/xterm.c (x_error_handler) [!USE_GTK]: Do not use GTK 3.
-rw-r--r--ChangeLog6
-rw-r--r--configure.ac5
-rw-r--r--src/ChangeLog5
-rw-r--r--src/xmenu.c2
-rw-r--r--src/xterm.c2
5 files changed, 17 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 8a61bd42712..301e912f4d3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
12013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 Do not use GTK 3 if it exists but cannot be compiled.
4 * configure.ac: Leave GTK_OBJ and term_header alone if GTK 3
5 exists but cannot be compiled.
6
12013-06-27 Juanma Barranquero <lekktu@gmail.com> 72013-06-27 Juanma Barranquero <lekktu@gmail.com>
2 8
3 * Makefile.in (install-arch-indep): Do not create directories passed 9 * Makefile.in (install-arch-indep): Do not create directories passed
diff --git a/configure.ac b/configure.ac
index 3cb7bc701dd..2a7fb209a59 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2078,6 +2078,7 @@ fi
2078 2078
2079HAVE_GTK=no 2079HAVE_GTK=no
2080GTK_OBJ= 2080GTK_OBJ=
2081gtk_term_header=$term_header
2081check_gtk2=no 2082check_gtk2=no
2082gtk3_pkg_errors= 2083gtk3_pkg_errors=
2083if test "${opsys}" != "mingw32"; then 2084if test "${opsys}" != "mingw32"; then
@@ -2094,7 +2095,7 @@ if test "${opsys}" != "mingw32"; then
2094 if test "$pkg_check_gtk" = "yes"; then 2095 if test "$pkg_check_gtk" = "yes"; then
2095 AC_DEFINE(HAVE_GTK3, 1, [Define to 1 if using GTK 3 or later.]) 2096 AC_DEFINE(HAVE_GTK3, 1, [Define to 1 if using GTK 3 or later.])
2096 GTK_OBJ=emacsgtkfixed.o 2097 GTK_OBJ=emacsgtkfixed.o
2097 term_header=gtkutil.h 2098 gtk_term_header=gtkutil.h
2098 USE_GTK_TOOLKIT="GTK3" 2099 USE_GTK_TOOLKIT="GTK3"
2099 if test "x$ac_enable_gtk_deprecation_warnings" = x; then 2100 if test "x$ac_enable_gtk_deprecation_warnings" = x; then
2100 GTK_CFLAGS="$GTK_CFLAGS -DGDK_DISABLE_DEPRECATION_WARNINGS" 2101 GTK_CFLAGS="$GTK_CFLAGS -DGDK_DISABLE_DEPRECATION_WARNINGS"
@@ -2133,6 +2134,7 @@ if test x"$pkg_check_gtk" = xyes; then
2133 GTK_COMPILES=no 2134 GTK_COMPILES=no
2134 AC_CHECK_FUNCS(gtk_main, GTK_COMPILES=yes) 2135 AC_CHECK_FUNCS(gtk_main, GTK_COMPILES=yes)
2135 if test "${GTK_COMPILES}" != "yes"; then 2136 if test "${GTK_COMPILES}" != "yes"; then
2137 GTK_OBJ=
2136 if test "$USE_X_TOOLKIT" != "maybe"; then 2138 if test "$USE_X_TOOLKIT" != "maybe"; then
2137 AC_MSG_ERROR([Gtk+ wanted, but it does not compile, see config.log. Maybe some x11-devel files missing?]); 2139 AC_MSG_ERROR([Gtk+ wanted, but it does not compile, see config.log. Maybe some x11-devel files missing?]);
2138 fi 2140 fi
@@ -2140,6 +2142,7 @@ if test x"$pkg_check_gtk" = xyes; then
2140 HAVE_GTK=yes 2142 HAVE_GTK=yes
2141 AC_DEFINE(USE_GTK, 1, [Define to 1 if using GTK.]) 2143 AC_DEFINE(USE_GTK, 1, [Define to 1 if using GTK.])
2142 GTK_OBJ="gtkutil.o $GTK_OBJ" 2144 GTK_OBJ="gtkutil.o $GTK_OBJ"
2145 term_header=$gtk_term_header
2143 USE_X_TOOLKIT=none 2146 USE_X_TOOLKIT=none
2144 if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then 2147 if "$PKG_CONFIG" --atleast-version=2.10 gtk+-2.0; then
2145 : 2148 :
diff --git a/src/ChangeLog b/src/ChangeLog
index ad4b0d72400..fa44810773c 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,10 @@
12013-06-30 Paul Eggert <eggert@cs.ucla.edu> 12013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2 2
3 Do not use GTK 3 if it exists but cannot be compiled.
4 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
5 * xterm.c (x_error_handler) [!USE_GTK]:
6 Do not use GTK 3.
7
3 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753). 8 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
4 9
52013-06-30 Eli Zaretskii <eliz@gnu.org> 102013-06-30 Eli Zaretskii <eliz@gnu.org>
diff --git a/src/xmenu.c b/src/xmenu.c
index 9993bd87d5b..48ab3519723 100644
--- a/src/xmenu.c
+++ b/src/xmenu.c
@@ -397,7 +397,7 @@ x_menu_wait_for_event (void *data)
397 else 397 else
398 ntp = &next_time; 398 ntp = &next_time;
399 399
400#ifdef HAVE_GTK3 400#if defined USE_GTK && defined HAVE_GTK3
401 /* Gtk3 have arrows on menus when they don't fit. When the 401 /* Gtk3 have arrows on menus when they don't fit. When the
402 pointer is over an arrow, a timeout scrolls it a bit. Use 402 pointer is over an arrow, a timeout scrolls it a bit. Use
403 xg_select so that timeout gets triggered. */ 403 xg_select so that timeout gets triggered. */
diff --git a/src/xterm.c b/src/xterm.c
index 7505aa3936b..9c868aec392 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -7824,7 +7824,7 @@ static void x_error_quitter (Display *, XErrorEvent *);
7824static int 7824static int
7825x_error_handler (Display *display, XErrorEvent *event) 7825x_error_handler (Display *display, XErrorEvent *event)
7826{ 7826{
7827#ifdef HAVE_GTK3 7827#if defined USE_GTK && defined HAVE_GTK3
7828 if (event->error_code == BadMatch 7828 if (event->error_code == BadMatch
7829 && event->request_code == X_SetInputFocus 7829 && event->request_code == X_SetInputFocus
7830 && event->minor_code == 0) 7830 && event->minor_code == 0)