aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKen Manheimer2011-01-04 14:44:10 -0500
committerKen Manheimer2011-01-04 14:44:10 -0500
commit82b392a452796d5fce78a84544415519c6b032e6 (patch)
tree7372750fff4f3d94d2a9f59fbab2d6e6f6f3825a
parent3f1b6eb290b0631885a40ed034839d3dbc04b121 (diff)
downloademacs-82b392a452796d5fce78a84544415519c6b032e6.tar.gz
emacs-82b392a452796d5fce78a84544415519c6b032e6.zip
Reconcile with changes in line movement behavior for long text lines
that cross more than a single physical window line, ie when truncate-lines is nil. (allout-next-visible-heading): Provide for change in line-move behavior on long lines when truncate-lines is nil. In that case, line-move can wind up on the same textual line when it moves to the next window line, and moving to the bullet position after the move yields zero advancement. Add logic to detect and compensate for the lack of progress. (allout-current-topic-collapsed-p): move-end-of-line respect for field boundaries is different when operating with body lines shorter than window width versus ones greater than window width, which can yield false negatives in this function. Avoid difference by applying move-end-of-line while field-text-motion is inhibited.
-rw-r--r--lisp/allout.el16
1 files changed, 14 insertions, 2 deletions
diff --git a/lisp/allout.el b/lisp/allout.el
index 8bc6b6fb6bb..be7480dd619 100644
--- a/lisp/allout.el
+++ b/lisp/allout.el
@@ -3327,6 +3327,7 @@ Move to buffer limit in indicated direction if headings are exhausted."
3327 (let* ((inhibit-field-text-motion t) 3327 (let* ((inhibit-field-text-motion t)
3328 (backward (if (< arg 0) (setq arg (* -1 arg)))) 3328 (backward (if (< arg 0) (setq arg (* -1 arg))))
3329 (step (if backward -1 1)) 3329 (step (if backward -1 1))
3330 (progress (allout-current-bullet-pos))
3330 prev got) 3331 prev got)
3331 3332
3332 (while (> arg 0) 3333 (while (> arg 0)
@@ -3336,7 +3337,17 @@ Move to buffer limit in indicated direction if headings are exhausted."
3336 ;; Move, skipping over all concealed lines in one fell swoop: 3337 ;; Move, skipping over all concealed lines in one fell swoop:
3337 (prog1 (condition-case nil (or (line-move step) t) 3338 (prog1 (condition-case nil (or (line-move step) t)
3338 (error nil)) 3339 (error nil))
3339 (allout-beginning-of-current-line)) 3340 (allout-beginning-of-current-line)
3341 ;; line-move can wind up on the same line if long.
3342 ;; when moving forward, that would yield no-progress
3343 (when (and (not backward)
3344 (<= (point) progress))
3345 ;; ensure progress by doing line-move from end-of-line:
3346 (end-of-line)
3347 (condition-case nil (or (line-move step) t)
3348 (error nil))
3349 (allout-beginning-of-current-line)
3350 (setq progress (point))))
3340 ;; Deal with apparent header line: 3351 ;; Deal with apparent header line:
3341 (save-match-data 3352 (save-match-data
3342 (if (not (looking-at allout-regexp)) 3353 (if (not (looking-at allout-regexp))
@@ -5074,7 +5085,8 @@ default, they are treated as being uncollapsed."
5074 (and 5085 (and
5075 ;; Is the topic all on one line (allowing for trailing blank line)? 5086 ;; Is the topic all on one line (allowing for trailing blank line)?
5076 (>= (progn (allout-back-to-current-heading) 5087 (>= (progn (allout-back-to-current-heading)
5077 (move-end-of-line 1) 5088 (let ((inhibit-field-text-motion t))
5089 (move-end-of-line 1))
5078 (point)) 5090 (point))
5079 (allout-end-of-current-subtree (not (looking-at "\n\n")))) 5091 (allout-end-of-current-subtree (not (looking-at "\n\n"))))
5080 5092