aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Djärv2004-06-28 12:21:54 +0000
committerJan Djärv2004-06-28 12:21:54 +0000
commit74cdfe05c657fa32b8c34b2322ff8f4b39f325cf (patch)
treeec121d883da5735f6ff46cd9b491ca67fde80a53
parentc0a070c1c665a5ca2c421e3e26cc2457db760920 (diff)
downloademacs-74cdfe05c657fa32b8c34b2322ff8f4b39f325cf.tar.gz
emacs-74cdfe05c657fa32b8c34b2322ff8f4b39f325cf.zip
* gtkutil.c (xg_get_image_for_pixmap): Call g_object_unref on
gpix and gmask just before return to avoid memory leak.
-rw-r--r--src/ChangeLog5
-rw-r--r--src/gtkutil.c6
2 files changed, 8 insertions, 3 deletions
diff --git a/src/ChangeLog b/src/ChangeLog
index 383f479aabd..2b3d33e7d7a 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
12004-06-28 Jan Dj,Ad(Brv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (xg_get_image_for_pixmap): Call g_object_unref on
4 gpix and gmask just before return to avoid memory leak.
5
12004-06-27 Jason Rumney <jasonr@gnu.org> 62004-06-27 Jason Rumney <jasonr@gnu.org>
2 7
3 * w32fns.c (file_dialog_callback): Disable edit control if set 8 * w32fns.c (file_dialog_callback): Disable edit control if set
diff --git a/src/gtkutil.c b/src/gtkutil.c
index 84aa9f46d4d..3c4c06a9a53 100644
--- a/src/gtkutil.c
+++ b/src/gtkutil.c
@@ -308,12 +308,9 @@ xg_get_image_for_pixmap (f, img, widget, old_widget)
308 } 308 }
309 } 309 }
310 310
311 g_object_unref (G_OBJECT (gmask));
312 g_object_unref (G_OBJECT (mask_buf)); 311 g_object_unref (G_OBJECT (mask_buf));
313 } 312 }
314 313
315 g_object_unref (G_OBJECT (gpix));
316
317 if (! old_widget) 314 if (! old_widget)
318 old_widget = GTK_IMAGE (gtk_image_new_from_pixbuf (icon_buf)); 315 old_widget = GTK_IMAGE (gtk_image_new_from_pixbuf (icon_buf));
319 else 316 else
@@ -322,6 +319,9 @@ xg_get_image_for_pixmap (f, img, widget, old_widget)
322 g_object_unref (G_OBJECT (icon_buf)); 319 g_object_unref (G_OBJECT (icon_buf));
323 } 320 }
324 321
322 g_object_unref (G_OBJECT (gpix));
323 if (gmask) g_object_unref (G_OBJECT (gmask));
324
325 return GTK_WIDGET (old_widget); 325 return GTK_WIDGET (old_widget);
326} 326}
327 327