diff options
| author | Rob Browning | 2017-04-24 19:58:45 -0400 |
|---|---|---|
| committer | Glenn Morris | 2017-04-24 19:58:45 -0400 |
| commit | 6e45de6bacc508db11b15b2c8ba86aad8c0570df (patch) | |
| tree | cbdae24913b0c50cd6eb0acc3a480179af028640 | |
| parent | 2d0a3feda61186319b7c834ee08c96926dd7ab92 (diff) | |
| download | emacs-6e45de6bacc508db11b15b2c8ba86aad8c0570df.tar.gz emacs-6e45de6bacc508db11b15b2c8ba86aad8c0570df.zip | |
Remove s_client usage from tls.el
* lisp/net/tls.el (tls-program, tls-checktrust): Remove s_client.
Ref http://bugs.debian.org/766397
http://lists.gnu.org/archive/html/emacs-devel/2014-10/msg00803.html
; Backport this to Emacs 25.3, if there is one
| -rw-r--r-- | lisp/net/tls.el | 17 |
1 files changed, 6 insertions, 11 deletions
diff --git a/lisp/net/tls.el b/lisp/net/tls.el index 2273d1345d5..ab10a9c5f3b 100644 --- a/lisp/net/tls.el +++ b/lisp/net/tls.el | |||
| @@ -78,8 +78,7 @@ and `gnutls-cli' (version 2.0.1) output." | |||
| 78 | 78 | ||
| 79 | (defcustom tls-program | 79 | (defcustom tls-program |
| 80 | '("gnutls-cli --x509cafile %t -p %p %h" | 80 | '("gnutls-cli --x509cafile %t -p %p %h" |
| 81 | "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3" | 81 | "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3") |
| 82 | "openssl s_client -connect %h:%p -no_ssl2 -ign_eof") | ||
| 83 | "List of strings containing commands to start TLS stream to a host. | 82 | "List of strings containing commands to start TLS stream to a host. |
| 84 | Each entry in the list is tried until a connection is successful. | 83 | Each entry in the list is tried until a connection is successful. |
| 85 | %h is replaced with the server hostname, %p with the port to | 84 | %h is replaced with the server hostname, %p with the port to |
| @@ -94,24 +93,21 @@ successful negotiation." | |||
| 94 | '(choice | 93 | '(choice |
| 95 | (const :tag "Default list of commands" | 94 | (const :tag "Default list of commands" |
| 96 | ("gnutls-cli --x509cafile %t -p %p %h" | 95 | ("gnutls-cli --x509cafile %t -p %p %h" |
| 97 | "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3" | 96 | "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3")) |
| 98 | "openssl s_client -CAfile %t -connect %h:%p -no_ssl2 -ign_eof")) | ||
| 99 | (list :tag "Choose commands" | 97 | (list :tag "Choose commands" |
| 100 | :value | 98 | :value |
| 101 | ("gnutls-cli --x509cafile %t -p %p %h" | 99 | ("gnutls-cli --x509cafile %t -p %p %h" |
| 102 | "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3" | 100 | "gnutls-cli --x509cafile %t -p %p %h --protocols ssl3") |
| 103 | "openssl s_client -connect %h:%p -no_ssl2 -ign_eof") | ||
| 104 | (set :inline t | 101 | (set :inline t |
| 105 | ;; FIXME: add brief `:tag "..."' descriptions. | 102 | ;; FIXME: add brief `:tag "..."' descriptions. |
| 106 | ;; (repeat :inline t :tag "Other" (string)) | 103 | ;; (repeat :inline t :tag "Other" (string)) |
| 107 | ;; No trust check: | 104 | ;; No trust check: |
| 108 | (const "gnutls-cli --insecure -p %p %h") | 105 | (const "gnutls-cli --insecure -p %p %h") |
| 109 | (const "gnutls-cli --insecure -p %p %h --protocols ssl3") | 106 | (const "gnutls-cli --insecure -p %p %h --protocols ssl3")) |
| 110 | (const "openssl s_client -connect %h:%p -no_ssl2 -ign_eof")) | ||
| 111 | (repeat :inline t :tag "Other" (string))) | 107 | (repeat :inline t :tag "Other" (string))) |
| 112 | (list :tag "List of commands" | 108 | (list :tag "List of commands" |
| 113 | (repeat :tag "Command" (string)))) | 109 | (repeat :tag "Command" (string)))) |
| 114 | :version "22.1" | 110 | :version "26.1" ; remove s_client |
| 115 | :group 'tls) | 111 | :group 'tls) |
| 116 | 112 | ||
| 117 | (defcustom tls-process-connection-type nil | 113 | (defcustom tls-process-connection-type nil |
| @@ -138,8 +134,7 @@ consider trustworthy, e.g.: | |||
| 138 | 134 | ||
| 139 | \(setq tls-program | 135 | \(setq tls-program |
| 140 | \\='(\"gnutls-cli --x509cafile /etc/ssl/certs/ca-certificates.crt -p %p %h\" | 136 | \\='(\"gnutls-cli --x509cafile /etc/ssl/certs/ca-certificates.crt -p %p %h\" |
| 141 | \"gnutls-cli --x509cafile /etc/ssl/certs/ca-certificates.crt -p %p %h --protocols ssl3\" | 137 | \"gnutls-cli --x509cafile /etc/ssl/certs/ca-certificates.crt -p %p %h --protocols ssl3\"))" |
| 142 | \"openssl s_client -connect %h:%p -CAfile /etc/ssl/certs/ca-certificates.crt -no_ssl2 -ign_eof\"))" | ||
| 143 | :type '(choice (const :tag "Always" t) | 138 | :type '(choice (const :tag "Always" t) |
| 144 | (const :tag "Never" nil) | 139 | (const :tag "Never" nil) |
| 145 | (const :tag "Ask" ask)) | 140 | (const :tag "Ask" ask)) |