aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Monnier2007-08-23 18:27:41 +0000
committerStefan Monnier2007-08-23 18:27:41 +0000
commit67d0660b15f4e7d716881ac5b9192a1a17c4e4f9 (patch)
tree32d4514a66adcbeea27bc69a490a6223b53ac27e
parent7b5bd91f856e5b3c8a27d72d86532441a19c3835 (diff)
downloademacs-67d0660b15f4e7d716881ac5b9192a1a17c4e4f9.tar.gz
emacs-67d0660b15f4e7d716881ac5b9192a1a17c4e4f9.zip
Use with-current-buffer.
(gnus-pick-setup-message): Fix long-standing typo.
-rw-r--r--lisp/gnus/ChangeLog16
-rw-r--r--lisp/gnus/gnus-salt.el35
2 files changed, 26 insertions, 25 deletions
diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog
index 201b7fefdcb..3e234161c3e 100644
--- a/lisp/gnus/ChangeLog
+++ b/lisp/gnus/ChangeLog
@@ -1,3 +1,15 @@
12007-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * sha1.el: Fix up comment style.
4 (sha1-F0, sha1-F1, sha1-F2, sha1-F3, sha1-S1, sha1-S5, sha1-S30)
5 (sha1-OP, sha1-add-to-H): Use new-style backquotes.
6
7 * hex-util.el: Fix up comment style.
8 (hex-char-to-num, num-to-hex-char): Use new-style backquotes.
9
10 * gnus-salt.el: Use with-current-buffer.
11 (gnus-pick-setup-message): Fix long-standing typo.
12
12007-08-17 Katsumi Yamaoka <yamaoka@jpl.org> 132007-08-17 Katsumi Yamaoka <yamaoka@jpl.org>
2 14
3 * gnus-art.el (gnus-article-summary-command-nosave) 15 * gnus-art.el (gnus-article-summary-command-nosave)
@@ -11,8 +23,8 @@
11 according to gnus-maximum-newsgroup. 23 according to gnus-maximum-newsgroup.
12 24
13 * gnus-sum.el (gnus-articles-to-read, gnus-list-of-unread-articles) 25 * gnus-sum.el (gnus-articles-to-read, gnus-list-of-unread-articles)
14 (gnus-list-of-read-articles, gnus-sequence-of-unread-articles): Limit 26 (gnus-list-of-read-articles, gnus-sequence-of-unread-articles):
15 the range of articles according to gnus-maximum-newsgroup. 27 Limit the range of articles according to gnus-maximum-newsgroup.
16 28
172007-08-10 Katsumi Yamaoka <yamaoka@jpl.org> 292007-08-10 Katsumi Yamaoka <yamaoka@jpl.org>
18 30
diff --git a/lisp/gnus/gnus-salt.el b/lisp/gnus/gnus-salt.el
index 298b6dc4739..e8d3e332ba3 100644
--- a/lisp/gnus/gnus-salt.el
+++ b/lisp/gnus/gnus-salt.el
@@ -134,11 +134,10 @@ It accepts the same format specs that `gnus-summary-line-format' does."
134(defun gnus-pick-setup-message () 134(defun gnus-pick-setup-message ()
135 "Make Message do the right thing on exit." 135 "Make Message do the right thing on exit."
136 (when (and (gnus-buffer-live-p gnus-summary-buffer) 136 (when (and (gnus-buffer-live-p gnus-summary-buffer)
137 (save-excursion 137 (with-current-buffer gnus-summary-buffer
138 (set-buffer gnus-summary-buffer)
139 gnus-pick-mode)) 138 gnus-pick-mode))
140 (message-add-action 139 (message-add-action
141 '(gnus-configure-windows ,gnus-current-window-configuration t) 140 `(gnus-configure-windows ,gnus-current-window-configuration t)
142 'send 'exit 'postpone 'kill))) 141 'send 'exit 'postpone 'kill)))
143 142
144(defvar gnus-pick-line-number 1) 143(defvar gnus-pick-line-number 1)
@@ -524,8 +523,7 @@ Two predefined functions are available:
524 (interactive (list (gnus-tree-article-number))) 523 (interactive (list (gnus-tree-article-number)))
525 (let ((buf (current-buffer))) 524 (let ((buf (current-buffer)))
526 (when article 525 (when article
527 (save-excursion 526 (with-current-buffer gnus-summary-buffer
528 (set-buffer gnus-summary-buffer)
529 (gnus-summary-goto-article article)) 527 (gnus-summary-goto-article article))
530 (select-window (get-buffer-window buf))))) 528 (select-window (get-buffer-window buf)))))
531 529
@@ -576,8 +574,7 @@ Two predefined functions are available:
576 574
577(defun gnus-get-tree-buffer () 575(defun gnus-get-tree-buffer ()
578 "Return the tree buffer properly initialized." 576 "Return the tree buffer properly initialized."
579 (save-excursion 577 (with-current-buffer (gnus-get-buffer-create gnus-tree-buffer)
580 (set-buffer (gnus-get-buffer-create gnus-tree-buffer))
581 (unless (eq major-mode 'gnus-tree-mode) 578 (unless (eq major-mode 'gnus-tree-mode)
582 (gnus-tree-mode)) 579 (gnus-tree-mode))
583 (current-buffer))) 580 (current-buffer)))
@@ -662,8 +659,7 @@ Two predefined functions are available:
662 "Highlight current line according to `gnus-summary-highlight'." 659 "Highlight current line according to `gnus-summary-highlight'."
663 (let ((list gnus-summary-highlight) 660 (let ((list gnus-summary-highlight)
664 face) 661 face)
665 (save-excursion 662 (with-current-buffer gnus-summary-buffer
666 (set-buffer gnus-summary-buffer)
667 (let* ((score (or (cdr (assq article gnus-newsgroup-scored)) 663 (let* ((score (or (cdr (assq article gnus-newsgroup-scored))
668 gnus-summary-default-score 0)) 664 gnus-summary-default-score 0))
669 (default gnus-summary-default-score) 665 (default gnus-summary-default-score)
@@ -690,8 +686,7 @@ Two predefined functions are available:
690 686
691(defun gnus-generate-tree (thread) 687(defun gnus-generate-tree (thread)
692 "Generate a thread tree for THREAD." 688 "Generate a thread tree for THREAD."
693 (save-excursion 689 (with-current-buffer (gnus-get-tree-buffer)
694 (set-buffer (gnus-get-tree-buffer))
695 (let ((buffer-read-only nil) 690 (let ((buffer-read-only nil)
696 (gnus-tmp-indent 0)) 691 (gnus-tmp-indent 0))
697 (erase-buffer) 692 (erase-buffer)
@@ -814,14 +809,12 @@ Two predefined functions are available:
814 809
815(defun gnus-possibly-generate-tree (article &optional force) 810(defun gnus-possibly-generate-tree (article &optional force)
816 "Generate the thread tree for ARTICLE if it isn't displayed already." 811 "Generate the thread tree for ARTICLE if it isn't displayed already."
817 (when (save-excursion 812 (when (with-current-buffer gnus-summary-buffer
818 (set-buffer gnus-summary-buffer)
819 (and gnus-use-trees 813 (and gnus-use-trees
820 gnus-show-threads 814 gnus-show-threads
821 (vectorp (gnus-summary-article-header article)))) 815 (vectorp (gnus-summary-article-header article))))
822 (save-excursion 816 (save-excursion
823 (let ((top (save-excursion 817 (let ((top (with-current-buffer gnus-summary-buffer
824 (set-buffer gnus-summary-buffer)
825 (gnus-cut-thread 818 (gnus-cut-thread
826 (gnus-remove-thread 819 (gnus-remove-thread
827 (mail-header-id 820 (mail-header-id
@@ -843,8 +836,7 @@ Two predefined functions are available:
843(defun gnus-tree-perhaps-minimize () 836(defun gnus-tree-perhaps-minimize ()
844 (when (and gnus-tree-minimize-window 837 (when (and gnus-tree-minimize-window
845 (get-buffer gnus-tree-buffer)) 838 (get-buffer gnus-tree-buffer))
846 (save-excursion 839 (with-current-buffer gnus-tree-buffer
847 (set-buffer gnus-tree-buffer)
848 (gnus-tree-minimize)))) 840 (gnus-tree-minimize))))
849 841
850(defun gnus-highlight-selected-tree (article) 842(defun gnus-highlight-selected-tree (article)
@@ -871,14 +863,12 @@ Two predefined functions are available:
871 (gnus-horizontal-recenter) 863 (gnus-horizontal-recenter)
872 (select-window selected)))) 864 (select-window selected))))
873;; If we remove this save-excursion, it updates the wrong mode lines?!? 865;; If we remove this save-excursion, it updates the wrong mode lines?!?
874 (save-excursion 866 (with-current-buffer gnus-tree-buffer
875 (set-buffer gnus-tree-buffer)
876 (gnus-set-mode-line 'tree)) 867 (gnus-set-mode-line 'tree))
877 (set-buffer buf))) 868 (set-buffer buf)))
878 869
879(defun gnus-tree-highlight-article (article face) 870(defun gnus-tree-highlight-article (article face)
880 (save-excursion 871 (with-current-buffer (gnus-get-tree-buffer)
881 (set-buffer (gnus-get-tree-buffer))
882 (let (region) 872 (let (region)
883 (when (setq region (gnus-tree-article-region article)) 873 (when (setq region (gnus-tree-article-region article))
884 (gnus-put-text-property (car region) (cdr region) 'face face) 874 (gnus-put-text-property (car region) (cdr region) 'face face)
@@ -1013,8 +1003,7 @@ The following commands are available:
1013 (let ((buffer (symbol-value (intern (format "gnus-carpal-%s-buffer" type))))) 1003 (let ((buffer (symbol-value (intern (format "gnus-carpal-%s-buffer" type)))))
1014 (if (get-buffer buffer) 1004 (if (get-buffer buffer)
1015 () 1005 ()
1016 (save-excursion 1006 (with-current-buffer (gnus-get-buffer-create buffer)
1017 (set-buffer (gnus-get-buffer-create buffer))
1018 (gnus-carpal-mode) 1007 (gnus-carpal-mode)
1019 (setq gnus-carpal-attached-buffer 1008 (setq gnus-carpal-attached-buffer
1020 (intern (format "gnus-%s-buffer" type))) 1009 (intern (format "gnus-%s-buffer" type)))