aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEli Zaretskii2017-03-21 21:04:56 +0200
committerEli Zaretskii2017-03-21 21:04:56 +0200
commit650defd4e74ad00dd16e61c1fc5b4f497821c3d2 (patch)
treef6cad7a389c4fc69b0ce35c780b533e873eff12c
parent8a58133ee63c630f5095429065fc3d8446592e4e (diff)
downloademacs-650defd4e74ad00dd16e61c1fc5b4f497821c3d2.tar.gz
emacs-650defd4e74ad00dd16e61c1fc5b4f497821c3d2.zip
Revert "Make --without-pop the default."
This reverts commit 9319de675e395517f9a7b50cae1a3aad9cd0abc2.
-rw-r--r--INSTALL7
-rw-r--r--configure.ac31
-rw-r--r--etc/NEWS12
3 files changed, 29 insertions, 21 deletions
diff --git a/INSTALL b/INSTALL
index 9b6c04f079e..a99f1078044 100644
--- a/INSTALL
+++ b/INSTALL
@@ -265,14 +265,17 @@ uses the GNU Mailutils 'movemail' program to retrieve mail. Otherwise
265the Emacs build procedure builds and installs an auxiliary 'movemail' 265the Emacs build procedure builds and installs an auxiliary 'movemail'
266program, a limited and insecure substitute that Emacs can use when 266program, a limited and insecure substitute that Emacs can use when
267Mailutils is not installed; when this happens, there are several 267Mailutils is not installed; when this happens, there are several
268configure options such as --with-mail-unlink that provide fine-grained 268configure options such as --without-pop that provide fine-grained
269control over Emacs 'movemail' construction. 269control over Emacs 'movemail' construction.
270 270
271The Emacs mail reader RMAIL is configured to be able to read mail from 271The Emacs mail reader RMAIL is configured to be able to read mail from
272a POP3 server by default. Versions of the POP protocol older than 272a POP3 server by default. Versions of the POP protocol older than
273POP3 are not supported. While POP3 support is typically enabled, 273POP3 are not supported. While POP3 support is typically enabled,
274whether Emacs actually uses POP3 is controlled by individual users; 274whether Emacs actually uses POP3 is controlled by individual users;
275see the Rmail chapter of the Emacs manual. 275see the Rmail chapter of the Emacs manual. Unless you configure
276--with-mailutils, it is a good idea to configure --without-pop so that
277users are less likely to inadvertently read email via insecure
278channels.
276 279
277For image support you may have to download, build, and install the 280For image support you may have to download, build, and install the
278appropriate image support libraries for image types other than XBM and 281appropriate image support libraries for image types other than XBM and
diff --git a/configure.ac b/configure.ac
index 648000e0c45..fad7fb0104b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -229,17 +229,19 @@ AC_DEFUN([OPTION_DEFAULT_ON], [dnl
229 m4_bpatsubst([with_$1], [[^0-9a-z]], [_])=$with_features])dnl 229 m4_bpatsubst([with_$1], [[^0-9a-z]], [_])=$with_features])dnl
230])dnl 230])dnl
231 231
232# FIXME: The default options '--without-mailutils --with-pop' result
233# in a movemail implementation that supports only unencrypted POP3
234# connections. Encrypted connections should be the default.
235
232OPTION_DEFAULT_OFF([mailutils], 236OPTION_DEFAULT_OFF([mailutils],
233 [rely on GNU Mailutils being installed, so that --with-pop through 237 [rely on GNU Mailutils being installed; this makes the options
234 --with-mailhost are irrelevant]) 238 --without-pop through --with-mailhost irrelevant])
235if test "$with_mailutils" = no; then 239if test "$with_mailutils" = no; then
236 with_mailutils= 240 with_mailutils=
237fi 241fi
238AC_SUBST([with_mailutils]) 242AC_SUBST([with_mailutils])
239 243
240OPTION_DEFAULT_OFF([pop], 244OPTION_DEFAULT_ON([pop],[don't support POP mail retrieval with movemail])
241 [support POP mail retrieval with movemail (not recommended, as its
242 email retrieval is unencrypted)])
243if test "$with_pop" = yes; then 245if test "$with_pop" = yes; then
244 AC_DEFINE(MAIL_USE_POP) 246 AC_DEFINE(MAIL_USE_POP)
245fi 247fi
@@ -5479,11 +5481,15 @@ fi
5479 5481
5480AC_OUTPUT 5482AC_OUTPUT
5481 5483
5482if test ! "$with_mailutils" && test "$with_pop" = yes; then 5484if test ! "$with_mailutils"; then
5483 case $opsys in 5485 case $opsys in
5484 cygwin | mingw32) 5486 cygwin | mingw32)
5485 # Don't suggest GNU Mailutils, as it hasn't been ported. 5487 # Don't suggest GNU Mailutils, as it hasn't been ported.
5486 emacs_fix_movemail="use '$0' (without '--with-pop')";; 5488 if test "$with_pop" = yes; then
5489 emacs_fix_movemail="use '$0 --without-pop'"
5490 else
5491 emacs_fix_movemail=
5492 fi;;
5487 *) 5493 *)
5488 emacs_fix_movemail="use '$0 --with-mailutils'" 5494 emacs_fix_movemail="use '$0 --with-mailutils'"
5489 case `(movemail --version) 2>/dev/null` in 5495 case `(movemail --version) 2>/dev/null` in
@@ -5493,9 +5499,14 @@ if test ! "$with_mailutils" && test "$with_pop" = yes; then
5493 esac;; 5499 esac;;
5494 esac 5500 esac
5495 5501
5496 AC_MSG_WARN([This configuration installs a 'movemail' program 5502 if test "$with_pop" = yes; then
5497that retrieves POP3 email via only unencrypted channels. 5503 AC_MSG_WARN([This configuration installs a 'movemail' program
5498To avoid the problem you can $emacs_fix_movemail.]) 5504that retrieves POP3 email via only insecure channels.
5505To fix this you can $emacs_fix_movemail.])
5506 elif test "$emacs_fix_movemail"; then
5507 AC_MSG_NOTICE([This configuration installs a 'movemail' program that cannot
5508retrieve POP3 email. You might want to $emacs_fix_movemail.])
5509 fi
5499fi 5510fi
5500 5511
5501test "$MAKE" = make || AC_MSG_NOTICE([Now you can run '$MAKE'.]) 5512test "$MAKE" = make || AC_MSG_NOTICE([Now you can run '$MAKE'.])
diff --git a/etc/NEWS b/etc/NEWS
index bf50d1a3eec..cd98f533998 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -32,15 +32,9 @@ version 2.6.6 or later.
32 32
33** The new option 'configure --with-mailutils' causes Emacs to rely on 33** The new option 'configure --with-mailutils' causes Emacs to rely on
34GNU Mailutils 'movemail' to retrieve email. By default, the Emacs 34GNU Mailutils 'movemail' to retrieve email. By default, the Emacs
35build procedure continues to build and install a limited 'movemail' 35build procedure continues to build and install a limited and insecure
36substitute. Although --with-mailutils is recommended, it is not yet 36'movemail' substitute. Although --with-mailutils is recommended, it
37the default due to backward-compatibility concerns. 37is not yet the default due to backward-compatibility concerns.
38
39** The option 'configure --without-pop' is now the default.
40(This option's setting matters only if --with-mailutils is not used.)
41Using --with-pop (the previous default) preserves the historical
42behavior where Emacs 'movemail' retrieves network email only via
43unencrypted channels.
44 38
45** The new option 'configure --enable-gcc-warnings=warn-only' causes 39** The new option 'configure --enable-gcc-warnings=warn-only' causes
46GCC to issue warnings without stopping the build. This behavior is 40GCC to issue warnings without stopping the build. This behavior is