aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Ingebrigtsen2019-07-14 18:37:55 +0200
committerLars Ingebrigtsen2019-07-14 18:37:55 +0200
commit636dc37c70abf3c41261d035e06e2713070ce8cd (patch)
tree2c4aa12ac964976d1a155ce0b06827090834e0f8
parent0c450e09b8eea8839d10c329debb3be37ccd9a34 (diff)
downloademacs-636dc37c70abf3c41261d035e06e2713070ce8cd.tar.gz
emacs-636dc37c70abf3c41261d035e06e2713070ce8cd.zip
Revert "Make describe-face also output the version information"
This reverts commit a7aae1473c1aed7758b550a23cda61ee17668e23. The patch broke the build.
-rw-r--r--lisp/faces.el11
-rw-r--r--lisp/help-fns.el11
2 files changed, 6 insertions, 16 deletions
diff --git a/lisp/faces.el b/lisp/faces.el
index c3ef7dcb0f7..f9e8c6c58b8 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -25,8 +25,6 @@
25 25
26;;; Code: 26;;; Code:
27 27
28(require 'subr-x)
29
30(defcustom term-file-prefix (purecopy "term/") 28(defcustom term-file-prefix (purecopy "term/")
31 "If non-nil, Emacs startup performs terminal-specific initialization. 29 "If non-nil, Emacs startup performs terminal-specific initialization.
32It does this by: (load (concat term-file-prefix (getenv \"TERM\"))) 30It does this by: (load (concat term-file-prefix (getenv \"TERM\")))
@@ -1418,8 +1416,6 @@ argument, prompt for a regular expression using `read-regexp'."
1418 (dolist (face (face-list)) 1416 (dolist (face (face-list))
1419 (copy-face face face frame disp-frame))))) 1417 (copy-face face face frame disp-frame)))))
1420 1418
1421(declare-function describe-variable-custom-version-info "help-fns"
1422 (variable &optional type))
1423 1419
1424(defun describe-face (face &optional frame) 1420(defun describe-face (face &optional frame)
1425 "Display the properties of face FACE on FRAME. 1421 "Display the properties of face FACE on FRAME.
@@ -1432,7 +1428,6 @@ If FRAME is omitted or nil, use the selected frame."
1432 (interactive (list (read-face-name "Describe face" 1428 (interactive (list (read-face-name "Describe face"
1433 (or (face-at-point t) 'default) 1429 (or (face-at-point t) 'default)
1434 t))) 1430 t)))
1435 (require 'help-fns)
1436 (let* ((attrs '((:family . "Family") 1431 (let* ((attrs '((:family . "Family")
1437 (:foundry . "Foundry") 1432 (:foundry . "Foundry")
1438 (:width . "Width") 1433 (:width . "Width")
@@ -1529,11 +1524,7 @@ If FRAME is omitted or nil, use the selected frame."
1529 (re-search-backward ": \\([^:]+\\)" nil t) 1524 (re-search-backward ": \\([^:]+\\)" nil t)
1530 (help-xref-button 1 'help-face attr))) 1525 (help-xref-button 1 'help-face attr)))
1531 (insert "\n"))))) 1526 (insert "\n")))))
1532 (terpri) 1527 (terpri)))))))
1533 (when-let ((version-info (describe-variable-custom-version-info
1534 f 'face)))
1535 (insert version-info))
1536 (terpri)))))))
1537 1528
1538 1529
1539;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; 1530;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 0b5c547d6b0..39f701ae2a8 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -860,15 +860,14 @@ If ANY-SYMBOL is non-nil, don't insist the symbol be bound."
860 (and (or any-symbol (boundp sym)) sym))))) 860 (and (or any-symbol (boundp sym)) sym)))))
861 0))) 861 0)))
862 862
863(defun describe-variable-custom-version-info (variable &optional type) 863(defun describe-variable-custom-version-info (variable)
864 (let ((custom-version (get variable 'custom-version)) 864 (let ((custom-version (get variable 'custom-version))
865 (cpv (get variable 'custom-package-version)) 865 (cpv (get variable 'custom-package-version))
866 (type (or type "variable"))
867 (output nil)) 866 (output nil))
868 (if custom-version 867 (if custom-version
869 (setq output 868 (setq output
870 (format "This %s was introduced, or its default value was changed, in\nversion %s of Emacs.\n" 869 (format "This variable was introduced, or its default value was changed, in\nversion %s of Emacs.\n"
871 type custom-version)) 870 custom-version))
872 (when cpv 871 (when cpv
873 (let* ((package (car-safe cpv)) 872 (let* ((package (car-safe cpv))
874 (version (if (listp (cdr-safe cpv)) 873 (version (if (listp (cdr-safe cpv))
@@ -878,11 +877,11 @@ If ANY-SYMBOL is non-nil, don't insist the symbol be bound."
878 (emacsv (cdr (assoc version pkg-versions)))) 877 (emacsv (cdr (assoc version pkg-versions))))
879 (if (and package version) 878 (if (and package version)
880 (setq output 879 (setq output
881 (format (concat "This %s was introduced, or its default value was changed, in\nversion %s of the %s package" 880 (format (concat "This variable was introduced, or its default value was changed, in\nversion %s of the %s package"
882 (if emacsv 881 (if emacsv
883 (format " that is part of Emacs %s" emacsv)) 882 (format " that is part of Emacs %s" emacsv))
884 ".\n") 883 ".\n")
885 type version package)))))) 884 version package))))))
886 output)) 885 output))
887 886
888;;;###autoload 887;;;###autoload