diff options
| author | Stefan Monnier | 2010-09-17 16:22:06 +0200 |
|---|---|---|
| committer | Stefan Monnier | 2010-09-17 16:22:06 +0200 |
| commit | 63556fc6fa4abc8307551d1738d4cc9be5a65d94 (patch) | |
| tree | 079a6684cd16dc251b1b2b94b69bc2fd4ce4f6fc | |
| parent | 31c381e884e5d93c8e6382aab771aece4d013ed0 (diff) | |
| download | emacs-63556fc6fa4abc8307551d1738d4cc9be5a65d94.tar.gz emacs-63556fc6fa4abc8307551d1738d4cc9be5a65d94.zip | |
Silence byte-compiler
* lisp/gnus/nnrss.el (nnrss-retrieve-headers, nnrss-request-list-newsgroups)
(nnrss-retrieve-groups):
* lisp/gnus/pop3.el (pop3-open-server, pop3-read-response, pop3-list)
(pop3-retr, pop3-quit): Use with-current-buffer.
| -rw-r--r-- | lisp/gnus/ChangeLog | 7 | ||||
| -rw-r--r-- | lisp/gnus/nnrss.el | 9 | ||||
| -rw-r--r-- | lisp/gnus/pop3.el | 21 |
3 files changed, 18 insertions, 19 deletions
diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog index 895fee7e680..1e6b9f23295 100644 --- a/lisp/gnus/ChangeLog +++ b/lisp/gnus/ChangeLog | |||
| @@ -1,3 +1,10 @@ | |||
| 1 | 2010-09-17 Stefan Monnier <monnier@iro.umontreal.ca> | ||
| 2 | |||
| 3 | * nnrss.el (nnrss-retrieve-headers, nnrss-request-list-newsgroups) | ||
| 4 | (nnrss-retrieve-groups): | ||
| 5 | * pop3.el (pop3-open-server, pop3-read-response, pop3-list, pop3-retr) | ||
| 6 | (pop3-quit): Use with-current-buffer. | ||
| 7 | |||
| 1 | 2010-09-17 Katsumi Yamaoka <yamaoka@jpl.org> | 8 | 2010-09-17 Katsumi Yamaoka <yamaoka@jpl.org> |
| 2 | 9 | ||
| 3 | * pop3.el (pop3-wait-for-messages): Use pop3-accept-process-output | 10 | * pop3.el (pop3-wait-for-messages): Use pop3-accept-process-output |
diff --git a/lisp/gnus/nnrss.el b/lisp/gnus/nnrss.el index 555c2c3a77a..f241e5b175b 100644 --- a/lisp/gnus/nnrss.el +++ b/lisp/gnus/nnrss.el | |||
| @@ -134,8 +134,7 @@ used to render text. If it is nil, text will simply be folded.") | |||
| 134 | (setq group (nnrss-decode-group-name group)) | 134 | (setq group (nnrss-decode-group-name group)) |
| 135 | (nnrss-possibly-change-group group server) | 135 | (nnrss-possibly-change-group group server) |
| 136 | (let (e) | 136 | (let (e) |
| 137 | (save-excursion | 137 | (with-current-buffer nntp-server-buffer |
| 138 | (set-buffer nntp-server-buffer) | ||
| 139 | (erase-buffer) | 138 | (erase-buffer) |
| 140 | (dolist (article articles) | 139 | (dolist (article articles) |
| 141 | (if (setq e (assq article nnrss-group-data)) | 140 | (if (setq e (assq article nnrss-group-data)) |
| @@ -384,8 +383,7 @@ used to render text. If it is nil, text will simply be folded.") | |||
| 384 | 383 | ||
| 385 | (deffoo nnrss-request-list-newsgroups (&optional server) | 384 | (deffoo nnrss-request-list-newsgroups (&optional server) |
| 386 | (nnrss-possibly-change-group nil server) | 385 | (nnrss-possibly-change-group nil server) |
| 387 | (save-excursion | 386 | (with-current-buffer nntp-server-buffer |
| 388 | (set-buffer nntp-server-buffer) | ||
| 389 | (erase-buffer) | 387 | (erase-buffer) |
| 390 | (dolist (elem nnrss-group-alist) | 388 | (dolist (elem nnrss-group-alist) |
| 391 | (if (third elem) | 389 | (if (third elem) |
| @@ -396,8 +394,7 @@ used to render text. If it is nil, text will simply be folded.") | |||
| 396 | (nnrss-possibly-change-group nil server) | 394 | (nnrss-possibly-change-group nil server) |
| 397 | (dolist (group groups) | 395 | (dolist (group groups) |
| 398 | (nnrss-check-group group server)) | 396 | (nnrss-check-group group server)) |
| 399 | (save-excursion | 397 | (with-current-buffer nntp-server-buffer |
| 400 | (set-buffer nntp-server-buffer) | ||
| 401 | (erase-buffer) | 398 | (erase-buffer) |
| 402 | (dolist (group groups) | 399 | (dolist (group groups) |
| 403 | (let ((elem (assoc group nnrss-server-data))) | 400 | (let ((elem (assoc group nnrss-server-data))) |
diff --git a/lisp/gnus/pop3.el b/lisp/gnus/pop3.el index 63ed8004a9f..950cae25c4e 100644 --- a/lisp/gnus/pop3.el +++ b/lisp/gnus/pop3.el | |||
| @@ -279,9 +279,9 @@ Returns the process associated with the connection." | |||
| 279 | (let ((coding-system-for-read 'binary) | 279 | (let ((coding-system-for-read 'binary) |
| 280 | (coding-system-for-write 'binary) | 280 | (coding-system-for-write 'binary) |
| 281 | process) | 281 | process) |
| 282 | (save-excursion | 282 | (with-current-buffer |
| 283 | (set-buffer (get-buffer-create (concat " trace of POP session to " | 283 | (get-buffer-create (concat " trace of POP session to " |
| 284 | mailhost))) | 284 | mailhost)) |
| 285 | (erase-buffer) | 285 | (erase-buffer) |
| 286 | (setq pop3-read-point (point-min)) | 286 | (setq pop3-read-point (point-min)) |
| 287 | (setq process | 287 | (setq process |
| @@ -353,8 +353,7 @@ Returns the process associated with the connection." | |||
| 353 | Return the response string if optional second argument is non-nil." | 353 | Return the response string if optional second argument is non-nil." |
| 354 | (let ((case-fold-search nil) | 354 | (let ((case-fold-search nil) |
| 355 | match-end) | 355 | match-end) |
| 356 | (save-excursion | 356 | (with-current-buffer (process-buffer process) |
| 357 | (set-buffer (process-buffer process)) | ||
| 358 | (goto-char pop3-read-point) | 357 | (goto-char pop3-read-point) |
| 359 | (while (and (memq (process-status process) '(open run)) | 358 | (while (and (memq (process-status process) '(open run)) |
| 360 | (not (search-forward "\r\n" nil t))) | 359 | (not (search-forward "\r\n" nil t))) |
| @@ -511,8 +510,7 @@ Otherwise, return the size of the message-id MSG" | |||
| 511 | (if msg | 510 | (if msg |
| 512 | (string-to-number (nth 2 (split-string response " "))) | 511 | (string-to-number (nth 2 (split-string response " "))) |
| 513 | (let ((start pop3-read-point) end) | 512 | (let ((start pop3-read-point) end) |
| 514 | (save-excursion | 513 | (with-current-buffer (process-buffer process) |
| 515 | (set-buffer (process-buffer process)) | ||
| 516 | (while (not (re-search-forward "^\\.\r\n" nil t)) | 514 | (while (not (re-search-forward "^\\.\r\n" nil t)) |
| 517 | (pop3-accept-process-output process) | 515 | (pop3-accept-process-output process) |
| 518 | (goto-char start)) | 516 | (goto-char start)) |
| @@ -530,8 +528,7 @@ Otherwise, return the size of the message-id MSG" | |||
| 530 | (pop3-send-command process (format "RETR %s" msg)) | 528 | (pop3-send-command process (format "RETR %s" msg)) |
| 531 | (pop3-read-response process) | 529 | (pop3-read-response process) |
| 532 | (let ((start pop3-read-point) end) | 530 | (let ((start pop3-read-point) end) |
| 533 | (save-excursion | 531 | (with-current-buffer (process-buffer process) |
| 534 | (set-buffer (process-buffer process)) | ||
| 535 | (while (not (re-search-forward "^\\.\r\n" nil t)) | 532 | (while (not (re-search-forward "^\\.\r\n" nil t)) |
| 536 | (pop3-accept-process-output process) | 533 | (pop3-accept-process-output process) |
| 537 | (goto-char start)) | 534 | (goto-char start)) |
| @@ -547,8 +544,7 @@ Otherwise, return the size of the message-id MSG" | |||
| 547 | (setq end (point-marker)) | 544 | (setq end (point-marker)) |
| 548 | (pop3-clean-region start end) | 545 | (pop3-clean-region start end) |
| 549 | (pop3-munge-message-separator start end) | 546 | (pop3-munge-message-separator start end) |
| 550 | (save-excursion | 547 | (with-current-buffer crashbuf |
| 551 | (set-buffer crashbuf) | ||
| 552 | (erase-buffer)) | 548 | (erase-buffer)) |
| 553 | (copy-to-buffer crashbuf start end) | 549 | (copy-to-buffer crashbuf start end) |
| 554 | (delete-region start end) | 550 | (delete-region start end) |
| @@ -585,8 +581,7 @@ and close the connection." | |||
| 585 | (pop3-send-command process "QUIT") | 581 | (pop3-send-command process "QUIT") |
| 586 | (pop3-read-response process t) | 582 | (pop3-read-response process t) |
| 587 | (if process | 583 | (if process |
| 588 | (save-excursion | 584 | (with-current-buffer (process-buffer process) |
| 589 | (set-buffer (process-buffer process)) | ||
| 590 | (goto-char (point-max)) | 585 | (goto-char (point-max)) |
| 591 | (delete-process process)))) | 586 | (delete-process process)))) |
| 592 | 587 | ||