diff options
| author | Stefan Monnier | 2009-12-07 02:37:42 +0000 |
|---|---|---|
| committer | Stefan Monnier | 2009-12-07 02:37:42 +0000 |
| commit | 5e9fde5e5991e89ccb4c88bf57b6cbfb9da18b25 (patch) | |
| tree | 7c3172b3f07b3b3cded84309bc662efddf81f7f6 | |
| parent | 2f2f5242243fdc427357c304b5fb880c04171542 (diff) | |
| download | emacs-5e9fde5e5991e89ccb4c88bf57b6cbfb9da18b25.tar.gz emacs-5e9fde5e5991e89ccb4c88bf57b6cbfb9da18b25.zip | |
Make it work for non-file buffers (bug#5102).
* doc-view.el (doc-view-current-cache-dir):
Use doc-view-buffer-file-name rather than buffer-file-name.
(doc-view-mode): Use buffer-name when buffer-file-name is nil.
| -rw-r--r-- | lisp/ChangeLog | 11 | ||||
| -rw-r--r-- | lisp/doc-view.el | 12 |
2 files changed, 17 insertions, 6 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 9d17dff0d72..ca5bc660b26 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog | |||
| @@ -1,3 +1,10 @@ | |||
| 1 | 2009-12-07 Stefan Monnier <monnier@iro.umontreal.ca> | ||
| 2 | |||
| 3 | Make it work for non-file buffers (bug#5102). | ||
| 4 | * doc-view.el (doc-view-current-cache-dir): | ||
| 5 | Use doc-view-buffer-file-name rather than buffer-file-name. | ||
| 6 | (doc-view-mode): Use buffer-name when buffer-file-name is nil. | ||
| 7 | |||
| 1 | 2009-12-06 Óscar Fuentes <ofv@wanadoo.es> | 8 | 2009-12-06 Óscar Fuentes <ofv@wanadoo.es> |
| 2 | 9 | ||
| 3 | * vc-bzr.el (vc-bzr-annotate-command): Handle the case where the | 10 | * vc-bzr.el (vc-bzr-annotate-command): Handle the case where the |
| @@ -5,8 +12,8 @@ | |||
| 5 | 12 | ||
| 6 | 2009-12-06 Dan Nicolaescu <dann@ics.uci.edu> | 13 | 2009-12-06 Dan Nicolaescu <dann@ics.uci.edu> |
| 7 | 14 | ||
| 8 | * vc-git.el (vc-git-print-log): Handle a limit argument. Display | 15 | * vc-git.el (vc-git-print-log): Handle a limit argument. |
| 9 | the short log in graph form and with labels. | 16 | Display the short log in graph form and with labels. |
| 10 | (vc-git-log-view-mode): Handle labels. | 17 | (vc-git-log-view-mode): Handle labels. |
| 11 | 18 | ||
| 12 | Make vc-revert change VC state from 'added to 'unregistered. | 19 | Make vc-revert change VC state from 'added to 'unregistered. |
diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 311ab826c69..d8985cf9072 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el | |||
| @@ -563,7 +563,7 @@ It's a subdirectory of `doc-view-cache-directory'." | |||
| 563 | (setq doc-view-current-cache-dir | 563 | (setq doc-view-current-cache-dir |
| 564 | (file-name-as-directory | 564 | (file-name-as-directory |
| 565 | (expand-file-name | 565 | (expand-file-name |
| 566 | (concat (file-name-nondirectory buffer-file-name) | 566 | (concat (file-name-nondirectory doc-view-buffer-file-name) |
| 567 | "-" | 567 | "-" |
| 568 | (let ((file doc-view-buffer-file-name)) | 568 | (let ((file doc-view-buffer-file-name)) |
| 569 | (with-temp-buffer | 569 | (with-temp-buffer |
| @@ -1228,6 +1228,7 @@ toggle between displaying the document or editing it as text. | |||
| 1228 | (set (make-local-variable 'doc-view-buffer-file-name) | 1228 | (set (make-local-variable 'doc-view-buffer-file-name) |
| 1229 | (cond | 1229 | (cond |
| 1230 | (jka-compr-really-do-compress | 1230 | (jka-compr-really-do-compress |
| 1231 | ;; FIXME: there's a risk of name conflicts here. | ||
| 1231 | (expand-file-name | 1232 | (expand-file-name |
| 1232 | (file-name-nondirectory | 1233 | (file-name-nondirectory |
| 1233 | (file-name-sans-extension buffer-file-name)) | 1234 | (file-name-sans-extension buffer-file-name)) |
| @@ -1237,10 +1238,13 @@ toggle between displaying the document or editing it as text. | |||
| 1237 | ;; supposed to return nil for things like local files accessed via | 1238 | ;; supposed to return nil for things like local files accessed via |
| 1238 | ;; `su' or via file://... | 1239 | ;; `su' or via file://... |
| 1239 | ((let ((file-name-handler-alist nil)) | 1240 | ((let ((file-name-handler-alist nil)) |
| 1240 | (not (file-readable-p buffer-file-name))) | 1241 | (not (and buffer-file-name (file-readable-p buffer-file-name)))) |
| 1242 | ;; FIXME: there's a risk of name conflicts here. | ||
| 1241 | (expand-file-name | 1243 | (expand-file-name |
| 1242 | (file-name-nondirectory buffer-file-name) | 1244 | (if buffer-file-name |
| 1243 | doc-view-cache-directory)) | 1245 | (file-name-nondirectory buffer-file-name) |
| 1246 | (buffer-name)) | ||
| 1247 | doc-view-cache-directory)) | ||
| 1244 | (t buffer-file-name))) | 1248 | (t buffer-file-name))) |
| 1245 | (when (not (string= doc-view-buffer-file-name buffer-file-name)) | 1249 | (when (not (string= doc-view-buffer-file-name buffer-file-name)) |
| 1246 | (write-region nil nil doc-view-buffer-file-name)) | 1250 | (write-region nil nil doc-view-buffer-file-name)) |