aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGlenn Morris2012-01-24 21:01:22 -0500
committerGlenn Morris2012-01-24 21:01:22 -0500
commit5ddce96c6179e43047ed365dc4ae2818cdc93d7b (patch)
tree5f8565c57717ca3b63f92c136801fd276ea1b30e
parent5ae1a6c8a299bf5759dcd45df096cb6f157f5110 (diff)
downloademacs-5ddce96c6179e43047ed365dc4ae2818cdc93d7b.tar.gz
emacs-5ddce96c6179e43047ed365dc4ae2818cdc93d7b.zip
compile/grep fix for bug#10594
* lisp/progmodes/compile.el (compilation-next-error-function): Respect compilation-first-column in the "*compilation*" buffer. * lisp/progmodes/grep.el (grep-first-column): New variable.
-rw-r--r--lisp/ChangeLog4
-rw-r--r--lisp/progmodes/compile.el6
-rw-r--r--lisp/progmodes/grep.el3
3 files changed, 12 insertions, 1 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a07d90969fa..eff83cb8460 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,9 @@
12012-01-25 Glenn Morris <rgm@gnu.org> 12012-01-25 Glenn Morris <rgm@gnu.org>
2 2
3 * progmodes/compile.el (compilation-next-error-function):
4 Respect compilation-first-column in the "*compilation*" buffer.
5 * progmodes/grep.el (grep-first-column): New variable. (Bug#10594)
6
3 * vc/vc.el (vc-modify-change-comment): Scoping fix. (Bug#10513) 7 * vc/vc.el (vc-modify-change-comment): Scoping fix. (Bug#10513)
4 8
52012-01-24 Glenn Morris <rgm@gnu.org> 92012-01-24 Glenn Morris <rgm@gnu.org>
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index f152209956f..3b8c3a00699 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2271,6 +2271,7 @@ This is the value of `next-error-function' in Compilation buffers."
2271 (when reset 2271 (when reset
2272 (setq compilation-current-error nil)) 2272 (setq compilation-current-error nil))
2273 (let* ((screen-columns compilation-error-screen-columns) 2273 (let* ((screen-columns compilation-error-screen-columns)
2274 (first-column compilation-first-column)
2274 (last 1) 2275 (last 1)
2275 (msg (compilation-next-error (or n 1) nil 2276 (msg (compilation-next-error (or n 1) nil
2276 (or compilation-current-error 2277 (or compilation-current-error
@@ -2309,7 +2310,10 @@ This is the value of `next-error-function' in Compilation buffers."
2309 ;; Obey the compilation-error-screen-columns of the target 2310 ;; Obey the compilation-error-screen-columns of the target
2310 ;; buffer if its major mode set it buffer-locally. 2311 ;; buffer if its major mode set it buffer-locally.
2311 (if (local-variable-p 'compilation-error-screen-columns) 2312 (if (local-variable-p 'compilation-error-screen-columns)
2312 compilation-error-screen-columns screen-columns))) 2313 compilation-error-screen-columns screen-columns))
2314 (compilation-first-column
2315 (if (local-variable-p 'compilation-first-column)
2316 compilation-first-column first-column)))
2313 (save-restriction 2317 (save-restriction
2314 (widen) 2318 (widen)
2315 (goto-char (point-min)) 2319 (goto-char (point-min))
diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
index 697af76acc9..54d678323f6 100644
--- a/lisp/progmodes/grep.el
+++ b/lisp/progmodes/grep.el
@@ -374,6 +374,9 @@ Notice that using \\[next-error] or \\[compile-goto-error] modifies
374 ("^Binary file \\(.+\\) matches$" 1 nil nil 0 1)) 374 ("^Binary file \\(.+\\) matches$" 1 nil nil 0 1))
375 "Regexp used to match grep hits. See `compilation-error-regexp-alist'.") 375 "Regexp used to match grep hits. See `compilation-error-regexp-alist'.")
376 376
377(defvar grep-first-column 0 ; bug#10594
378 "Value to use for `compilation-first-column' in grep buffers.")
379
377(defvar grep-error "grep hit" 380(defvar grep-error "grep hit"
378 "Message to print when no matches are found.") 381 "Message to print when no matches are found.")
379 382