aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Albinus2013-08-15 16:29:08 +0200
committerMichael Albinus2013-08-15 16:29:08 +0200
commit5d89d9d256eed9bf4ebb982be28e50f7c4fc9e7c (patch)
tree75da746b996197bcded444c98c867df035150acd
parent7cbbcaa0dd337d39939d65f58b45f50f4480ce09 (diff)
downloademacs-5d89d9d256eed9bf4ebb982be28e50f7c4fc9e7c.tar.gz
emacs-5d89d9d256eed9bf4ebb982be28e50f7c4fc9e7c.zip
Remove byte compiler warnings, visible when compiling with
`byte-compile-force-lexical-warnings' set to t. * net/tramp.el (tramp-debug-message, tramp-message, tramp-error) (tramp-error-with-buffer): Rename ARGS to ARGUMENTS and BUFFER to BUF. (tramp-handle-unhandled-file-name-directory) (tramp-handle-file-notify-add-watch, tramp-action-login) (tramp-action-succeed, tramp-action-permission-denied) (tramp-action-terminal, tramp-action-process-alive): Prefix unused arguments with "_". * net/tramp-adb.el (tramp-adb-parse-device-names) (tramp-adb-handle-insert-directory, tramp-adb-handle-delete-file) (tramp-adb-handle-copy-file): Prefix unused arguments with "_". (tramp-adb-handle-file-truename): Remove unused arguments. * net/tramp-cache.el (tramp-flush-directory-property) (tramp-flush-connection-property, tramp-list-connections) (tramp-parse-connection-properties): Prefix unused arguments with "_". * net/tramp-compat.el (tramp-compat-make-temp-file): Rename FILENAME to F. * net/tramp-gvfs.el (tramp-gvfs-handle-file-notify-add-watch) (tramp-gvfs-handle-write-region, tramp-bluez-parse-device-names) (tramp-zeroconf-parse-workstation-device-names) (tramp-zeroconf-parse-webdav-device-names) (tramp-synce-parse-device-names): Prefix unused arguments with "_". * net/tramp-gw.el (tramp-gw-gw-proc-sentinel) (tramp-gw-aux-proc-sentinel): Prefix unused arguments with "_". * net/tramp-sh.el (tramp-sh-handle-file-truename): Remove unused arguments. (tramp-sh-handle-copy-file, tramp-sh-handle-dired-compress-file) (tramp-sh-handle-insert-file-contents-literally) (tramp-sh-handle-file-notify-add-watch): Prefix unused arguments with "_". (tramp-do-copy-or-rename-file, tramp-barf-if-no-shell-prompt): Remove unused variables. * net/tramp-smb.el (tramp-smb-handle-copy-directory) (tramp-smb-handle-copy-file, tramp-smb-handle-delete-file) (tramp-smb-read-file-entry): Prefix unused arguments with "_". * net/tramp-uu.el (tramp-uu-b64-alphabet, tramp-uu-b64-char-to-byte): Make them a defconst. (tramp-uuencode-region): Remove unused variable.
-rw-r--r--lisp/ChangeLog51
-rw-r--r--lisp/net/tramp-adb.el10
-rw-r--r--lisp/net/tramp-cache.el8
-rw-r--r--lisp/net/tramp-compat.el6
-rw-r--r--lisp/net/tramp-gvfs.el12
-rw-r--r--lisp/net/tramp-gw.el4
-rw-r--r--lisp/net/tramp-sh.el15
-rw-r--r--lisp/net/tramp-smb.el8
-rw-r--r--lisp/net/tramp-uu.el5
-rw-r--r--lisp/net/tramp.el48
10 files changed, 108 insertions, 59 deletions
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 4b9ea280f98..bcab8de10a4 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,54 @@
12013-08-15 Michael Albinus <michael.albinus@gmx.de>
2
3 Remove byte compiler warnings, visible when compiling with
4 `byte-compile-force-lexical-warnings' set to t.
5
6 * net/tramp.el (tramp-debug-message, tramp-message, tramp-error)
7 (tramp-error-with-buffer): Rename ARGS to ARGUMENTS and BUFFER to BUF.
8 (tramp-handle-unhandled-file-name-directory)
9 (tramp-handle-file-notify-add-watch, tramp-action-login)
10 (tramp-action-succeed, tramp-action-permission-denied)
11 (tramp-action-terminal, tramp-action-process-alive): Prefix unused
12 arguments with "_".
13
14 * net/tramp-adb.el (tramp-adb-parse-device-names)
15 (tramp-adb-handle-insert-directory, tramp-adb-handle-delete-file)
16 (tramp-adb-handle-copy-file): Prefix unused arguments with "_".
17 (tramp-adb-handle-file-truename): Remove unused arguments.
18
19 * net/tramp-cache.el (tramp-flush-directory-property)
20 (tramp-flush-connection-property, tramp-list-connections)
21 (tramp-parse-connection-properties): Prefix unused arguments with "_".
22
23 * net/tramp-compat.el (tramp-compat-make-temp-file): Rename
24 FILENAME to F.
25
26 * net/tramp-gvfs.el (tramp-gvfs-handle-file-notify-add-watch)
27 (tramp-gvfs-handle-write-region, tramp-bluez-parse-device-names)
28 (tramp-zeroconf-parse-workstation-device-names)
29 (tramp-zeroconf-parse-webdav-device-names)
30 (tramp-synce-parse-device-names): Prefix unused arguments with "_".
31
32 * net/tramp-gw.el (tramp-gw-gw-proc-sentinel)
33 (tramp-gw-aux-proc-sentinel): Prefix unused arguments with "_".
34
35 * net/tramp-sh.el (tramp-sh-handle-file-truename): Remove unused
36 arguments.
37 (tramp-sh-handle-copy-file, tramp-sh-handle-dired-compress-file)
38 (tramp-sh-handle-insert-file-contents-literally)
39 (tramp-sh-handle-file-notify-add-watch): Prefix unused arguments
40 with "_".
41 (tramp-do-copy-or-rename-file, tramp-barf-if-no-shell-prompt):
42 Remove unused variables.
43
44 * net/tramp-smb.el (tramp-smb-handle-copy-directory)
45 (tramp-smb-handle-copy-file, tramp-smb-handle-delete-file)
46 (tramp-smb-read-file-entry): Prefix unused arguments with "_".
47
48 * net/tramp-uu.el (tramp-uu-b64-alphabet, tramp-uu-b64-char-to-byte):
49 Make them a defconst.
50 (tramp-uuencode-region): Remove unused variable.
51
12013-08-14 Juanma Barranquero <lekktu@gmail.com> 522013-08-14 Juanma Barranquero <lekktu@gmail.com>
2 53
3 * frameset.el (frameset--prop-setter): New function. 54 * frameset.el (frameset--prop-setter): New function.
diff --git a/lisp/net/tramp-adb.el b/lisp/net/tramp-adb.el
index 33e9e5aa44b..389edf1c919 100644
--- a/lisp/net/tramp-adb.el
+++ b/lisp/net/tramp-adb.el
@@ -174,7 +174,7 @@ pass to the OPERATION."
174 (tramp-run-real-handler operation args)))) 174 (tramp-run-real-handler operation args))))
175 175
176;;;###tramp-autoload 176;;;###tramp-autoload
177(defun tramp-adb-parse-device-names (ignore) 177(defun tramp-adb-parse-device-names (_ignore)
178 "Return a list of (nil host) tuples allowed to access." 178 "Return a list of (nil host) tuples allowed to access."
179 (with-timeout (10) 179 (with-timeout (10)
180 (with-temp-buffer 180 (with-temp-buffer
@@ -224,7 +224,7 @@ pass to the OPERATION."
224 224
225;; This is derived from `tramp-sh-handle-file-truename'. Maybe the 225;; This is derived from `tramp-sh-handle-file-truename'. Maybe the
226;; code could be shared? 226;; code could be shared?
227(defun tramp-adb-handle-file-truename (filename &optional counter prev-dirs) 227(defun tramp-adb-handle-file-truename (filename)
228 "Like `file-truename' for Tramp files." 228 "Like `file-truename' for Tramp files."
229 (with-parsed-tramp-file-name (expand-file-name filename) nil 229 (with-parsed-tramp-file-name (expand-file-name filename) nil
230 (with-tramp-file-property v localname "file-truename" 230 (with-tramp-file-property v localname "file-truename"
@@ -416,7 +416,7 @@ Convert (\"-al\") to (\"-a\" \"-l\"). Remove arguments like \"--dired\"."
416 switches)))))) 416 switches))))))
417 417
418(defun tramp-adb-handle-insert-directory 418(defun tramp-adb-handle-insert-directory
419 (filename switches &optional wildcard full-directory-p) 419 (filename switches &optional _wildcard _full-directory-p)
420 "Like `insert-directory' for Tramp files." 420 "Like `insert-directory' for Tramp files."
421 (when (stringp switches) 421 (when (stringp switches)
422 (setq switches (tramp-adb--gnu-switches-to-ash (split-string switches)))) 422 (setq switches (tramp-adb--gnu-switches-to-ash (split-string switches))))
@@ -518,7 +518,7 @@ Emacs dired can't find files."
518 (tramp-shell-quote-argument localname)) 518 (tramp-shell-quote-argument localname))
519 "Couldn't delete %s" directory))) 519 "Couldn't delete %s" directory)))
520 520
521(defun tramp-adb-handle-delete-file (filename &optional trash) 521(defun tramp-adb-handle-delete-file (filename &optional _trash)
522 "Like `delete-file' for Tramp files." 522 "Like `delete-file' for Tramp files."
523 (setq filename (expand-file-name filename)) 523 (setq filename (expand-file-name filename))
524 (with-parsed-tramp-file-name filename nil 524 (with-parsed-tramp-file-name filename nil
@@ -651,7 +651,7 @@ But handle the case, if the \"test\" command is not available."
651 651
652(defun tramp-adb-handle-copy-file 652(defun tramp-adb-handle-copy-file
653 (filename newname &optional ok-if-already-exists keep-date 653 (filename newname &optional ok-if-already-exists keep-date
654 preserve-uid-gid preserve-extended-attributes) 654 _preserve-uid-gid _preserve-extended-attributes)
655 "Like `copy-file' for Tramp files. 655 "Like `copy-file' for Tramp files.
656PRESERVE-UID-GID and PRESERVE-EXTENDED-ATTRIBUTES are completely ignored." 656PRESERVE-UID-GID and PRESERVE-EXTENDED-ATTRIBUTES are completely ignored."
657 (setq filename (expand-file-name filename) 657 (setq filename (expand-file-name filename)
diff --git a/lisp/net/tramp-cache.el b/lisp/net/tramp-cache.el
index f7f570590c8..118be597433 100644
--- a/lisp/net/tramp-cache.el
+++ b/lisp/net/tramp-cache.el
@@ -187,7 +187,7 @@ Remove also properties of all files in subdirectories."
187 'directory-file-name (list directory)))) 187 'directory-file-name (list directory))))
188 (tramp-message key 8 "%s" directory) 188 (tramp-message key 8 "%s" directory)
189 (maphash 189 (maphash
190 (lambda (key value) 190 (lambda (key _value)
191 (when (and (stringp (tramp-file-name-localname key)) 191 (when (and (stringp (tramp-file-name-localname key))
192 (string-match directory (tramp-file-name-localname key))) 192 (string-match directory (tramp-file-name-localname key)))
193 (remhash key tramp-cache-data))) 193 (remhash key tramp-cache-data)))
@@ -273,7 +273,7 @@ KEY identifies the connection, it is either a process or a vector."
273 (let ((hash (gethash key tramp-cache-data)) 273 (let ((hash (gethash key tramp-cache-data))
274 properties) 274 properties)
275 (when (hash-table-p hash) 275 (when (hash-table-p hash)
276 (maphash (lambda (x y) (add-to-list 'properties x 'append)) hash)) 276 (maphash (lambda (x _y) (add-to-list 'properties x 'append)) hash))
277 properties)) 277 properties))
278 (setq tramp-cache-data-changed t) 278 (setq tramp-cache-data-changed t)
279 (remhash key tramp-cache-data)) 279 (remhash key tramp-cache-data))
@@ -304,7 +304,7 @@ KEY identifies the connection, it is either a process or a vector."
304 "Return a list of all known connection vectors according to `tramp-cache'." 304 "Return a list of all known connection vectors according to `tramp-cache'."
305 (let (result) 305 (let (result)
306 (maphash 306 (maphash
307 (lambda (key value) 307 (lambda (key _value)
308 (when (and (vectorp key) (null (aref key 3))) 308 (when (and (vectorp key) (null (aref key 3)))
309 (add-to-list 'result key))) 309 (add-to-list 'result key)))
310 tramp-cache-data) 310 tramp-cache-data)
@@ -368,7 +368,7 @@ This function is added always in `tramp-get-completion-function'
368for all methods. Resulting data are derived from connection history." 368for all methods. Resulting data are derived from connection history."
369 (let (res) 369 (let (res)
370 (maphash 370 (maphash
371 (lambda (key value) 371 (lambda (key _value)
372 (if (and (vectorp key) 372 (if (and (vectorp key)
373 (string-equal method (tramp-file-name-method key)) 373 (string-equal method (tramp-file-name-method key))
374 (not (tramp-file-name-localname key))) 374 (not (tramp-file-name-localname key)))
diff --git a/lisp/net/tramp-compat.el b/lisp/net/tramp-compat.el
index 2b0ea74c492..c42a29981b7 100644
--- a/lisp/net/tramp-compat.el
+++ b/lisp/net/tramp-compat.el
@@ -238,14 +238,14 @@ this is the function `temp-directory'."
238;; `make-temp-file' exists in Emacs only. On XEmacs, we use our own 238;; `make-temp-file' exists in Emacs only. On XEmacs, we use our own
239;; implementation with `make-temp-name', creating the temporary file 239;; implementation with `make-temp-name', creating the temporary file
240;; immediately in order to avoid a security hole. 240;; immediately in order to avoid a security hole.
241(defsubst tramp-compat-make-temp-file (filename &optional dir-flag) 241(defsubst tramp-compat-make-temp-file (f &optional dir-flag)
242 "Create a temporary file (compat function). 242 "Create a temporary file (compat function).
243Add the extension of FILENAME, if existing." 243Add the extension of F, if existing."
244 (let* (file-name-handler-alist 244 (let* (file-name-handler-alist
245 (prefix (expand-file-name 245 (prefix (expand-file-name
246 (symbol-value 'tramp-temp-name-prefix) 246 (symbol-value 'tramp-temp-name-prefix)
247 (tramp-compat-temporary-file-directory))) 247 (tramp-compat-temporary-file-directory)))
248 (extension (file-name-extension filename t)) 248 (extension (file-name-extension f t))
249 result) 249 result)
250 (condition-case nil 250 (condition-case nil
251 (setq result 251 (setq result
diff --git a/lisp/net/tramp-gvfs.el b/lisp/net/tramp-gvfs.el
index 5bb30b04643..d0270aabacc 100644
--- a/lisp/net/tramp-gvfs.el
+++ b/lisp/net/tramp-gvfs.el
@@ -923,7 +923,7 @@ is no information where to trace the message.")
923 v (concat localname filename) 923 v (concat localname filename)
924 "file-name-all-completions" result)))))))) 924 "file-name-all-completions" result))))))))
925 925
926(defun tramp-gvfs-handle-file-notify-add-watch (file-name flags callback) 926(defun tramp-gvfs-handle-file-notify-add-watch (file-name _flags _callback)
927 "Like `file-notify-add-watch' for Tramp files." 927 "Like `file-notify-add-watch' for Tramp files."
928 (setq file-name (expand-file-name file-name)) 928 (setq file-name (expand-file-name file-name))
929 (with-parsed-tramp-file-name file-name nil 929 (with-parsed-tramp-file-name file-name nil
@@ -1093,7 +1093,7 @@ is no information where to trace the message.")
1093 (tramp-flush-file-property v localname)))))) 1093 (tramp-flush-file-property v localname))))))
1094 1094
1095(defun tramp-gvfs-handle-write-region 1095(defun tramp-gvfs-handle-write-region
1096 (start end filename &optional append visit lockname confirm) 1096 (start end filename &optional _append visit _lockname confirm)
1097 "Like `write-region' for Tramp files." 1097 "Like `write-region' for Tramp files."
1098 (with-parsed-tramp-file-name filename nil 1098 (with-parsed-tramp-file-name filename nil
1099 ;; XEmacs takes a coding system as the seventh argument, not `confirm'. 1099 ;; XEmacs takes a coding system as the seventh argument, not `confirm'.
@@ -1653,7 +1653,7 @@ be used."
1653 :system nil nil tramp-bluez-interface-adapter "DeviceFound" 1653 :system nil nil tramp-bluez-interface-adapter "DeviceFound"
1654 'tramp-bluez-device-found) 1654 'tramp-bluez-device-found)
1655 1655
1656(defun tramp-bluez-parse-device-names (ignore) 1656(defun tramp-bluez-parse-device-names (_ignore)
1657 "Return a list of (nil host) tuples allowed to access." 1657 "Return a list of (nil host) tuples allowed to access."
1658 (mapcar 1658 (mapcar
1659 (lambda (x) (list nil (car x))) 1659 (lambda (x) (list nil (car x)))
@@ -1667,14 +1667,14 @@ be used."
1667 1667
1668;; D-Bus zeroconf functions. 1668;; D-Bus zeroconf functions.
1669 1669
1670(defun tramp-zeroconf-parse-workstation-device-names (ignore) 1670(defun tramp-zeroconf-parse-workstation-device-names (_ignore)
1671 "Return a list of (user host) tuples allowed to access." 1671 "Return a list of (user host) tuples allowed to access."
1672 (mapcar 1672 (mapcar
1673 (lambda (x) 1673 (lambda (x)
1674 (list nil (zeroconf-service-host x))) 1674 (list nil (zeroconf-service-host x)))
1675 (zeroconf-list-services "_workstation._tcp"))) 1675 (zeroconf-list-services "_workstation._tcp")))
1676 1676
1677(defun tramp-zeroconf-parse-webdav-device-names (ignore) 1677(defun tramp-zeroconf-parse-webdav-device-names (_ignore)
1678 "Return a list of (user host) tuples allowed to access." 1678 "Return a list of (user host) tuples allowed to access."
1679 (mapcar 1679 (mapcar
1680 (lambda (x) 1680 (lambda (x)
@@ -1724,7 +1724,7 @@ They are retrieved from the hal daemon."
1724 (tramp-message tramp-gvfs-dbus-event-vector 10 "%s" tramp-synce-devices) 1724 (tramp-message tramp-gvfs-dbus-event-vector 10 "%s" tramp-synce-devices)
1725 tramp-synce-devices)) 1725 tramp-synce-devices))
1726 1726
1727(defun tramp-synce-parse-device-names (ignore) 1727(defun tramp-synce-parse-device-names (_ignore)
1728 "Return a list of (nil host) tuples allowed to access." 1728 "Return a list of (nil host) tuples allowed to access."
1729 (mapcar 1729 (mapcar
1730 (lambda (x) (list nil x)) 1730 (lambda (x) (list nil x))
diff --git a/lisp/net/tramp-gw.el b/lisp/net/tramp-gw.el
index 13f2964f938..f7c6eba4006 100644
--- a/lisp/net/tramp-gw.el
+++ b/lisp/net/tramp-gw.el
@@ -96,7 +96,7 @@
96(defvar tramp-gw-aux-proc nil 96(defvar tramp-gw-aux-proc nil
97 "Process listening on local port, as mediation between SSH and the gateway.") 97 "Process listening on local port, as mediation between SSH and the gateway.")
98 98
99(defun tramp-gw-gw-proc-sentinel (proc event) 99(defun tramp-gw-gw-proc-sentinel (proc _event)
100 "Delete auxiliary process when we are deleted." 100 "Delete auxiliary process when we are deleted."
101 (unless (memq (process-status proc) '(run open)) 101 (unless (memq (process-status proc) '(run open))
102 (tramp-message 102 (tramp-message
@@ -105,7 +105,7 @@
105 (p (tramp-get-connection-property proc "process" nil))) 105 (p (tramp-get-connection-property proc "process" nil)))
106 (when (processp p) (delete-process p))))) 106 (when (processp p) (delete-process p)))))
107 107
108(defun tramp-gw-aux-proc-sentinel (proc event) 108(defun tramp-gw-aux-proc-sentinel (proc _event)
109 "Activate the different filters for involved gateway and auxiliary processes." 109 "Activate the different filters for involved gateway and auxiliary processes."
110 (when (memq (process-status proc) '(run open)) 110 (when (memq (process-status proc) '(run open))
111 ;; A new process has been spawned from `tramp-gw-aux-proc'. 111 ;; A new process has been spawned from `tramp-gw-aux-proc'.
diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el
index f9e68d0dad0..5460bd00d6c 100644
--- a/lisp/net/tramp-sh.el
+++ b/lisp/net/tramp-sh.el
@@ -938,7 +938,7 @@ target of the symlink differ."
938 (tramp-shell-quote-argument l-localname)) 938 (tramp-shell-quote-argument l-localname))
939 t)))) 939 t))))
940 940
941(defun tramp-sh-handle-file-truename (filename &optional counter prev-dirs) 941(defun tramp-sh-handle-file-truename (filename)
942 "Like `file-truename' for Tramp files." 942 "Like `file-truename' for Tramp files."
943 (with-parsed-tramp-file-name (expand-file-name filename) nil 943 (with-parsed-tramp-file-name (expand-file-name filename) nil
944 (tramp-make-tramp-file-name method user host 944 (tramp-make-tramp-file-name method user host
@@ -1837,7 +1837,7 @@ tramp-sh-handle-file-name-all-completions: internal error accessing `%s': `%s'"
1837 'copy-file (list filename newname ok-if-already-exists keep-date))))) 1837 'copy-file (list filename newname ok-if-already-exists keep-date)))))
1838 1838
1839(defun tramp-sh-handle-copy-directory 1839(defun tramp-sh-handle-copy-directory
1840 (dirname newname &optional keep-date parents copy-contents) 1840 (dirname newname &optional keep-date parents _copy-contents)
1841 "Like `copy-directory' for Tramp files." 1841 "Like `copy-directory' for Tramp files."
1842 (let ((t1 (tramp-tramp-file-p dirname)) 1842 (let ((t1 (tramp-tramp-file-p dirname))
1843 (t2 (tramp-tramp-file-p newname))) 1843 (t2 (tramp-tramp-file-p newname)))
@@ -1911,8 +1911,7 @@ file names."
1911 (t2 (tramp-tramp-file-p newname)) 1911 (t2 (tramp-tramp-file-p newname))
1912 (length (nth 7 (file-attributes (file-truename filename)))) 1912 (length (nth 7 (file-attributes (file-truename filename))))
1913 (attributes (and preserve-extended-attributes 1913 (attributes (and preserve-extended-attributes
1914 (apply 'file-extended-attributes (list filename)))) 1914 (apply 'file-extended-attributes (list filename)))))
1915 pr tm)
1916 1915
1917 (with-parsed-tramp-file-name (if t1 filename newname) nil 1916 (with-parsed-tramp-file-name (if t1 filename newname) nil
1918 (when (and (not ok-if-already-exists) (file-exists-p newname)) 1917 (when (and (not ok-if-already-exists) (file-exists-p newname))
@@ -2433,7 +2432,7 @@ This is like `dired-recursive-delete-directory' for Tramp files."
2433 (tramp-error 2432 (tramp-error
2434 v 'file-error "Failed to recursively delete %s" filename)))) 2433 v 'file-error "Failed to recursively delete %s" filename))))
2435 2434
2436(defun tramp-sh-handle-dired-compress-file (file &rest ok-flag) 2435(defun tramp-sh-handle-dired-compress-file (file &rest _ok-flag)
2437 "Like `dired-compress-file' for Tramp files." 2436 "Like `dired-compress-file' for Tramp files."
2438 ;; OK-FLAG is valid for XEmacs only, but not implemented. 2437 ;; OK-FLAG is valid for XEmacs only, but not implemented.
2439 ;; Code stolen mainly from dired-aux.el. 2438 ;; Code stolen mainly from dired-aux.el.
@@ -2978,7 +2977,7 @@ the result will be a local, non-Tramp, filename."
2978 (inhibit-file-name-operation 'insert-file-contents)) 2977 (inhibit-file-name-operation 'insert-file-contents))
2979 (unwind-protect 2978 (unwind-protect
2980 (progn 2979 (progn
2981 (fset 'find-buffer-file-type (lambda (filename) t)) 2980 (fset 'find-buffer-file-type (lambda (_filename) t))
2982 (insert-file-contents filename visit beg end replace)) 2981 (insert-file-contents filename visit beg end replace))
2983 ;; Save exit. 2982 ;; Save exit.
2984 (if find-buffer-file-type-function 2983 (if find-buffer-file-type-function
@@ -3383,7 +3382,7 @@ Fall back to normal file name handler if no Tramp handler exists."
3383 ;; Default file name handlers, we don't care. 3382 ;; Default file name handlers, we don't care.
3384 (t (tramp-run-real-handler operation args))))))) 3383 (t (tramp-run-real-handler operation args)))))))
3385 3384
3386(defun tramp-sh-handle-file-notify-add-watch (file-name flags callback) 3385(defun tramp-sh-handle-file-notify-add-watch (file-name flags _callback)
3387 "Like `file-notify-add-watch' for Tramp files." 3386 "Like `file-notify-add-watch' for Tramp files."
3388 (setq file-name (expand-file-name file-name)) 3387 (setq file-name (expand-file-name file-name))
3389 (with-parsed-tramp-file-name file-name nil 3388 (with-parsed-tramp-file-name file-name nil
@@ -3749,7 +3748,7 @@ file exists and nonzero exit status otherwise."
3749Looks at process PROC to see if a shell prompt appears in TIMEOUT 3748Looks at process PROC to see if a shell prompt appears in TIMEOUT
3750seconds. If not, it produces an error message with the given ERROR-ARGS." 3749seconds. If not, it produces an error message with the given ERROR-ARGS."
3751 (let ((vec (tramp-get-connection-property proc "vector" nil))) 3750 (let ((vec (tramp-get-connection-property proc "vector" nil)))
3752 (condition-case err 3751 (condition-case nil
3753 (tramp-wait-for-regexp 3752 (tramp-wait-for-regexp
3754 proc timeout 3753 proc timeout
3755 (format 3754 (format
diff --git a/lisp/net/tramp-smb.el b/lisp/net/tramp-smb.el
index 29847556dfe..0dd9286da2d 100644
--- a/lisp/net/tramp-smb.el
+++ b/lisp/net/tramp-smb.el
@@ -355,7 +355,7 @@ pass to the OPERATION."
355 (throw 'tramp-action 'ok))))) 355 (throw 'tramp-action 'ok)))))
356 356
357(defun tramp-smb-handle-copy-directory 357(defun tramp-smb-handle-copy-directory
358 (dirname newname &optional keep-date parents copy-contents) 358 (dirname newname &optional keep-date parents _copy-contents)
359 "Like `copy-directory' for Tramp files." 359 "Like `copy-directory' for Tramp files."
360 (setq dirname (expand-file-name dirname) 360 (setq dirname (expand-file-name dirname)
361 newname (expand-file-name newname)) 361 newname (expand-file-name newname))
@@ -492,7 +492,7 @@ pass to the OPERATION."
492 492
493(defun tramp-smb-handle-copy-file 493(defun tramp-smb-handle-copy-file
494 (filename newname &optional ok-if-already-exists keep-date 494 (filename newname &optional ok-if-already-exists keep-date
495 preserve-uid-gid preserve-extended-attributes) 495 _preserve-uid-gid _preserve-extended-attributes)
496 "Like `copy-file' for Tramp files. 496 "Like `copy-file' for Tramp files.
497KEEP-DATE has no effect in case NEWNAME resides on an SMB server. 497KEEP-DATE has no effect in case NEWNAME resides on an SMB server.
498PRESERVE-UID-GID and PRESERVE-EXTENDED-ATTRIBUTES are completely ignored." 498PRESERVE-UID-GID and PRESERVE-EXTENDED-ATTRIBUTES are completely ignored."
@@ -571,7 +571,7 @@ PRESERVE-UID-GID and PRESERVE-EXTENDED-ATTRIBUTES are completely ignored."
571 (tramp-error 571 (tramp-error
572 v 'file-error "%s `%s'" (match-string 0) directory)))))) 572 v 'file-error "%s `%s'" (match-string 0) directory))))))
573 573
574(defun tramp-smb-handle-delete-file (filename &optional trash) 574(defun tramp-smb-handle-delete-file (filename &optional _trash)
575 "Like `delete-file' for Tramp files." 575 "Like `delete-file' for Tramp files."
576 (setq filename (expand-file-name filename)) 576 (setq filename (expand-file-name filename))
577 (when (file-exists-p filename) 577 (when (file-exists-p filename)
@@ -1497,7 +1497,7 @@ Result is the list (LOCALNAME MODE SIZE MTIME)."
1497 "%s%s" 1497 "%s%s"
1498 (if (string-match "D" mode) "d" "-") 1498 (if (string-match "D" mode) "d" "-")
1499 (mapconcat 1499 (mapconcat
1500 (lambda (x) "") " " 1500 (lambda (_x) "") " "
1501 (concat "r" (if (string-match "R" mode) "-" "w") "x")))) 1501 (concat "r" (if (string-match "R" mode) "-" "w") "x"))))
1502 line (substring line 0 -6)) 1502 line (substring line 0 -6))
1503 (return)) 1503 (return))
diff --git a/lisp/net/tramp-uu.el b/lisp/net/tramp-uu.el
index c64d8dfa046..6cf5baeccd8 100644
--- a/lisp/net/tramp-uu.el
+++ b/lisp/net/tramp-uu.el
@@ -28,11 +28,11 @@
28 28
29;;; Code: 29;;; Code:
30 30
31(defvar tramp-uu-b64-alphabet 31(defconst tramp-uu-b64-alphabet
32 "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/" 32 "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"
33 "Mapping from base64-encoded character to the byte it represents.") 33 "Mapping from base64-encoded character to the byte it represents.")
34 34
35(defvar tramp-uu-b64-char-to-byte 35(defconst tramp-uu-b64-char-to-byte
36 (let ((i 0)) 36 (let ((i 0))
37 (mapcar (lambda (c) 37 (mapcar (lambda (c)
38 (prog1 38 (prog1
@@ -55,7 +55,6 @@
55 ;; First we base64 encode the region, then we transmogrify that into 55 ;; First we base64 encode the region, then we transmogrify that into
56 ;; uu encoding. 56 ;; uu encoding.
57 (let ((len (base64-encode-region beg end t)) 57 (let ((len (base64-encode-region beg end t))
58 (padding 0)
59 i c) 58 i c)
60 (save-excursion 59 (save-excursion
61 (goto-char beg) 60 (goto-char beg)
diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index 8ce5f2eae9b..ff090f8257f 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -1417,10 +1417,10 @@ The outline level is equal to the verbosity of the Tramp message."
1417 (set (make-local-variable 'outline-level) 'tramp-debug-outline-level)) 1417 (set (make-local-variable 'outline-level) 'tramp-debug-outline-level))
1418 (current-buffer))) 1418 (current-buffer)))
1419 1419
1420(defsubst tramp-debug-message (vec fmt-string &rest args) 1420(defsubst tramp-debug-message (vec fmt-string &rest arguments)
1421 "Append message to debug buffer. 1421 "Append message to debug buffer.
1422Message is formatted with FMT-STRING as control string and the remaining 1422Message is formatted with FMT-STRING as control string and the remaining
1423ARGS to actually emit the message (if applicable)." 1423ARGUMENTS to actually emit the message (if applicable)."
1424 (when (get-buffer (tramp-buffer-name vec)) 1424 (when (get-buffer (tramp-buffer-name vec))
1425 (with-current-buffer (tramp-get-debug-buffer vec) 1425 (with-current-buffer (tramp-get-debug-buffer vec)
1426 (goto-char (point-max)) 1426 (goto-char (point-max))
@@ -1480,14 +1480,14 @@ ARGS to actually emit the message (if applicable)."
1480; (1+ (count-lines (point-min) (cdr ffn))))))) 1480; (1+ (count-lines (point-min) (cdr ffn)))))))
1481 (insert (format "%s " fn))) 1481 (insert (format "%s " fn)))
1482 ;; The message. 1482 ;; The message.
1483 (insert (apply 'format fmt-string args))))) 1483 (insert (apply 'format fmt-string arguments)))))
1484 1484
1485(defvar tramp-message-show-message t 1485(defvar tramp-message-show-message t
1486 "Show Tramp message in the minibuffer. 1486 "Show Tramp message in the minibuffer.
1487This variable is used to disable messages from `tramp-error'. 1487This variable is used to disable messages from `tramp-error'.
1488The messages are visible anyway, because an error is raised.") 1488The messages are visible anyway, because an error is raised.")
1489 1489
1490(defsubst tramp-message (vec-or-proc level fmt-string &rest args) 1490(defsubst tramp-message (vec-or-proc level fmt-string &rest arguments)
1491 "Emit a message depending on verbosity level. 1491 "Emit a message depending on verbosity level.
1492VEC-OR-PROC identifies the Tramp buffer to use. It can be either a 1492VEC-OR-PROC identifies the Tramp buffer to use. It can be either a
1493vector or a process. LEVEL says to be quiet if `tramp-verbose' is 1493vector or a process. LEVEL says to be quiet if `tramp-verbose' is
@@ -1498,7 +1498,7 @@ The message is also logged into the debug buffer when `tramp-verbose'
1498is greater than or equal 4. 1498is greater than or equal 4.
1499 1499
1500Calls functions `message' and `tramp-debug-message' with FMT-STRING as 1500Calls functions `message' and `tramp-debug-message' with FMT-STRING as
1501control string and the remaining ARGS to actually emit the message (if 1501control string and the remaining ARGUMENTS to actually emit the message (if
1502applicable)." 1502applicable)."
1503 (ignore-errors 1503 (ignore-errors
1504 (when (<= level tramp-verbose) 1504 (when (<= level tramp-verbose)
@@ -1514,7 +1514,7 @@ applicable)."
1514 ((= level 2) "Warning: ") 1514 ((= level 2) "Warning: ")
1515 (t "Tramp: ")) 1515 (t "Tramp: "))
1516 fmt-string) 1516 fmt-string)
1517 args)) 1517 arguments))
1518 ;; Log only when there is a minimum level. 1518 ;; Log only when there is a minimum level.
1519 (when (>= tramp-verbose 4) 1519 (when (>= tramp-verbose 4)
1520 (when (and vec-or-proc 1520 (when (and vec-or-proc
@@ -1527,17 +1527,17 @@ applicable)."
1527 (apply 'tramp-debug-message 1527 (apply 'tramp-debug-message
1528 vec-or-proc 1528 vec-or-proc
1529 (concat (format "(%d) # " level) fmt-string) 1529 (concat (format "(%d) # " level) fmt-string)
1530 args))))))) 1530 arguments)))))))
1531 1531
1532(defsubst tramp-backtrace (vec-or-proc) 1532(defsubst tramp-backtrace (vec-or-proc)
1533 "Dump a backtrace into the debug buffer. 1533 "Dump a backtrace into the debug buffer.
1534This function is meant for debugging purposes." 1534This function is meant for debugging purposes."
1535 (tramp-message vec-or-proc 10 "\n%s" (with-output-to-string (backtrace)))) 1535 (tramp-message vec-or-proc 10 "\n%s" (with-output-to-string (backtrace))))
1536 1536
1537(defsubst tramp-error (vec-or-proc signal fmt-string &rest args) 1537(defsubst tramp-error (vec-or-proc signal fmt-string &rest arguments)
1538 "Emit an error. 1538 "Emit an error.
1539VEC-OR-PROC identifies the connection to use, SIGNAL is the 1539VEC-OR-PROC identifies the connection to use, SIGNAL is the
1540signal identifier to be raised, remaining args passed to 1540signal identifier to be raised, remaining arguments passed to
1541`tramp-message'. Finally, signal SIGNAL is raised." 1541`tramp-message'. Finally, signal SIGNAL is raised."
1542 (let (tramp-message-show-message) 1542 (let (tramp-message-show-message)
1543 (tramp-backtrace vec-or-proc) 1543 (tramp-backtrace vec-or-proc)
@@ -1546,16 +1546,16 @@ signal identifier to be raised, remaining args passed to
1546 (error-message-string 1546 (error-message-string
1547 (list signal 1547 (list signal
1548 (get signal 'error-message) 1548 (get signal 'error-message)
1549 (apply 'format fmt-string args)))) 1549 (apply 'format fmt-string arguments))))
1550 (signal signal (list (apply 'format fmt-string args))))) 1550 (signal signal (list (apply 'format fmt-string arguments)))))
1551 1551
1552(defsubst tramp-error-with-buffer 1552(defsubst tramp-error-with-buffer
1553 (buffer vec-or-proc signal fmt-string &rest args) 1553 (buf vec-or-proc signal fmt-string &rest arguments)
1554 "Emit an error, and show BUFFER. 1554 "Emit an error, and show BUF.
1555If BUFFER is nil, show the connection buffer. Wait for 30\", or until 1555If BUF is nil, show the connection buf. Wait for 30\", or until
1556an input event arrives. The other arguments are passed to `tramp-error'." 1556an input event arrives. The other arguments are passed to `tramp-error'."
1557 (save-window-excursion 1557 (save-window-excursion
1558 (let* ((buf (or (and (bufferp buffer) buffer) 1558 (let* ((buf (or (and (bufferp buf) buf)
1559 (and (processp vec-or-proc) (process-buffer vec-or-proc)) 1559 (and (processp vec-or-proc) (process-buffer vec-or-proc))
1560 (and (vectorp vec-or-proc) 1560 (and (vectorp vec-or-proc)
1561 (tramp-get-connection-buffer vec-or-proc)))) 1561 (tramp-get-connection-buffer vec-or-proc))))
@@ -1563,7 +1563,7 @@ an input event arrives. The other arguments are passed to `tramp-error'."
1563 (and buf (with-current-buffer buf 1563 (and buf (with-current-buffer buf
1564 (tramp-dissect-file-name default-directory)))))) 1564 (tramp-dissect-file-name default-directory))))))
1565 (unwind-protect 1565 (unwind-protect
1566 (apply 'tramp-error vec-or-proc signal fmt-string args) 1566 (apply 'tramp-error vec-or-proc signal fmt-string arguments)
1567 ;; Save exit. 1567 ;; Save exit.
1568 (when (and buf 1568 (when (and buf
1569 tramp-message-show-message 1569 tramp-message-show-message
@@ -1572,7 +1572,7 @@ an input event arrives. The other arguments are passed to `tramp-error'."
1572 (let ((enable-recursive-minibuffers t)) 1572 (let ((enable-recursive-minibuffers t))
1573 ;; `tramp-error' does not show messages. So we must do it 1573 ;; `tramp-error' does not show messages. So we must do it
1574 ;; ourselves. 1574 ;; ourselves.
1575 (message fmt-string args) 1575 (message fmt-string arguments)
1576 ;; Show buffer. 1576 ;; Show buffer.
1577 (pop-to-buffer buf) 1577 (pop-to-buffer buf)
1578 (discard-input) 1578 (discard-input)
@@ -3281,7 +3281,7 @@ beginning of local filename are not substituted."
3281 (setq filename (concat filename "/")))) 3281 (setq filename (concat filename "/"))))
3282 (tramp-run-real-handler 'substitute-in-file-name (list filename))))) 3282 (tramp-run-real-handler 'substitute-in-file-name (list filename)))))
3283 3283
3284(defun tramp-handle-unhandled-file-name-directory (filename) 3284(defun tramp-handle-unhandled-file-name-directory (_filename)
3285 "Like `unhandled-file-name-directory' for Tramp files." 3285 "Like `unhandled-file-name-directory' for Tramp files."
3286 ;; With Emacs 23, we could simply return `nil'. But we must keep it 3286 ;; With Emacs 23, we could simply return `nil'. But we must keep it
3287 ;; for backward compatibility. 3287 ;; for backward compatibility.
@@ -3341,7 +3341,7 @@ of."
3341 ;; only if that agrees with the buffer's record. 3341 ;; only if that agrees with the buffer's record.
3342 (t (equal mt '(-1 65535)))))))))) 3342 (t (equal mt '(-1 65535))))))))))
3343 3343
3344(defun tramp-handle-file-notify-add-watch (filename flags callback) 3344(defun tramp-handle-file-notify-add-watch (filename _flags _callback)
3345 "Like `file-notify-add-watch' for Tramp files." 3345 "Like `file-notify-add-watch' for Tramp files."
3346 ;; This is the default handler. tramp-gvfs.el and tramp-sh.el have 3346 ;; This is the default handler. tramp-gvfs.el and tramp-sh.el have
3347 ;; its own one. 3347 ;; its own one.
@@ -3365,7 +3365,7 @@ of."
3365;; prompts from the remote host. See the variable 3365;; prompts from the remote host. See the variable
3366;; `tramp-actions-before-shell' for usage of these functions. 3366;; `tramp-actions-before-shell' for usage of these functions.
3367 3367
3368(defun tramp-action-login (proc vec) 3368(defun tramp-action-login (_proc vec)
3369 "Send the login name." 3369 "Send the login name."
3370 (when (not (stringp tramp-current-user)) 3370 (when (not (stringp tramp-current-user))
3371 (setq tramp-current-user 3371 (setq tramp-current-user
@@ -3392,11 +3392,11 @@ of."
3392 ;; Hide password prompt. 3392 ;; Hide password prompt.
3393 (narrow-to-region (point-max) (point-max))))) 3393 (narrow-to-region (point-max) (point-max)))))
3394 3394
3395(defun tramp-action-succeed (proc vec) 3395(defun tramp-action-succeed (_proc _vec)
3396 "Signal success in finding shell prompt." 3396 "Signal success in finding shell prompt."
3397 (throw 'tramp-action 'ok)) 3397 (throw 'tramp-action 'ok))
3398 3398
3399(defun tramp-action-permission-denied (proc vec) 3399(defun tramp-action-permission-denied (proc _vec)
3400 "Signal permission denied." 3400 "Signal permission denied."
3401 (kill-process proc) 3401 (kill-process proc)
3402 (throw 'tramp-action 'permission-denied)) 3402 (throw 'tramp-action 'permission-denied))
@@ -3429,7 +3429,7 @@ See also `tramp-action-yesno'."
3429 (tramp-message vec 6 "\n%s" (buffer-string))) 3429 (tramp-message vec 6 "\n%s" (buffer-string)))
3430 (tramp-send-string vec (concat "y" tramp-local-end-of-line))))) 3430 (tramp-send-string vec (concat "y" tramp-local-end-of-line)))))
3431 3431
3432(defun tramp-action-terminal (proc vec) 3432(defun tramp-action-terminal (_proc vec)
3433 "Tell the remote host which terminal type to use. 3433 "Tell the remote host which terminal type to use.
3434The terminal type can be configured with `tramp-terminal-type'." 3434The terminal type can be configured with `tramp-terminal-type'."
3435 (tramp-message vec 5 "Setting `%s' as terminal type." tramp-terminal-type) 3435 (tramp-message vec 5 "Setting `%s' as terminal type." tramp-terminal-type)
@@ -3437,7 +3437,7 @@ The terminal type can be configured with `tramp-terminal-type'."
3437 (tramp-message vec 6 "\n%s" (buffer-string))) 3437 (tramp-message vec 6 "\n%s" (buffer-string)))
3438 (tramp-send-string vec (concat tramp-terminal-type tramp-local-end-of-line))) 3438 (tramp-send-string vec (concat tramp-terminal-type tramp-local-end-of-line)))
3439 3439
3440(defun tramp-action-process-alive (proc vec) 3440(defun tramp-action-process-alive (proc _vec)
3441 "Check, whether a process has finished." 3441 "Check, whether a process has finished."
3442 (unless (memq (process-status proc) '(run open)) 3442 (unless (memq (process-status proc) '(run open))
3443 (throw 'tramp-action 'process-died))) 3443 (throw 'tramp-action 'process-died)))